From: Wei Yang <richard.weiyang@gmail.com>
To: Liam.Howlett@oracle.com, akpm@linux-foundation.org
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
Wei Yang <richard.weiyang@gmail.com>,
"Liam R . Howlett" <Liam.Howlett@Oracle.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: [PATCH 1/2] maple_tree: not necessary to check index/last again
Date: Tue, 15 Oct 2024 23:39:08 +0000 [thread overview]
Message-ID: <20241015233909.23592-2-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20241015233909.23592-1-richard.weiyang@gmail.com>
Before calling mas_new_root(), the range has been checked.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
CC: Sidhartha Kumar <sidhartha.kumar@oracle.com>
CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
lib/maple_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 0aa9fa8fa7de..3a12866a4a89 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -3594,7 +3594,7 @@ static inline void mas_new_root(struct ma_state *mas, void *entry)
void __rcu **slots;
unsigned long *pivots;
- if (!entry && !mas->index && mas->last == ULONG_MAX) {
+ if (!entry) {
mas->depth = 0;
mas_set_height(mas);
rcu_assign_pointer(mas->tree->ma_root, entry);
--
2.34.1
next prev parent reply other threads:[~2024-10-15 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 23:39 [PATCH 0/2] fix mas_new_root() Wei Yang
2024-10-15 23:39 ` Wei Yang [this message]
2024-10-15 23:39 ` [PATCH 2/2] maple_tree: one single entry couldn't represent the whole range Wei Yang
2024-10-16 1:27 ` Liam R. Howlett
2024-10-16 0:42 ` [PATCH 0/2] fix mas_new_root() Liam R. Howlett
2024-10-16 1:25 ` Liam R. Howlett
2024-10-16 2:18 ` Wei Yang
2024-10-16 2:32 ` Liam R. Howlett
2024-10-16 3:16 ` Wei Yang
2024-10-16 3:24 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015233909.23592-2-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maple-tree@lists.infradead.org \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox