From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 031BBD216A2 for ; Tue, 15 Oct 2024 13:31:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88A116B008C; Tue, 15 Oct 2024 09:31:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83ACE6B0092; Tue, 15 Oct 2024 09:31:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 701C96B0093; Tue, 15 Oct 2024 09:31:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4E2F26B008C for ; Tue, 15 Oct 2024 09:31:33 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 345D6ABEC9 for ; Tue, 15 Oct 2024 13:31:15 +0000 (UTC) X-FDA: 82675923414.24.620D02A Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf07.hostedemail.com (Postfix) with ESMTP id 1C9354001E for ; Tue, 15 Oct 2024 13:31:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZWFMPn9X; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728999043; a=rsa-sha256; cv=none; b=lYsmY5GXoyo6XokuDoM8qfE03PPaNY/ttTKLQ7Jad773eFKTeLNqpfK5lin4E2oovZwZ1d /Sl388tHT0H4dtzpkDm8gcw9VR56zga6OCBkFJkx/KNw0TzvGE204ayheCgiQ46jMeOH0o K+Hfbor+nC+395VGuxZ6A1fZHzIehGQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZWFMPn9X; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728999043; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=46mrZaJz5A8gmyf2ZZGCnAO8T2IkKjPfrsulNuqAvpk=; b=YqsmGxc8Ukub9oGh0559KHNg5oZN4zKYA0NoI5xKeQRpSA+BlGuAvVA1aTKid/kW5GmEf/ hnfLomyojspdUtQHj3gIIFrbuUM4yoFtkco97va6vluBmR9ZgI1BCCbKbLkHwtW+oJHZNf GzHiW1OOp81agzkIbw+sSfsLm7n/4XU= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2f7657f9f62so52432961fa.3 for ; Tue, 15 Oct 2024 06:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728999089; x=1729603889; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=46mrZaJz5A8gmyf2ZZGCnAO8T2IkKjPfrsulNuqAvpk=; b=ZWFMPn9X8QRmKLjNly5vpXqLudNV+dS/3MSrhoAMMvPlfIWn50xLpbJhFeKeKG9BSX jGnUEuDKC8T+6rNK3pL+2UDl4vlYuI6HBvsVmD1gMG+BSyIkNw5smHXo4h9GpyobaDxt 0kD8ocycwK7rTxr3ZXqvNGgT1T6tHg0DsgqQLqRcWC0WxPjIJwelZ44uYjDJ4w4kv4pO D28tGkO430pPQsNsCMt88wHiuWHM7mWU1L0Dq6b4C18ILFpm0YFVKeyiyGSPVcHivWcI aYfUDkDR84/bbnRhmXbJhXV+VP6y8AHlixo+oVtayJixRA2Eg/nhd8/bSehNCfwHrfnA se0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728999089; x=1729603889; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=46mrZaJz5A8gmyf2ZZGCnAO8T2IkKjPfrsulNuqAvpk=; b=a5U80edDXCq7zU+SQryDoLMQt5ExtgFEGB28qIi+ZNj0YCXBk9ljuj2LX3upV7wPB0 +Ot5FL/SAGqRhGRcxnO8+lsVtl7bAjB+AFcmpye0VEqThx35PmlEtFoldFf0AJ0zzLwU eM4YHdcjWuAvI1FUDxTroM+Q2f+KHYlTLeIGNGRGJLTlDoRCRVqwSJwZ2xLFwngni9MT /xmh48npvXeoaj7/fuRYhjLKHHL7/Ujnrau99z7oOaOiAGnG3QGZA5cGK9W4HnwuqOyD 1QO4EAVdBdjEEaBnC0wK48vaSQdFeN30h9dRjiWXZf2Q+Kceh9ysfKR7+hJ5Er77GYVs cUzQ== X-Forwarded-Encrypted: i=1; AJvYcCWlXguz1aiCXvhmi0MuwErtKYC2SuOZ67yHFkH9jreOi3MfY0Wrcpmbp7P3B1zXoDVS8eCZT7uVJA==@kvack.org X-Gm-Message-State: AOJu0Yz2+d4EpA8K5vcAITO1koRT2/tpTw+DvMPFQHNRzakhrTkH6xa4 TkTugPbbtMbkLS/WZanf234tWtS5EQBJxWS5QTuUr/hiUrZO+L8ASt6N8hsd X-Google-Smtp-Source: AGHT+IGSNcimW+7z1u8OqBLcuUwQwNc6Lat0Yu/fYMeyYqUjgyYErLJUwCcTDxvOejHs/ry0iXaHAg== X-Received: by 2002:a05:651c:b06:b0:2fb:b8a:7abb with SMTP id 38308e7fff4ca-2fb61b6ebbemr3222721fa.21.1728999088592; Tue, 15 Oct 2024 06:31:28 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c98d4d6851sm709470a12.5.2024.10.15.06.31.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Oct 2024 06:31:26 -0700 (PDT) Date: Tue, 15 Oct 2024 13:31:25 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , linux-mm@kvack.org, Andrew Morton , Jiazi Li , linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Subject: Re: [PATCH 2/2] maple_tree: Add some alloc node test case Message-ID: <20241015133125.aixhbw5kunbme2nt@master> Reply-To: Wei Yang References: <20240626160631.3636515-1-Liam.Howlett@oracle.com> <20240626160631.3636515-2-Liam.Howlett@oracle.com> <20241011011759.wbw56sqgmhzjwo4k@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: 1C9354001E X-Rspamd-Server: rspam01 X-Stat-Signature: e5yigegs8p3juatsehc6znquwspmqkh9 X-HE-Tag: 1728999079-584399 X-HE-Meta: U2FsdGVkX1+Qgm46D908/j5Hb9jUrTsDtpg5CttbBCknshE6wZdk93a6LIbT96np2dF1yFblndzC5tQtufFbJ+T2B1QKQ0iYoQd1TVEQ1O4XL5T0QHwkgV0Y+rwNWUs+5yvSo05qRG2iwpj0ptzhZiB6/RgxqZ8jHhWhsqBR1KObbih2ryuVPIPqzXD+LYgXWEzJMxO2ephhVvewjcx2J1zM9r5wvJm9d1wnQqIJmLPNNPNE+bnpkunQ6uUkkISXZ6arRwNc4iHWYlEajhERGflNacHPgV0DnVYl61fE0lzUuqZx5808uSD1jdGG6huJM9sNMkXPRbz8dtoKZ72qA+sE/WRp2dN9weFir65R8zy6SLWkawW9Pa5uIUZpPEeRqRRlZpNcMKwjZQNLtYCFsrXuxVvPCrclQs805DCQywTQ3P3SNsmdOpHGdQ5AOUwOlxqVEA9RN0diNnG3Pvl4sJDT32kkZeyLDUtZmiadwut7+uCgaljicyta+qPmzNd9Or7hAArqjOuM2rXlvu4u+oQT3k6tWKRgnKoxydT8HG+SLda21L2GNV/y8ubNrTMj4meqEBboG+5OGZgnl4PrgWgVjoh+evBcrWGEnTagJdlvAYsLu1Tj+5MyH79843UzP2bF65Jd5gSuDsk37CHhRsPsFtZWh4tZrqX5G+l9X7/O+33ZJ+rO7/WT41N8gk49G/WQ/BEiZBpJgFYp+AHzLTYJGUsf7sYdMOGtLbPcQXSBj+X9J4IW7U/iWbk+H65KuA1VBoCETCFtUf97IABxaJotK6NnaC9A+ti0C70uN7ybSro01XVK9dsRDkPGuRZLI7o7PSTMTOtIWjyx8sOB+baqcqUIix5ZBhwbYB/Dzo0Mr5HczYNXI9LdM38V4bF2dz5qfv9H6RninDCm74MDrwO9nVoXXuxgpSv7nTAQ1t3TSAalLq3zf3eFgcDxddzrWlcI43u10o1DrgGhmRO GpPrQUVw 1nohI03+fOKcEf3eWOFybBFWBLU0xGl33qem2xFFBdXEyeFRn86AheWDt7UUFCxU152UyZmrs5pO/cLLEiHMM0qY0Du5Y0Hz2fsqkr0L91d75aS5loX56i/ogyvYBYH363uKTOyX117cHQcZxqT7S6iA9DvwP3HMpBipIAOD6zqb7JxUXbeg8pFHAxJ98aw/ftQNBTpuorl+dvZVRvL5gkkgB6JzlBDf05RxQtVWJgltCFzLiuSGiMmZo43iVwwQeHsA/Y/O87PUwuX4Z7zoAywWbkhwVCmyO+I5LZucUgkFq3Xpj1lIzhF7zzbKjET6HYiRCzbjHceaFHLcrwAZA3w6ob1dzNvdGP65vqkfpWX/ZEEFbjhHiXSXUuoG/B1JxnT4WRHbKUXW/dSrQKMDR3ZL46RMNZXen0hqKgqLozrxpgBrR1byrNMd7xvL47+AE+9OSHOHST6F/0UXTfcOcMBHl07T5ZISl/EIOz2S4oUgGj8d09TB6wAlWokGamAnkVTjDWIx4UfYXRTozjNbvBf3pP0cVpEcVAg3ClUvsNeZt+CuXXAMqKxn47lmRvpd+q4J4EOQxUcavcbgthWNd5E/1iZKzD0Gi5UOu/Xo4Ve65IKvsvHx6uqxe8sY5z4Y18yMeGlK0US9yyvo2vnXsQmoodBWoCqa7RC5R/zjxgLmPwuHQrpXHyYQNbzbYmzCsx7RYv4c99im8Gz//ubf1mL8mWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 09:15:07PM -0400, Liam R. Howlett wrote: >* Wei Yang [241010 21:18]: >> On Wed, Jun 26, 2024 at 12:06:31PM -0400, Liam R. Howlett wrote: >> >From: Jiazi Li >> > >> >Add some maple_tree alloc node tese case. >> > >> >Suggested-by: Liam R. Howlett >> >Signed-off-by: Jiazi Li >> >Signed-off-by: Liam R. Howlett >> >--- >> > tools/testing/radix-tree/maple.c | 22 ++++++++++++++++++++++ >> > 1 file changed, 22 insertions(+) >> > >> >diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c >> >index 11f1efdf83f9..b4b5fd9f294d 100644 >> >--- a/tools/testing/radix-tree/maple.c >> >+++ b/tools/testing/radix-tree/maple.c >> >@@ -462,6 +462,28 @@ static noinline void __init check_new_node(struct maple_tree *mt) >> > MT_BUG_ON(mt, mas_allocated(&mas) != 10 + MAPLE_ALLOC_SLOTS - 1); >> > mas_destroy(&mas); >> > >> >+ mas.node = MA_ERROR(-ENOMEM); >> >+ mas_node_count(&mas, MAPLE_ALLOC_SLOTS + 1); /* Request */ >> >+ mas_nomem(&mas, GFP_KERNEL); /* Fill request */ >> >> I am not sure why mas_nomem() is here. >> >> Without this one, we still can trigger the original bug. > >It will fill the maple state allocation. Might not be needed but >doesn't hurt. > I took another look at it. We really need mas_nomem() here, since we call mt_set_non_kernel(0) at the beginning of check_new_node(). So mas_node_count() just set the request count and mas_nomem() does the real allocation. Any reason to design test case like this? >> >> >+ MT_BUG_ON(mt, mas_allocated(&mas) != MAPLE_ALLOC_SLOTS + 1); >> >+ mas.node = MA_ERROR(-ENOMEM); >> >+ mas_node_count(&mas, MAPLE_ALLOC_SLOTS * 2 + 2); /* Request */ >> >+ mas_nomem(&mas, GFP_KERNEL); /* Fill request */ >> >+ mas.status = ma_start; >> >+ MT_BUG_ON(mt, mas_allocated(&mas) != MAPLE_ALLOC_SLOTS * 2 + 2); >> >+ mas_destroy(&mas); >> >+ >> >+ mas.node = MA_ERROR(-ENOMEM); >> >+ mas_node_count(&mas, MAPLE_ALLOC_SLOTS * 2 + 1); /* Request */ >> >+ mas_nomem(&mas, GFP_KERNEL); /* Fill request */ >> >+ MT_BUG_ON(mt, mas_allocated(&mas) != MAPLE_ALLOC_SLOTS * 2 + 1); >> >+ mas.node = MA_ERROR(-ENOMEM); >> >+ mas_node_count(&mas, MAPLE_ALLOC_SLOTS * 3 + 2); /* Request */ >> >+ mas_nomem(&mas, GFP_KERNEL); /* Fill request */ >> >+ mas.status = ma_start; >> >+ MT_BUG_ON(mt, mas_allocated(&mas) != MAPLE_ALLOC_SLOTS * 3 + 2); >> >+ mas_destroy(&mas); >> >+ >> > mtree_unlock(mt); >> > } >> > >> >-- >> >2.43.0 >> > >> >> -- >> Wei Yang >> Help you, Help me -- Wei Yang Help you, Help me