From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B881DCFC278 for ; Tue, 15 Oct 2024 08:47:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53DB46B0093; Tue, 15 Oct 2024 04:47:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EE066B0095; Tue, 15 Oct 2024 04:47:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B5A06B0096; Tue, 15 Oct 2024 04:47:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E53B6B0093 for ; Tue, 15 Oct 2024 04:47:20 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 683AB1A1434 for ; Tue, 15 Oct 2024 08:47:04 +0000 (UTC) X-FDA: 82675207230.12.0F61DD5 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id 1E15DA0012 for ; Tue, 15 Oct 2024 08:47:10 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ck5P7Vw2; spf=pass (imf15.hostedemail.com: domain of nathan@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728981848; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FjFw0VuwLzwC/zd2y4uNR3d0jhJvU4zXhOfcOFhp4lo=; b=FWrFKyHl41X6xqoFMu4MSEmXM/GY2N3ectwMLMY8ydbnUyownrm82gPx7EOHjlMIrBJ7qI vLagbuKzJIMXRRs+gF+g/RkT366kYrMY2YQD5R7miUqt4Evpgbs2JZw+A5MhiIB8HhoUDy PPujeofoF/fiIjO6AWhLG8CUlPW1NkQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ck5P7Vw2; spf=pass (imf15.hostedemail.com: domain of nathan@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728981848; a=rsa-sha256; cv=none; b=HGs+wCIjrR6EkS4pvsb5yPinA7kRY7MbvFJi/DnRkk+IjXO8bl3lrOhNPlBEKg5YmSILdH D1JrsWepwLVzfcihQ250XRhjPQ2kpRYjaCOwMHObKQ52wR6nOvJIBOElIm8rZ12ZLKqahE dtUoE8kRz+bQi+M+G2CIAeNGP12K70Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7B57FA416E7; Tue, 15 Oct 2024 08:47:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7265FC4CEC7; Tue, 15 Oct 2024 08:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728982037; bh=GSyH1y44mWS97cSZ26SGIRn8xE87mpkD/PDkcLOGKQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ck5P7Vw2PAigQOtG4ojaNsD2l8NyFMxB91eLFVrszA+pYRZfnTRoallMY9J9W42dS Ll2SRpXaNFhpB4e6QjMjwyZ30ugvUT3iale79Msj/DI4NQjdaFq73BEwgTDNH1m2M7 p+75V0Ao2Bb7fBPqL4NzbI+QhJvmQA5UAo9+HiSYaMTQa5a5gJPYr6hbQ/Viq/tEtO D3U/0XTFhIgjCUDzirTYzAzo44nT/b4uG2SPQtq6ftn9zYRKnsmXFYpJrpYEdxvFdA xvbqbSBq/QLnXUexWIGDiDRLHbySI+iNJ7aiU1TQPnd8wgb8WNq3FJRy7cmqU6ymSH JyTX7n9IocinQ== Date: Tue, 15 Oct 2024 01:47:14 -0700 From: Nathan Chancellor To: Arnd Bergmann Cc: Aleksei Vetrov , Shivamurthy Shastri , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Matthew Wilcox , Johannes Weiner , Anna-Maria Gleixner , Thomas Gleixner , llvm@lists.linux.dev Subject: Re: [PATCH] mm/vmstat: Fix -Wenum-enum-conversion warning in vmstat.h Message-ID: <20241015084714.GA1546610@thelio-3990X> References: <20240621111604.25330-1-shivamurthy.shastri@linutronix.de> <20241008005136.GA241099@thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1E15DA0012 X-Stat-Signature: jeoho91oma7q58myzt8s9hzq7tqs4cx7 X-Rspam-User: X-HE-Tag: 1728982030-115382 X-HE-Meta: U2FsdGVkX19+M14MMGuStRvDutXJm/8BfbezuZBS9WAKoKL7ySUV6EmhOugvVRGI/O+OgFG9w71H1jiIfA3CZzwldn2e5ocMjY6qebG4O91Lmhoe6wZikncSIr5BbejqZ2ub3p28BWCU/GoGtmNYHQOektPVMMvuxjsvdd9F/TKgrv55Iu7NlFj+5B7zBVIG8TtbVimPlNSNl4aaAW32/eMvwKZFeNSRBih+Jjasuwacw78qLDLIvJe64xjZS2L8Bmm4DrHV6CT98UnPBcNCn68Ag4FlJw5dH1NBO/Q1Idgm3yoeIG0X7jRwF6J/d+780+fgLugDsh2PTyiTi5HrNqXnvGH1DcwV7ihWamRG9azPiBe1iqzggJmIPgF6QDxmjew8rDAcqWyEm/yD2m8Ft+FLxLu7eblzy8qBFL1AXBEqX3VdbzHw0r1b9JOO8y651yO5Xe3Ftu2v3NFUUOeOl6btxv39mkjOut8k9p1f9MffP9XAH7AW7Kl0eLYnkwTu0n8y8nODSlxjzjgJ22eDTmd1iraVyiwKekzada9t9RkgjUCTwwCYy+Z8kjrwwKSM7vZ8iWZSQtUbPmqheYCAeMJkSMfxNN1kOlGStGFYtyg39DVCKjXCsWq594ygkSfIQNcTrdXNhqiOzG3N0joRfVcSdz6A+V3u23ZRzPog+E2eTOXiGebhloiG3CfnXLFN9DREynLanOqDl+b8tbIspW0P4Ag+5rGyQDC1vOsinLRkCknwTDkc/ChielJ0yQI+tHmD+8565m3++jd7+arjZ6e+AQ69i/8vRkGjg/AobmPPzDFMfk5sOyQCbHIPEWyuJ+nJnYPumNFsJPyGONIz4gpUErFduTB97V669gxeOOmDi0IWik/K62/Zs5geT2DVTAZfh9Agt0jQk8I+BRuVcXrM2RuDVgqk5ioWonZ0m2gzhVFQbBoHvQ81IAAayz9QJFvYplEGauFwRXGHfAI 0YlzNPHx zPKGSHYv1e2H55RV1kM/ssuwW7YlrPmfvvLfblIjnlXw4O0F2g55kxMXdj6ZBUqn5BLrQPbCN5Nw+PU2LN9I2gHurEeuuRRtLzJks9PhzfQotkgUgp51o+e6uSQe/DJRqC1KuiK9HtttlrJqPqZQa/JMOnPxSQSzkQzlWSCwrttBGUPHHBr9uM/G4jdy4AMEZSaPxLTEc7XGQuEv2TqJ6K0lA9gB3ebBPU3dWsiQ4ZRfB0cP9J0ZL52o+JQO0BsxN53QokYcbYyew4fEAKQchWXMNcPTx01jI6W6VCL2XKXvX3y8JFRZrHk6U7vS0Wi3igXB3ufuNp5AcdxX/0f1k/F+O4uh9cBNya3Ka X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 11, 2024 at 02:05:00PM +0000, Arnd Bergmann wrote: > I'm fairly sure I saw users mix up 'dma_data_direction' with > 'dma_transfer_direction' and unrelated enum-enum mixups in > amdgpu. There were probably more. Yes, those have definitely happened but those are -Wenum-conversion, not -Wenum-enum-conversion. > I think what happened is that in clang-18 and earlier, the > warning option caught mistakes of passing the wrong enum > to a function and a few others, but it did not catch arithmetic > operations between enums, so clang-19 now produces a lot more > output than older versions, and I don't think we can > control those independently. A contrived example: https://godbolt.org/z/Ydx6rxsvb We should be able to disable -Wenum-enum-conversion without impacting the ability to catch the cases that you mentioned above. It also helps that GCC supports -Wenum-conversion, but it does not seem like they have an equivalent for -Wenum-enum-conversion. Cheers, Nathan