From: David Sterba <dsterba@suse.cz>
To: Filipe Manana <fdmanana@suse.com>
Cc: kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>
Subject: Re: [linux-next:pending-fixes 207/319] fs/btrfs/qgroup.c:2014:6: error: use of undeclared identifier 'bytenr'
Date: Tue, 15 Oct 2024 00:06:37 +0200 [thread overview]
Message-ID: <20241014220637.GF1609@suse.cz> (raw)
In-Reply-To: <CAKisOQGSRdm=XurQ_Fd83c6dRsVLeg7Jbh4DRMARRHqsxHvf=w@mail.gmail.com>
On Mon, Oct 14, 2024 at 05:26:26PM +0100, Filipe Manana wrote:
> > > David, how do you prefer to proceed here? Do you want me to fix this
> > > and resend the patchset?
> >
> > No need to resend, I'll fix it locally, the patch in next-fixes was the
> > old one so I'll sync it with what's in our development for-next (and
> > also check the others just in case). I'll also check and update all the
> > branches involved in the for-next pulled by linux-next.
>
> Btw, I noticed that only the 2nd patch ("btrfs: use sector numbers as
> keys for the dirty extents xarray") was updated,
> so now it doesn't break 32 bits builds anymore.
>
> However the next patch in the series ("btrfs: qgroups: remove bytenr
> field from struct btrfs_qgroup_extent_record") wasn't updated,
> and it now breaks 32 bits builds. At the same location, it needs to
> use "bytenr" instead of "record->bytenr".
My bad, I manually tested the build combinations in the first patch only
as it went to Linus' tree. I did not get any other linux-next build
failures though.
> Do you want me to update the patches and send them to the list?
>
> There's one more change that needs to be squashed (to that last patch)
> that triggers a use-after-free reported by syzbot, which is:
>
> https://lore.kernel.org/linux-btrfs/02fc507b62b19be2348fc08de8b13bd7af1a440e.1728922973.git.fdmanana@suse.com/
Ok, please send it and feel free to update the patch in for-next too.
Thanks.
prev parent reply other threads:[~2024-10-14 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 2:54 kernel test robot
2024-10-09 10:09 ` Filipe Manana
2024-10-09 11:30 ` David Sterba
2024-10-14 16:26 ` Filipe Manana
2024-10-14 22:06 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014220637.GF1609@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox