From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAEB3D18134 for ; Mon, 14 Oct 2024 17:17:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 145726B0085; Mon, 14 Oct 2024 13:17:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F6496B0088; Mon, 14 Oct 2024 13:17:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFF6E6B0089; Mon, 14 Oct 2024 13:17:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D1DEE6B0085 for ; Mon, 14 Oct 2024 13:17:03 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 73D11141112 for ; Mon, 14 Oct 2024 17:16:55 +0000 (UTC) X-FDA: 82672863042.28.6635396 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf10.hostedemail.com (Postfix) with ESMTP id C5A39C0017 for ; Mon, 14 Oct 2024 17:16:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728926079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2HAy/3qlHEIDab3LbeRExaE4SL9R3iG6xJdOnjHQIW4=; b=XhuH8PnLjOeROAARJbmlmhsu06rOVha187iz73QJ+0VSEl+/+CLBSe0KSBIUxN1HMmbhYO vYKPF2ELYKTSapOBXw75MKKADravMjMW7uNpTjMgAc8oEC99NVrce3yhgXiK0Mg04yaux+ VKuxpSbEIfie6bSqxOLIxCgDm0yJfyk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728926079; a=rsa-sha256; cv=none; b=eCrtlR2esoJtC9i22YFsJGAaJBItlLRM7UbrWoKaIvRvi+Nb54/aHHPZclWDtGefibadkZ N74fAvGGvNktsL4NEdFG4vpE3d9UnBP3p893BrKo7Ht0jX6CAiZ66kK0f11UmwuIs5glk9 HtmbsaHsN2nwVCuP3B9uQOzoynhWV7E= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XS3mS5pQJz6HJpx; Tue, 15 Oct 2024 01:16:24 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 43E88140CF4; Tue, 15 Oct 2024 01:16:57 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 19:16:55 +0200 Date: Mon, 14 Oct 2024 18:16:54 +0100 From: Jonathan Cameron To: Greg KH CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 12/18] platform: Add __free() based cleanup function for platform_device_put Message-ID: <20241014181654.00005180@Huawei.com> In-Reply-To: <2024101451-reword-animation-2179@gregkh> References: <20241009124120.1124-1-shiju.jose@huawei.com> <20241009124120.1124-13-shiju.jose@huawei.com> <20241014164339.00003e73@Huawei.com> <2024101410-turf-junior-7739@gregkh> <2024101451-reword-animation-2179@gregkh> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C5A39C0017 X-Stat-Signature: ideednzj5ug181trkcmgs1ypxn5mc6sg X-HE-Tag: 1728926217-861323 X-HE-Meta: U2FsdGVkX19DIqYqYtJH5hjZm9qvP6h4L3XROeAXEyZ/QHCckuy0OnIzbKKf+HNVCyhyFgOIZxI+m89ep6GavZjUYKRB5Z3G5+qV7TJC6yQIIzqelYvwdT/nhND99PGLMIhGm/L/vzrPrwJrKwNqdxt0emsKR/RPjUvcWKlKHGW157T7qnu2oQmRm8s14kXG7CVgEDXP5enV0mLyutFrWFEDM7dyZtf+Eh1q9e1kvRNjIxB/TQR3vLNGxg2qtEevUKqBFDNZkkVtVY9Vhyvu83Q75iPfECH6z+dcZVggqdLwIC1NoTF3mxfsftZiXMzX/7SO0VX0oPYc1Kr0uuEeO3JCUPVWDfHNxsGo6BdvnMd/KkPZ70I5u3T7y4sjyaho6lRfLCCpNlDPaq3JMqo6AiMY7tX9BlGOOqY5a4ICUxIzcMkyZi89/d7QDOkAAgT/rc2/9WaK0MtJnWfTziT2gdTXWEb2LOEFESf3SJSmEMPHZ9cD+4UJPHpLChE9bzRNBMbJ6nSglhA6e4+HIE6BqcTs2fxAE6azRZBpioZC9i4qEpcfZGzs2YZTgZwsaVAXaSbQwJXP/brz+1VAsDm1HUHew20DfHp5/5v/DmhYq9FiMGEkuD8nJ/igTmFBtiJ/9fVomReloUS/e6ypQVVIi89BXQ7/FfW9iU7skQNx7K+Fi0SJC9Gs8BzMS5wm9nvSJ9p/kxMid7g7upgaYJnCrbtQL6pZ49oaeInHwefQEJGKsE1OYZHDqJfX/OjFbG1EAYT+otTZABjzsHwqDA+jr6UHaClPwRSH1+Bca1A4HfEbyA/Em3vWTPvhWAU3h+3sOUIm38pL3jHakWy+mHMg1wuUVWevS3cEim2VoMDZfotYGn3qUV1NSd9aDpdre1D+3Lgkiy2JrtTMM6th1554UEzNzZ6ZZ5lYfbir8l4dWuAK2lHoYrs0VMbTIMbidcQbZw6ujEgce/3ikbUPzVp kSHwxl0D gR4fKEwGdwiZIuSTq+VteyK9UGORRTiXmFn6vzXYUmiPgXjtk7fFy2ONyFcSFAcytfs6o/TrXSJXB4jRivTt+jpARqr7j4IPtq47KlH97Tm4xSZAUGv7g22+wZrUZiIljz37fnPjp+WXRcC+U26ZuUxE36EJAWymB3HhRKSZJe3w87zBa/VYFuydkT8Bu8wTA5TcJF++ooegIAUZIR3KiEMHZbF7lyw1g8krDjFCffoVwZt1Zaf4z+HoLTJXt/iHiQQFptN085J2T9COG6jzfnjJCUOjOxRZGFg2OCsUaYbN2VBJU4xwfMAn3FOBLyEDgjWPEHg8Q+NZVjf/aJ2acWSvrG9u6MjhJVCf942tgOb2EmSp3ZfymPYXUtTKImrq9m+lo4BARLaIV9f2hxaB9mwyWaQzo8ygYsS0uaqYClq1Qz5hLv8PtIUSvyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 14 Oct 2024 18:04:37 +0200 Greg KH wrote: > On Mon, Oct 14, 2024 at 06:00:51PM +0200, Greg KH wrote: > > On Mon, Oct 14, 2024 at 04:43:39PM +0100, Jonathan Cameron wrote: > > > On Wed, 9 Oct 2024 13:41:13 +0100 > > > wrote: > > > > > > > From: Jonathan Cameron > > > > > > > > Add __free() based cleanup function for platform_device_put(). > > > > > > > > Signed-off-by: Jonathan Cameron > > > > Signed-off-by: Shiju Jose > > > > --- > > > > include/linux/platform_device.h | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h > > > > index d422db6eec63..606533b88f44 100644 > > > > --- a/include/linux/platform_device.h > > > > +++ b/include/linux/platform_device.h > > > > @@ -232,6 +232,7 @@ extern int platform_device_add_data(struct platform_device *pdev, > > > > extern int platform_device_add(struct platform_device *pdev); > > > > extern void platform_device_del(struct platform_device *pdev); > > > > extern void platform_device_put(struct platform_device *pdev); > > > > +DEFINE_FREE(platform_device_put, struct platform_device *, if (_T) platform_device_put(_T)) > > > > > > > > struct platform_driver { > > > > int (*probe)(struct platform_device *); > > > > > > +CC Greg KH and Rafael. > > > > > > Makes sure to include them on v14 as this needs review from a driver core point > > > of view I think. > > > > Why is this needed for a platform device? This feels like you will have > > to do more work to "keep" the reference on the normal path than you to > > today to release the reference on the error path, right? Have a pointer > > to a patch that uses this? > > Ah, is it this one: > https://lore.kernel.org/all/20241014164955.00003439@Huawei.com/ > ? > > If so, no, that's an abuse of a platform device, don't do that, make a > REAL device on the bus that this device lives on. If it doesn't live on > a real bus, then put it on the virtual bus but do NOT abuse the platform > device layer for something like this. Ok. Probably virtual bus it is then. Rafael, what do you think makes sense for a 'feature' that is described only by an ACPI table (here RAS2)? Kind of similar(ish) to say IORT. My thinking on a platform device was that this could be described in DSDT and would have ended up as one. No idea why it isn't. Maybe it predated the resource stuff that lets you use PCC channels from methods under devices. Anyhow, it's not something I care about so virtual bus is fine by me. Jonathan > > thanks, > > greg k-h >