From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 043EAD18157 for ; Mon, 14 Oct 2024 23:27:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FF696B0082; Mon, 14 Oct 2024 19:27:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AF666B0083; Mon, 14 Oct 2024 19:27:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69DA26B0089; Mon, 14 Oct 2024 19:27:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4BA9C6B0082 for ; Mon, 14 Oct 2024 19:27:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D7A31412EC for ; Mon, 14 Oct 2024 23:27:25 +0000 (UTC) X-FDA: 82673796534.01.94FBFC3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 4737E1C0008 for ; Mon, 14 Oct 2024 23:27:24 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BL7Bc05R; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728948379; a=rsa-sha256; cv=none; b=slkTJVBF7WwP8U5BX1NI78uguY0qGCh7Rqq7y2X0lFV7djSBAM4vBlijxz+iKTfd6escwr RdcWUzW8mceC+1iq0AHXRjb5XT/WHtQqvirGJKYP/Qedr1VOsWORh9EiQfDn31D2K0zING nFufk7Btd6fuZsVqfA10HY0YzRjdS+Q= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BL7Bc05R; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728948379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Co9+11thExtX1v3rEe1pYx7n14anNqWaNqp1Glir4eA=; b=AZGOyDw/SdOKlNhTGm8Jp53FCxT3mqEmqJPR8JK2byZzvJ2+yrfOwMGQFnOcqUK47Wf6vH s7XhhcDy1tqrme9oOmgVdMGUMRwqhY/9J3qPmbzQlbZgJJjOtYurUszGEEYWiojshKjuqv BmtvXnXOfrI4WOlYq8ufg2FMIgC4dDg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BA2295C5A37; Mon, 14 Oct 2024 23:27:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CB6CC4CEC3; Mon, 14 Oct 2024 23:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1728948450; bh=1VtNGbXZaQAM0U0mRZHS9DjszaFz7prhsJk/aVTmoUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BL7Bc05RKO7vSIUnM2QkJnnXtUpHz4PbmyuPl/jMYK+h2msR/Ad8DRMZuBuf1NfBb flSYcvKdSl7JLdpuQO37IF5xPR2JchP0UmYHCgk3r14P5y/CILJOIk4CuSK+fA5fgG GJyg5A3ARfbqGFWR0YQt6NGiG8h5NA3A5Cxx1klc= Date: Mon, 14 Oct 2024 16:27:30 -0700 From: Andrew Morton To: Wei Xu Cc: Yu Zhao , Brian Geffon , Jan Alexander Steffens , Suleiman Souhlal , Axel Rasmussen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/mglru: reset page lru tier bits when activating Message-Id: <20241014162730.fc48f2a53b89639a6207ba9d@linux-foundation.org> In-Reply-To: <20241014221231.832959-1-weixugc@google.com> References: <20241014221231.832959-1-weixugc@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: jac4cfjg69zu49sfoino7peq89n43y7w X-Rspamd-Queue-Id: 4737E1C0008 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728948444-855637 X-HE-Meta: U2FsdGVkX199t92Bx0eFo31oiBnSTsTPzdvRpo///O8cPX71/3aFHHY70fjFvA2mqumrUY3QRZ0DEapaWhu5ZiStV2mjEUIXUTenw90VgTX3n6NWQ0n/euf/o8IIfsrqc3ZN6f5Kdc+kq8p803UtpMum0LqDoQ82iB6Fh0v1G0cuc5IKYop8sTKsNPYbH8RdNY5FMdkePxgEtdqcbd4f5MxLT3itytrqPWsEsvB7YLqNOyBUjuLHGpf09bMRH43P4ZgO4TRT+D9u0XHDStQxI6wLkdoj++Y7cBwnx2SW8kqJHbNt0dED4Xz0ZIyY898DXtd6KZT2J3HOmu71KYbejOX3SR3evA/V95p0rw8nJZzAPGwkvGY45yzlttyFlSZ0AgrmOPDUZcHZriomaKYlQk6jZtci2+ieWA2hiLoJbBK2T5ZkJDOlN6JUx/E6FcDIwC/R64H7fMsHVGVxrTrZ+4lqHlP40utP6I37rKyiQthHdy8B0TqtEUTbu4sud5RgUSmShk0e0ns5Tnwj7/fk5Xceag4ouXzhKRXo4EjnyEDoPeSeYl3TFL3k1Fczf4MTkRGGFvmGQaV+v0yaqKolN8I5ql3E/GMuEuliICroFXIV81GtczTJ1ElS9l0shduuOFWffVU/POpOs4KAInuc9cszxFfdqgOlObER3LMZxfh7kFvFEnZFE1p6WR0bxOlNK1Q73vrp7NlKFvu7Va/IQZE+Sm+Fsqlg0HuZYNSwIMHnpCs0pV0kwkW8FI5OUPj0jWveRXb/4WoCIvLchpetcrDmggA4vwkvQIYfR+Ph1YIC2PPqbWQHhP9m0VL8NTM+Iz10Ikshb2rAVw6fYK+K4S3mrEjLmByuHUIfbsV4HVExMvtQ+44klJZruqNgqbSRSeBBE0j90NiyQiLEkKvKOC3oTcrIHAkxq0IqFoxlqcgnZ42KOe6LdFZUxiA1Pya1YOdx2MxgXkDaO44sHiA iBHRf8Mr 0EutviSYBJCx6lOvRJWpBgsGrGlAe/V25vBGRDEnDoczoiYypxc/OA2vp7X2sc5sdRxG9wETyYz6Qdz+VZPwH8g+kd5ZI1bi3kot4bAC63E2g5juJM4qU18Ur6RTUbMSVDjihu9V+KyUpsGblGpqPLPKxqf5ddlKbj4/bJt++/s3RSNJ8N5+pSR6Ge3d7RHAK7k/FNcxsFxJXwTJ0m39p9bdsycNLR+peoHZdZdtd5bt5OX6QqIgdGd2aMVMTfgoP3M/uOB7j1ZgoGqir7/H9xFpoIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 14 Oct 2024 22:12:31 +0000 Wei Xu wrote: > folio_activate() calls lru_gen_add_folio() to move the folio to the > youngest generation. But unlike folio_update_gen()/folio_inc_gen(), > lru_gen_add_folio() doesn't reset the folio lru tier bits > (LRU_REFS_MASK | LRU_REFS_FLAGS). Fix this inconsistency in > lru_gen_add_folio() when activating a folio. What are the runtime effects of this flaw?