From: Andrew Morton <akpm@linux-foundation.org>
To: Wei Xu <weixugc@google.com>
Cc: Yu Zhao <yuzhao@google.com>,
Axel Rasmussen <axelrasmussen@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/mglru: only clear kswapd_failures if reclaimable
Date: Mon, 14 Oct 2024 16:25:41 -0700 [thread overview]
Message-ID: <20241014162541.a3049d0824a2f9b22221c17a@linux-foundation.org> (raw)
In-Reply-To: <20241014221211.832591-1-weixugc@google.com>
On Mon, 14 Oct 2024 22:12:11 +0000 Wei Xu <weixugc@google.com> wrote:
> lru_gen_shrink_node() unconditionally clears kswapd_failures, which
> can prevent kswapd from sleeping and cause 100% kswapd cpu usage even
> when kswapd repeatedly fails to make progress in reclaim.
>
> Only clear kswap_failures in lru_gen_shrink_node() if reclaim makes
> some progress, similar to shrink_node().
That sounds bad. What triggers this? Can you suggest why it has just
bee discovered, after 1.5 years? And should the fix be backported into
-stable kernels?
next prev parent reply other threads:[~2024-10-14 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 22:12 Wei Xu
2024-10-14 23:25 ` Andrew Morton [this message]
2024-10-14 23:41 ` Wei Xu
2024-10-16 4:56 ` Yu Zhao
2024-10-16 5:29 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014162541.a3049d0824a2f9b22221c17a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=weixugc@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox