From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE3DD16251 for ; Mon, 14 Oct 2024 12:15:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9609C6B0082; Mon, 14 Oct 2024 08:15:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9112D6B0083; Mon, 14 Oct 2024 08:15:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B16E6B0089; Mon, 14 Oct 2024 08:15:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5A0EE6B0082 for ; Mon, 14 Oct 2024 08:15:54 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C80D4ABDE1 for ; Mon, 14 Oct 2024 12:15:38 +0000 (UTC) X-FDA: 82672104018.06.E1F37A8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf04.hostedemail.com (Postfix) with ESMTP id 9D43740005 for ; Mon, 14 Oct 2024 12:15:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uvsaXnRt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hvFDJ9eT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uvsaXnRt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hvFDJ9eT; dmarc=none; spf=pass (imf04.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728907995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6L9TArDqU/9AyY6LyABBa12emgFStrRqvC34y1X/bLg=; b=rqDlPJAm+vmZxH0xVWgJJ3gYCuwVulSj3Be2phlOxwKZhzp+tiiQJMB+Hp0HCv+taMxio9 DUiaafugOeYcHjJK51NPg2U41TOs4ZtOvLkTF9pdLjZlBKC2NRqgwRYDVN1eaTzO6q2w91 r6fBBwRXqItvtbsHDaYwWCbJsqt8vl0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728907995; a=rsa-sha256; cv=none; b=HdEfPl+xtYipbyVs2Y0auo0KDr/JesNn5JBfxix2Xka8tLHxBj60v0UIiw6qQJd1zvb4GT ZPHM+RzD5vdpaJ7DSTawYYrYPhP3bP+eOkrKuPPio6MRvMUrl0orYNPK025tYSqGrvhI2k psH0T8uoRIc81OJYc9brMnmu0eyNK2A= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uvsaXnRt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hvFDJ9eT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uvsaXnRt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hvFDJ9eT; dmarc=none; spf=pass (imf04.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 447BD21DA1; Mon, 14 Oct 2024 12:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728908150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6L9TArDqU/9AyY6LyABBa12emgFStrRqvC34y1X/bLg=; b=uvsaXnRtmvBy5j9IlTnxcI+HUt6yoCF8TGK2pJufwUH7wQO8F5HdsfV32pU0iQtWpwONh6 HZHc91sSYVVjVArI3tsA8wrBHX3ryPRteLMeuh4Tts3GgE1K+BXbGM9tDCHOHg7Xg0yCNk dSSzNgSiNfMntIGi3OeLALa/2jWAAio= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728908150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6L9TArDqU/9AyY6LyABBa12emgFStrRqvC34y1X/bLg=; b=hvFDJ9eT2lywgt5kxuJQn4/mpkgtOZicv0yV3DEbky4wq9eppRT3cxFXECJ7G9zeNGxOuL 4USkNmr0JZ/IdlCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728908150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6L9TArDqU/9AyY6LyABBa12emgFStrRqvC34y1X/bLg=; b=uvsaXnRtmvBy5j9IlTnxcI+HUt6yoCF8TGK2pJufwUH7wQO8F5HdsfV32pU0iQtWpwONh6 HZHc91sSYVVjVArI3tsA8wrBHX3ryPRteLMeuh4Tts3GgE1K+BXbGM9tDCHOHg7Xg0yCNk dSSzNgSiNfMntIGi3OeLALa/2jWAAio= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728908150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6L9TArDqU/9AyY6LyABBa12emgFStrRqvC34y1X/bLg=; b=hvFDJ9eT2lywgt5kxuJQn4/mpkgtOZicv0yV3DEbky4wq9eppRT3cxFXECJ7G9zeNGxOuL 4USkNmr0JZ/IdlCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3295B13A79; Mon, 14 Oct 2024 12:15:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id e19YDHYLDWdCPgAAD6G6ig (envelope-from ); Mon, 14 Oct 2024 12:15:50 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id C9447A0896; Mon, 14 Oct 2024 14:15:45 +0200 (CEST) Date: Mon, 14 Oct 2024 14:15:45 +0200 From: Jan Kara To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH v3 -next 10/15] fs: drop_caches: move sysctl to fs/drop_caches.c Message-ID: <20241014121545.bdgwsw66i2yborjo@quack3> References: <20241010152215.3025842-1-yukaixiong@huawei.com> <20241010152215.3025842-11-yukaixiong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241010152215.3025842-11-yukaixiong@huawei.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9D43740005 X-Stat-Signature: 6fy89eqt6a1t4y35nijcnqccpxbqu9uh X-Rspam-User: X-HE-Tag: 1728908143-775691 X-HE-Meta: U2FsdGVkX1+Of+HoEQO9nz5qy8L/wKUpY0SLPNXzJ1FCZAmnCYpzFx0atE77yqqfCubGe/KAeKkKiIiWaZfaf3e3d+RxnFrQ8cwF5NVsBWyWRe/48VQ8FV01Q8C9uQTOU8dkm99uWe/1aT9e89QyCx239CiyJFy+JqJIWH+x/6+vzZhf4TcZAOecLLjCIjA+aeisJHCZi1nsfa78QJOSMn7dthNLM+TVAjry+2hFqbXQTqXn9AFbAD7rGOPM8LgzX4jFXRMdTInMR3NY9nDQVPlMa9nZAiSFWf1HVVTjFDJkNrUHbk0rMnTI82F6ynQ7vujSf/qhPzs+dN+WwPvPmTAT/DIUPKAczWI72rDCRhF71hz8jB5kpcNXj4dYRGvmR5o2jF/QeWf/on6FbKN7d5myVZX1V8MTbCCL+LpRh7v7heDOL8u4Qk+mb+FDCXC4M6TB/5VjNajx16AL01LJBGnToxUE+M/XkhnrKgGnhw2G2LjSEWCXIgQvG28Rnw4xorJTznDmLMA5bapza296yuCZhNUCcjNLoOPT1Z9XQvP0cFyb/MgmEpFCKMbQmLlfaz2oPLElR6Q8nXG9gS7Yk1nkKdbU9XtdbDDMAJIvbKh4XUpAOpFiXLVU/lNUFMcSWmVQmcc35E7CeQ9i9i4uyINUSLI0MZty0nh82AgbyaJbg5Zk+RCHIFXU8IoYE/MiyrPg6yK7Ayfy7nlnLUm/BLsvPH5dsYzamXwxLhA1CAvjAYmt8rtS/Ter9DYG2GTMXl5fwdP3Nk202DjzqKRT3q03xG+icduMD7sRyDKPt5fk80EQrWEo43mZNRZtY2DYslWMBuab+07PPJU3PLYgqYhpe8IL0DnDM6Bc+0QPNHYC6+5bMluIkjWR+O1szPaar0ZIV8k5ooxUoperYpsyWN1/a8TfUz9xVyw6fwwkYpO9Vv4Gk9Lgd+RJNf2jMMlmtQEkE0mrNy7AhCvDBQD Kivo5mFA sC4H/guu0WA2veAmlqr9r5WHjSbYXP4klMzye4JHF9IEIKalT1LIJOcdOazL0hvRV20rbMeS+UV1jJZfoyD/MeF9UAro4AcPhwrAJG7w5Stkm1IgV2NKeVgF9p1PpnHwcdXojdiSxAJpWBx8PPnE+CFKfysEi2xgN8Btz/+qnBoJ4wYG5tStX6MfqoWLmmUbwG81L6DokKwp8fP4bk+sTDF7EjSz/fRlG+25ZmVjTNkWKFKVV+fyvUwOxKdq6dcu3V4zFzcs9jCjYB+NvsL8u+wUH0trMXailCMqyTFlNVeFiHzhuzAPmOMKSDOZ6eEj9LYaFFNpsr7AUvd41f6+ymJVHEcwo7pzcyjSkOpCSVcQr+qS0/MEd1SYS69yh330fjbE3+R9jtaRaiCIGkwT2tWP4rWx57/T0ZOKOuZ/wMxP4Nqa9ymqSkoBJBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 10-10-24 23:22:10, Kaixiong Yu wrote: > The sysctl_drop_caches to fs/drop_caches.c, move it to > fs/drop_caches.c from /kernel/sysctl.c. And remove the > useless extern variable declaration from include/linux/mm.h > > Signed-off-by: Kaixiong Yu > Reviewed-by: Kees Cook Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > v3: > - change the title > --- > fs/drop_caches.c | 23 +++++++++++++++++++++-- > include/linux/mm.h | 6 ------ > kernel/sysctl.c | 9 --------- > 3 files changed, 21 insertions(+), 17 deletions(-) > > diff --git a/fs/drop_caches.c b/fs/drop_caches.c > index d45ef541d848..f2551ace800f 100644 > --- a/fs/drop_caches.c > +++ b/fs/drop_caches.c > @@ -14,7 +14,7 @@ > #include "internal.h" > > /* A global variable is a bit ugly, but it keeps the code simple */ > -int sysctl_drop_caches; > +static int sysctl_drop_caches; > > static void drop_pagecache_sb(struct super_block *sb, void *unused) > { > @@ -48,7 +48,7 @@ static void drop_pagecache_sb(struct super_block *sb, void *unused) > iput(toput_inode); > } > > -int drop_caches_sysctl_handler(const struct ctl_table *table, int write, > +static int drop_caches_sysctl_handler(const struct ctl_table *table, int write, > void *buffer, size_t *length, loff_t *ppos) > { > int ret; > @@ -77,3 +77,22 @@ int drop_caches_sysctl_handler(const struct ctl_table *table, int write, > } > return 0; > } > + > +static struct ctl_table drop_caches_table[] = { > + { > + .procname = "drop_caches", > + .data = &sysctl_drop_caches, > + .maxlen = sizeof(int), > + .mode = 0200, > + .proc_handler = drop_caches_sysctl_handler, > + .extra1 = SYSCTL_ONE, > + .extra2 = SYSCTL_FOUR, > + }, > +}; > + > +static int __init init_vm_drop_caches_sysctls(void) > +{ > + register_sysctl_init("vm", drop_caches_table); > + return 0; > +} > +fs_initcall(init_vm_drop_caches_sysctls); > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c7f73bf32024..ed2e7425c838 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3791,12 +3791,6 @@ static inline int in_gate_area(struct mm_struct *mm, unsigned long addr) > > extern bool process_shares_mm(struct task_struct *p, struct mm_struct *mm); > > -#ifdef CONFIG_SYSCTL > -extern int sysctl_drop_caches; > -int drop_caches_sysctl_handler(const struct ctl_table *, int, void *, size_t *, > - loff_t *); > -#endif > - > void drop_slab(void); > > #ifndef CONFIG_MMU > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 373e018b950c..d638a1bac9af 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -2024,15 +2024,6 @@ static struct ctl_table kern_table[] = { > }; > > static struct ctl_table vm_table[] = { > - { > - .procname = "drop_caches", > - .data = &sysctl_drop_caches, > - .maxlen = sizeof(int), > - .mode = 0200, > - .proc_handler = drop_caches_sysctl_handler, > - .extra1 = SYSCTL_ONE, > - .extra2 = SYSCTL_FOUR, > - }, > { > .procname = "vfs_cache_pressure", > .data = &sysctl_vfs_cache_pressure, > -- > 2.34.1 > -- Jan Kara SUSE Labs, CR