From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC19ED1812A for ; Mon, 14 Oct 2024 16:12:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F2876B0085; Mon, 14 Oct 2024 12:12:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A24D6B0088; Mon, 14 Oct 2024 12:12:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 143226B0089; Mon, 14 Oct 2024 12:12:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E955E6B0085 for ; Mon, 14 Oct 2024 12:12:36 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6F7D7120C58 for ; Mon, 14 Oct 2024 16:12:29 +0000 (UTC) X-FDA: 82672700460.13.8C172D9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 89FA61C0002 for ; Mon, 14 Oct 2024 16:12:22 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=On9u0jL1; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728922308; a=rsa-sha256; cv=none; b=r+XdoEddUiCtktOEATNS0Tfwh+yeNgbrG78yW9tC9yBGH/GlJPKbMfsN6zxVhEtfI7jMcI uxetSNjSTeKXIhuM3iTv7v9tgsFuuBTWVL+03ssFt0KfPp5htf+ovYCpZR6ecyoARuku4e OClF7+F83l4xiMyPN7psH9SpQIw+Dqw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=On9u0jL1; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728922308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QQ/0J8F2MODnLJgx9ToGs2BLPwMCMMp6eU61/gK67K8=; b=xSRSUA9x4H0q9H1y1wCigqUcWvQjEOvkzB6oJvfuNhhiyxZifVwLXe0qxsh8JQYh31oepT ZyYRM/VKvM/D68LWhBey2n7vbqWlViy7+iTcr7CJzXvCFxhg+F21UqxisR6LchNJ/5HWTV iAuOnEhTMWb+xaMPZ+ohpshgsKuWAxk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2A90F5C5B0B; Mon, 14 Oct 2024 16:12:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65C26C4CEC3; Mon, 14 Oct 2024 16:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728922353; bh=Y3hE47/OK0BbVre1jFls3lsPiQKWx6O6pmGYIV+KlSU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=On9u0jL1Dfv0hs+NKB8/Ct7P2koqbBYUEuOz4NZVBfS2st6MOFLVyLqQrOGtC1q9R EcwUfp8FvPednLGua1jBua734B5mM1ZbRlh70dkzI8wsmYmj/nyYjmWphrgyj1NeHb nXaGB1+7BSzxuJuJV7TWZIq8wwPXr4h8DevEZOHg= Date: Mon, 14 Oct 2024 18:00:51 +0200 From: Greg KH To: Jonathan Cameron Cc: shiju.jose@huawei.com, linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v13 12/18] platform: Add __free() based cleanup function for platform_device_put Message-ID: <2024101410-turf-junior-7739@gregkh> References: <20241009124120.1124-1-shiju.jose@huawei.com> <20241009124120.1124-13-shiju.jose@huawei.com> <20241014164339.00003e73@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014164339.00003e73@Huawei.com> X-Rspam-User: X-Rspamd-Queue-Id: 89FA61C0002 X-Rspamd-Server: rspam01 X-Stat-Signature: o14z1jsaj11foz6kbekxrnbkrp43chmb X-HE-Tag: 1728922342-235268 X-HE-Meta: U2FsdGVkX1/tDJwib/qxOogLF80UTn9Sq4JePAkc/xgnka4mPRyDVyrUgnsOWv8BPz0ATI6eSsXyefi58ryCQodViVW3vwLfpnJoz1kPF+Pkjk86AkdtdqfqoXaIT9MlU7UXHy6hKY4vSdhIerxDL28OO6zvNRnr6/jAswYw4J1tocmZQM1824Ic10y+5ckvf0gpYBh83/Jqo6AkDSeAAObrUhOMaidWZ7oYzGOPotf6Q0OH68+A3F2Q4zPyHoC0qn6qtFVRF2pYs+MZp4uVC5H8kPFBaoYMhoLJC33q88ZoZVjZl9sUJ5moP1TEnfCq9wOsLp0kVr/uoO+m9ZxCLs9/qTGlXfGtuy+CCz8xHFYfwS1i/WmqoaBbORPCx99fEYz5MOWBol8aGCAmjQ086ZJAUe8trZmo0RmZl+l3mZFXcvF2JSUM5xegdzBlYG3+URd8FY0NFqwXMektSA7Yc206mvlYAOc2l5MIsG1yCmjWBQqUaMlOIeK43WamEoSniQC4UOqnMrrAhbum9FNNeBoWHb1FCQcNXZSpy9YEP6acmto23GpoJRRqAvrO+6Pm4scxiCDE7BejTOyVlKWQDsR9TVot9HFYE98WSmLk9B0qagCnh3+IQmCBhgEnJN5EdmysHcdQzkoTAzwWrDLI7HXFtEA7YAQm2IyTGciWFU7IECOoEuPgqChxmVHy7kXK+8CLvQRuAjlKZ4MojbdWXVRPUBqZTaORjfYH+j+z3r+CkbVFSDPna6Zh+i7l0G0pS6Dx2grePJAzFBDC8lGcX4VsemjePk1CmEcEk+a0tbOK0Qgyd10QiMObqkKGWB9t7ixuw6qF3OVZk+T5U3XG5etQCBqQ33BF1v5QGKLnHQ4TxwVcV4zNWMH/+0FLrFlfIieIAapZ49i0F1pOStdSTyrSGcGMyLDGxXq3Z6UdhwST0M/fyDeOzcHL3oKbvVdw9rfez4r6WvFCqIM/fL5 9yzXzJu+ wLXqPpuNIkNAY8yzFN2rk5v2n5QFV2KMG7v/HT/RlZujMINIfRblZoT3KdtbouioU8rp9q1up7JCDdneYkWBXFC6tH8/jJ7yb52peOcakklUgV3cnlVyF9HV9MDgCVIlVs3ipHx2V7FrNmhuiEHhGOi554eRwzwib9Duw1lt2WrIt8BTriM6Thz5VGeSB5J1DpTtGy370r9xpteTUWxXvZMr+4y/EwexPtd3ZGjIlE8L2137qujcP8S3v9JvS4RGw5MV4uPPS+BkMIXuv1LbeaFfZdprMgpfLscMj+MHCpTN9rz2aU+63HT+JaSSLKw/TbuZsKHbrEmEwrmfqkbVe2hV404LxARFAlMNz2tJCJuB4S0bzapo2EXTwgihTc5NWljsAhkRsYQmCkLA6xCNjxr4PJ2SpJltGw8ZGggNtmyb6ZDuQLToAQhKI1njrHEFB8sfjnFQIvfPcQiSmplvo28ytjpFXGncgAirCWayzqze5KQVQVpXq2doRew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 04:43:39PM +0100, Jonathan Cameron wrote: > On Wed, 9 Oct 2024 13:41:13 +0100 > wrote: > > > From: Jonathan Cameron > > > > Add __free() based cleanup function for platform_device_put(). > > > > Signed-off-by: Jonathan Cameron > > Signed-off-by: Shiju Jose > > --- > > include/linux/platform_device.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h > > index d422db6eec63..606533b88f44 100644 > > --- a/include/linux/platform_device.h > > +++ b/include/linux/platform_device.h > > @@ -232,6 +232,7 @@ extern int platform_device_add_data(struct platform_device *pdev, > > extern int platform_device_add(struct platform_device *pdev); > > extern void platform_device_del(struct platform_device *pdev); > > extern void platform_device_put(struct platform_device *pdev); > > +DEFINE_FREE(platform_device_put, struct platform_device *, if (_T) platform_device_put(_T)) > > > > struct platform_driver { > > int (*probe)(struct platform_device *); > > +CC Greg KH and Rafael. > > Makes sure to include them on v14 as this needs review from a driver core point > of view I think. Why is this needed for a platform device? This feels like you will have to do more work to "keep" the reference on the normal path than you to today to release the reference on the error path, right? Have a pointer to a patch that uses this? thanks, greg k-h