From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48756CF2579 for ; Sun, 13 Oct 2024 14:42:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 524506B0082; Sun, 13 Oct 2024 10:42:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D38E6B0083; Sun, 13 Oct 2024 10:42:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39AFD6B0085; Sun, 13 Oct 2024 10:42:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1DC276B0082 for ; Sun, 13 Oct 2024 10:42:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AD342808C1 for ; Sun, 13 Oct 2024 14:42:00 +0000 (UTC) X-FDA: 82668843726.22.24599C0 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf20.hostedemail.com (Postfix) with ESMTP id A90E21C0012 for ; Sun, 13 Oct 2024 14:41:58 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cZRqL7wC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728830420; a=rsa-sha256; cv=none; b=rt8TRiNBOL3g90Gyk5MpntUiegugEv3X0aJB4jjOOnqVES1ajKeZRacqVvTK1cyDVSt8kO 2htOz15w6shBITDZb6Li8A6JenQABMOlnvEfqzZiPYl+0h+RYaspfXp3Mz8HzbIFAif6fC cr59EukhEb+0Jx7U3XjS7hYMXkX8ayk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cZRqL7wC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728830420; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UFuxx02E2+F68hraHhaiQWgMPYGuyvZkkdJbahW0NKU=; b=U23AdxV9fi9A/WyysCLEov37nwd1VRr7Rgo9IZEF5CvrIE5qgkiU5I27jwoWEMkeiLRTi9 8SaOzWe0rTNFBhFiVkoeAW6Ty1BnSM5W1wQnyo91zUcc1vNuTsquhgaGSQMDYZS+gVKq2z 8VFKC788dWlq78UQtn3ATBKELwk6AlM= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5c903f5bd0eso5174433a12.3 for ; Sun, 13 Oct 2024 07:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728830523; x=1729435323; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=UFuxx02E2+F68hraHhaiQWgMPYGuyvZkkdJbahW0NKU=; b=cZRqL7wCMMcIQKKc3Mc3+bY7RBNgQz7Izy/Is+BCP7fWT/8t5D9FAdTe2ovomihM17 wtt3k/sh5//nqJfV7oI5mOxK/jK8BTCzXZzHoo2cq3xlXrA3urCAqfPt1gbxotcc5GgL +w5DEqhGleQkPnMVAOP0XO2pKvqpMeLR/9tvFcAKxfVoc/ByilgUpqGLnwbDQ7BWSTtU IeiI3GidrNkFdkC+V0JVTn3JYcbyg2oltl+XoYIwuGcEO6M5xfurgVY0aK8OcfCgNiMQ k1V20MnUPq7J9EPdgwXx/hMjzf6Zgf+PZHgfiJllfKeI23qpUsT8LaWWJwX4sThtcOCV wIlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728830523; x=1729435323; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UFuxx02E2+F68hraHhaiQWgMPYGuyvZkkdJbahW0NKU=; b=TQbzf4VOhBaAFrDnAPhTR1b59Yub4G5bAURN1lMXSPMF1bNzCVPEJy9fZS3QAL+w3B VjAOBXEwX7vNEtKcGgbOqIrfWd5HqpuFNPvJ3vrvG5FN2+SVJhTxIg1jfeeJKMbvXpza 856PohILSjV5JeAg/AKqjsmjcTl+DOOGMG0emVCr/NbEwB/fw7an/pUqiSmWSddhWJ/z m0Mi6cReFAaZDJzFbrZYN72q0v95wGkdXsXgSWXtocCyka3HpDup4K3SORzLhsrJbSat ySzsO5VFmTfSVthw1HNXywF9DwdmfUKZnLhonk7hfTwkMw9q4oTj4gd4Y69CkU7WR+Gy XVGQ== X-Forwarded-Encrypted: i=1; AJvYcCXLdrJSjCzYxP5cno1lx1Eo798NrPk3cJPTTIVEWAsi+lQdT3I20uweOSeloBrTL9gDe7cwFElghg==@kvack.org X-Gm-Message-State: AOJu0Yz8f8RRDI28SGJvnNdVGyBHD0mw4N0mP4Sjd2Hz8KL5zFN6VOje 3lIF3ePau2ZGZMx1Bs4WVQcICz1ZxY1ClIZs2QGKRkDu9DT+Lqr6 X-Google-Smtp-Source: AGHT+IHkwPefuguoLTSivCn4tfY5UbGm1MuxuZh/DQz1glpxkY+PLbLADFL+eNzLyY0cpX5jv2VXhQ== X-Received: by 2002:a05:6402:5252:b0:5c9:6bd9:68d9 with SMTP id 4fb4d7f45d1cf-5c96bd96bdemr2572505a12.32.1728830522644; Sun, 13 Oct 2024 07:42:02 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c937260aefsm3794701a12.65.2024.10.13.07.41.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 Oct 2024 07:42:00 -0700 (PDT) Date: Sun, 13 Oct 2024 14:41:59 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] maple_tree: root node could be handled by !p_slot too Message-ID: <20241013144159.327jcs2inubxtdme@master> Reply-To: Wei Yang References: <20240913063128.27391-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: A90E21C0012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: f4iyku5dihh9qc1bi4yx416k1iik1dtg X-HE-Tag: 1728830518-705697 X-HE-Meta: U2FsdGVkX1/W59IFExdF8G0+oild4FQUcdeQ6jeOzomcj8cx5BGpoI0eQB/AIu5k/ewZNACTsABJf5TcGve3xQ7Dmiwh1kvGQL0W5eyQfwiVU0w/aUGgAVhUtFVgy5XHQeaAEd7umQ955FiET7LZU5zwPaVdbPH6vXwfMcxoi50MyVmXpk9x6xXOeiO3GdLXvGym+7FpK5cZGMPWY6BeRuNBZASJ8yrR2Ob1HtQGdTUAZhMnqJ0c9kdp3YxORc5PIC3gsGWvzt9juFs4rW1My/fg8vGI4d2ziO2JE+G+Ot+bw9t3ypb8UZgzkmQUDMHkpwm4UbkLmGE+blfc/NbmgVlZT1ytIlVSAFoAUPwE8BnoJgwImSL18hOmpXuwnGIoeucmmWMPK7xLf1eZSfGml9nOkAA/MpFtXu1QQKgEj2nfvc7vwx3pad8EVjSJoc00kfMN+NMkYLsxKge3I1JuSEijh8kPs90XX2For1/7Uj6zk4s2mU0rkAQDqLpPI4vdhkpmuPbTk9JYfAsaKw2X1aUz9Msgh5ZXDASJVdXt0bDFGiOmxgDWGPGQ6dsBhGF7lFRP1KLZ7e41FkoSMup2aA7T69cnz9dSLcVbdeKOpV/LlWm2uu2U3K/OXYY9cNFSWYqjAz0IquoeTrwyVnQNl3rhCYZuSxwGyQWGTlT7V/08UEMZ7Y1d3WrzKSGqV0OtZL+UXA7HHK4WnCx8tnI8WdSNzHeUUGCWBElrf9m6rS23O93NnQAsz0D2WumiruAlIEsqKVc5S/Qzaiqpq7wgyYuRYeFbkbdjzIFnzIWSTr/J2ND0Va3KYLfzq6xuOlMD/gLjTYXaNFYOfz8Qat/1orMQ+3uYBi+ou+auaIhWr8s01OgJA8xrTbCQbK0I6YCJlGOLPpRk09syctn2HBHB83G7CWCRnOKpZ5ihUBwSkyRT2ZziqmAbXf3N0B3A7TwXFHDMpb1ftoloqnuEX9c Tu2Js0bo kBQe1Aifj8uGH/5stXEod1sjVya8V2g+noJfxg+JBYK/tJ9sBpKd4jneSX+BhlY1pbLBtq0ZQ01+nUmpoha+5ZlFr4F17KYpDZdtDJHozgAiGWcENOgRkSI8dLqR14AfvkXnFyDILAusgN4NFTJfH9vvPHdYpiVQElb1cR/5hETl5VAvMu3+pZq/hfrTU1EeXisK8y2QMRXlVMJ7nNz3NkI7TPObOCc1hmN5TC8JYS4sJidGuQIdITj01Nkk0wyEIqFXKEOS9qKsSX481pQEP+tTcJi9BYlU25YxG2Zq+FSWbMEqkVOFmZVEorLT8n/syTIxZGNvhJEHdqsgVIfLET3P6UKbWsbFZk8V5FELs6P9J3J0hSpwbBxVStGdS9/5KN3zmbdhRXbax7eERVLLn4dirDO1H/9IizYABlcV5ABziOKag0slM+CFDXJTLCtpRxXSy+iiFDAhZ8DYT8YenQBw8xTqtUWH9ppKFj9A8Ihe16XgITfMuiCu0UOeWaZ6B8nu6OUeaY2ufz0zFMAudeJQO11JfPRLSRDSXxO1+aHz3dY0NtVsOPYA+Wv0KEJ9jAccEPYMYF8v3MK/QySGNXLv59u4WDwBwyHaRsDWFrk66dOlIMoGnVBk6xMRpBW7MWVcxsuWC1ENpmcSu3tOczkNLKK8oOriAnKJteBqH2RBo9l/OJ024eRf+5AAWCtNJzKTji/0j8iuoTX4goLgl8QIvUlZQW8H9sex9gFQdFmq0KsHzaNbm8lXxfQHe7loUx/0v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 13, 2024 at 10:17:07AM -0400, Liam R. Howlett wrote: >* Wei Yang [240913 02:31]: >> For a root node, mte_parent_slot() return 0, this exactly fits the >> following !p_slot check. > >This sounds right, I will have to look deeper at it though. > Hi, Liam I guess you are back? >Thanks, >Liam > >> >> So we can remove the special handling for root node. >> >> Signed-off-by: Wei Yang >> CC: Liam R. Howlett >> --- >> lib/maple_tree.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index 85bd651e7770..b5dde94cc7a9 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -2100,9 +2100,7 @@ static inline bool mas_prev_sibling(struct ma_state *mas) >> { >> unsigned int p_slot = mte_parent_slot(mas->node); >> >> - if (mte_is_root(mas->node)) >> - return false; >> - >> + /* For root node, p_slot is set to 0 by mte_parent_slot(). */ >> if (!p_slot) >> return false; >> >> -- >> 2.34.1 >> -- Wei Yang Help you, Help me