From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB733D1A42F for ; Sat, 12 Oct 2024 03:31:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 652AD6B009F; Fri, 11 Oct 2024 23:31:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DBAE6B00A1; Fri, 11 Oct 2024 23:31:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47C226B00A3; Fri, 11 Oct 2024 23:31:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 230DB6B009F for ; Fri, 11 Oct 2024 23:31:48 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 057101C7753 for ; Sat, 12 Oct 2024 03:31:42 +0000 (UTC) X-FDA: 82663525770.23.A027484 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf06.hostedemail.com (Postfix) with ESMTP id 309AE180015 for ; Sat, 12 Oct 2024 03:31:42 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aGE7oQQo; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728703766; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0QsKGo8Omt2Eyqc1qAXwnr1uQz5CRFvUdDKrZEWtFMM=; b=fumUyuLF6JCIU47FBHPzVpbjIVnbemCAdzkigxgzDifv9DdFL1rWwddKcjK4uTBwwGlpud GqRHsjv7+An8mVLf80cCEJiHZ9oRmLFwT2RxObngWTSyF+frz3g3gBgr/mkubBYV6IgwpS QKc2DxQXUxucv1qhmqYJcbXWFZKbogs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728703766; a=rsa-sha256; cv=none; b=X9FAxd3e7OtDrkZ+Ai1a/aSxMknJWYdaShlKBMv8NPkQzNN4FhDlX7sGbhgAG9DONCEYJy l7tiYs9ffnUBYXxbz8T9rbrkd1Uf4KrLf6z8v9Cu3e1dYxl+6Zu/fgio966YkEdFkZn9m/ Ity+XCQN/xVPOlmsl0M6GntPG6r1gDc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aGE7oQQo; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a99cc265e0aso134104566b.3 for ; Fri, 11 Oct 2024 20:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728703904; x=1729308704; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0QsKGo8Omt2Eyqc1qAXwnr1uQz5CRFvUdDKrZEWtFMM=; b=aGE7oQQoTL7nsJ5VczY5uDxCoaAgP1nBkOO65MOSWNH4EfeDk0OpcRZvu5AfHHWh2M BgU5cZxNbQeaPrVFDFDcDUBNX3sRL5t53cTeEhbm/lmSAkYCWxPWgM3bGgdSvu3AUCfZ +RV0FhEHRUa3RiySyJ7nrOhPWLakzYydJA/os3PhR5y2/GlJxKAz9f6HRoHTVlJ0GCFj q3z+a42eeI5pP7gK9+U6fKgwroDznNSiqXpFTtBg77gMgNkrNbiXIiebE1bH7oZwHzUI QkG/GSlgXcEmr1ntCWum54NNkPESRWJJxPCGrj6MUJaedNxCqyyESavRKK+kOUZtazEK 6keQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728703904; x=1729308704; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0QsKGo8Omt2Eyqc1qAXwnr1uQz5CRFvUdDKrZEWtFMM=; b=GSyxYHOKL3LIcxUrI2Ombfd990MSUHlV8HGiC38CrrtvGM8R21NNUnuuS+9KG572uT 1xflQc8YJoiY14Zr0AOW6LuLt5rWeEV4nnSaGhMQPTG285lL/Q7WnB1wez3RE9PMglSN 0Eskz72V3jn3c99JLTstgd8+jynFuPau2F39j9u4WSKBywYljBkD9V9e58NfLBcIpKRS REo4amYeOUFmor1czw3LHsdNCABaFOcEwk4fDDWpge7ibbn/I5pZX4qrfayTJ4m8aGQb oXpLL3Yw88CxD6mrf/p8BQcUo3/JziLSdtMSwGHvGGbrMEjXS3OGJNnFkObDio7dsiOs I7uQ== X-Forwarded-Encrypted: i=1; AJvYcCWTPBzLTn1GhAikzKngQOuj4ucTXIs1tw+psJQhtz/n/16npmyUXyQ1sx9WLR37Q4Rl/mGnRiLlxw==@kvack.org X-Gm-Message-State: AOJu0Yyi2qFMMfRzuMRUr731f4oiBFF5JWtcAuB8PE5Op4CV1tNl+3oX a51LP1XRYjIiO3j/A80HSkAuH686pWh1xQ+gDrSQxWgXYxell7DB X-Google-Smtp-Source: AGHT+IEeHWLgzP632OSTTZ0brvpI3Wl01mBFPVWdUuAm46KlIG5n44Po3U+vJaIuAG2gMVCQqYSliA== X-Received: by 2002:a17:907:9809:b0:a99:a44b:e622 with SMTP id a640c23a62f3a-a99b937a769mr345597166b.25.1728703903961; Fri, 11 Oct 2024 20:31:43 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99eb86acd1sm32334466b.106.2024.10.11.20.31.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Oct 2024 20:31:42 -0700 (PDT) Date: Sat, 12 Oct 2024 03:31:41 +0000 From: Wei Yang To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, liam.howlett@oracle.com, willy@infradead.org, richard.weiyang@gmail.com Subject: Re: [PATCH 2/2] maple_tree: refactor mas_wr_store_type() Message-ID: <20241012033141.3p2ieftywbkmlw4k@master> Reply-To: Wei Yang References: <20241011214451.7286-1-sidhartha.kumar@oracle.com> <20241011214451.7286-2-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241011214451.7286-2-sidhartha.kumar@oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 309AE180015 X-Stat-Signature: gnkugou6gf9c6peyha6x3jpcffynrm6m X-HE-Tag: 1728703902-295010 X-HE-Meta: U2FsdGVkX1/AUsl26yN1kJ06mnwz2BN6hpAl2ANWQbwNL6vEGLW4fezwSxrsNx4j1OHFDntiuqNkM+T0+Qh2KpNHNElIj7xp9h4UEMom0ccdOKvlhTMOiYMLs83shBbmc4rV/tNzkjxh5mXJDw9XJVjzx6RQgoPtqvkqY2i9b/YF3KQdFAyKTyEVTUSnzxUOfJ+pBwE2hahur/9Nwxq29X/L3hAeOEBzxpqPFtKSvsmVEW+XayMQcUOAInmr1X55G70imNkXxKGlZsIKhOg78FhQDqxR0aRrw6mn4oExSchvssacsyRqfUWFxOqKg8wK0iXCcpg6rwT6P66356uOo6ZhDjJKyOBaeSu92qiejH7IklUqxLAswxf2Z+KCxZGGEldj2gtHCVNvr66s3VIXlwyyTAadjiue/bY+aua11ZVUJhK8rbz8WJvgdngq7Wy+N2ULV6M+B8Cljt/lzp/502hGe5mIIRf8FFJ8iePxieyCNZC5KWm7tX5A98331+f1HRuK39K2vgFa5TkP6vUYwLiyj4mnCnDLl8KeFHiXx8AUFcxhMfnuUdFOaRec0cgSIcbMaX7Gs8MY4KuBP/pEYk7F48gaNksVcV9s38RTADHM4LiC2z2gsTtJ+XZgf3H2JzM/E76z3kZdoSQXvkd9L9nkFfuzBR+surWlcyozQ3055SipzIaTds+mApOv5ioW8pr3qUNJRZ2MTzNjMXpa3v69hB4YCA5mbXwvlcvERKSC18hka7IgkifYcPt4Q9fndc+WumvVrIx5JqN2SOXx05jDZVFcMlEkUP0IgmKJXJzXM6pAoYBTr/BxCulCfbJIncCXU7uxBDAbI/LaUMqDDFB+7JkQgjesjvPIq06oHlXEJF4VqEOhqd2xguv3SwbCAKvmDLAfAb74rFxi+8oEjN4KsjI3FPCjimx9Ni6wWDyxE5bE5INGiS5BY3Q/+PXyp5G4dBmaTwwXRe+vtTq SedsM6f9 5rcl4vnTI9L1VlQAk1IcCt9gQQ0bSUckHROxKNGiL+o+Yn1sH1iIxy+RkB1E48z/pFPF8uHDgAXd1mr4V9BnjXFD3a5f0Jz+oAPWfga1d1XksGZBJTsTv3YtWnKoBivY2GGmMBzYmXonIhISLdN5Ow7XcKNdZbUHbN83rbploAlEBsZ33Th+4T/dGmEPe/1goBmFimoyQ1LUy9lqPldUjN8Pv+dvBL3pZoxAsOG1aaDWpDWUm4QRK93PhMZzXZOuylj/M9Qk5iMH3iJ04HVlPdOmD2iPc0L9rjK6Pk5kdDkIE6fayF6g2PfPN/v1x8oRL1bwyjuTH1nRdwjZ0Z5/Mv7PL3SuXtt1BC9quzbqp+6Ga/hRE6GGbLhQPTjFtLJilXmOYE8zN2auvh2HZ+nuesmd12+DFG6fBDCg4vQNNxzNuwveEFO5wt67DXWzpt0waJ37bo+k7mbboNNcLAMPdT4Nuv093J9fMmhGJBC0ie4rlwO1iau3FEKFeVJwMhyMH7ZRmlGTS5tN+ysd3Arn3XUYxVh5G1nJ7BvntME1V2N5gpenfhdY/HAoK4AXkvc7Xp8g5h0lkBqy+6D4Z6ER2J9Vpc1ZY/tqtJxbscsACpU6AEZgX0ARIy+8LbqPAz6ZomQ4M081X8FDibEgcxLXT5s//6/Om0F3w2weQKG2NduEcj/ODxCLcLzkzFoVHdPyHoLnicaGHvPGYUEX5sq9iXuKpadlP+p3DEn35t2LHzo4GKZc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.099489, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 11, 2024 at 05:44:51PM -0400, Sidhartha Kumar wrote: >In mas_wr_store_type(), we check if new_end < mt_slots[wr_mas->type]. If >this check fails, we know that ,after this, new_end is >= mt_min_slots. >Checking this again when we detect a wr_node_store later in the function >is reduntant. Because this check is part of an OR statement, the statement >will always evaluate to true, therefore we can just get rid of it. > >We also refactor mas_wr_store_type() to return the store type rather >than set it directly as it greatly cleans up the function. > >Suggested-by: Liam Howlett >Suggested-by: Wei Yang >Signed-off-by: Sidhartha Reviewed-by: Wei Yang -- Wei Yang Help you, Help me