From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61FDD1A42F for ; Sat, 12 Oct 2024 03:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A5F06B0098; Fri, 11 Oct 2024 23:31:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42CF16B009A; Fri, 11 Oct 2024 23:31:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A66C6B009F; Fri, 11 Oct 2024 23:31:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 086B66B0098 for ; Fri, 11 Oct 2024 23:31:26 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5BD01ACF46 for ; Sat, 12 Oct 2024 03:31:15 +0000 (UTC) X-FDA: 82663524846.27.CC81658 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf04.hostedemail.com (Postfix) with ESMTP id 28F4140003 for ; Sat, 12 Oct 2024 03:31:18 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cbRy6mAQ; spf=pass (imf04.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728703745; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AnO9v4vTKeXZqPVPayJt3fFn+BABsrVfLqW1dC+xfSs=; b=eTvk0P8OdcW08oliLr0SVzOnIXNXe9SgYTjBuft7X3rPO9mO4GajVYR8esoW8Kbp4iNBUf 2Ipg258TcbvYKEXpI8cSWF3F2lDuah36Yqp44xoBLIbBLTvbzIjBeSHYezo8Y5EyD9JUDk ZmLN3vfvv4YfD1QnvBoSsi1ioQ9akE8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728703745; a=rsa-sha256; cv=none; b=L2+6gkbbKqhs0zGDg8tMBbpEHMq93UrYwzv7O8kWiaeiOZi9Ihka4TflkguG4eyJg/8D1G +dqF7WN711l89f77ACydf0CA4pHS4h2gIjThoei0CEvYAbgdomy+KvLrGWS6x8aYiVitWn EdseKPhSw7aClsU1ITdU1PiWMKXeGsQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cbRy6mAQ; spf=pass (imf04.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a99ea294480so25629166b.2 for ; Fri, 11 Oct 2024 20:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728703882; x=1729308682; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AnO9v4vTKeXZqPVPayJt3fFn+BABsrVfLqW1dC+xfSs=; b=cbRy6mAQ8PmlumpRVrZ6tx0VCLfpOtUjtUS1EwzDtZHhRe0qgcnQSf/C3zunWloxhy AZfn9QypXPN3QCp60qAn33my4yD1jGpe7/3zRXb9eTKQzWgYNY2XrtyxlejNcfv6ibWe q2JEhaLFdE2/ozdr5gET8chQW6p3aIBAzqmoSa+zvqlKhnvfAewvb7e+YhO1m9hU0RNP YcvfLBZ+anrS3D7fFKwDZBYpM8xOFozi3ZR1jO8lnzG/65y38hQ9QSMJB+2YQYrfwIFr QqK12TPFHoFM8hb0SgUt5oiIPri+OfMNUcVtCiv0o1aGsrHuz/6iGDGP3urFZ34VMcDO Ecug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728703882; x=1729308682; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AnO9v4vTKeXZqPVPayJt3fFn+BABsrVfLqW1dC+xfSs=; b=ORtmNHrQB7Vb0vx6H6pj/D3yQYk6HzT8XL3zGBqCSv/m6A2SdVa7NrooM3adTptdXF v1uKKAzL9c+J205mGubCK78kg2sQumTdXsgO5CnHG7KzA7Xm+r9Cd828qkLMuy4A/gDG RxRiQ7GgCaUTNF/YKTF5oW8VubkLaJjwdVrUtgu/pEm+DDpBgjkOkUT1zI4d6E4pSLbC 1aSpwo6fblFevxWV6IL8rDmLSPR9SdtyQ1XF9Gcaafwc4jhJhIv/WkSK4bSY9Q5xRhNT trioX2+wpPq3R3Of2/kWkkBYqk8fNd0B9HW9CNgNOzR35DhLbUOnm9/jEzJSF6FP6X72 qx6w== X-Forwarded-Encrypted: i=1; AJvYcCXvoh7O16mUL0vWw3uYFapFw7pJQ5yY/Dz6AgeateQjBRy/ybwExmNCjzyYPlVgI4KZqFAIOOKd1w==@kvack.org X-Gm-Message-State: AOJu0YyN4OtqPHZPz0PSwjYcTXd2drmTSxgSD9ISFWfrV0xvGp484CV1 Ng4Fic76mpBJ6MpXBl75aKO34F/P+kbVT6PsHGOhAwq18ZtkO5Jgud0wCO+u X-Google-Smtp-Source: AGHT+IFWKCcdncpjIaFs5v+Y86kKPqO+J51NoGA0v1xXk9JslHDM9Qot9xCwQEIiLbnhyYKCowWKGA== X-Received: by 2002:a05:6402:42c4:b0:5c8:7bbd:1c4f with SMTP id 4fb4d7f45d1cf-5c95ac09972mr1447843a12.7.1728703881964; Fri, 11 Oct 2024 20:31:21 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99f292146fsm2682166b.118.2024.10.11.20.31.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Oct 2024 20:31:20 -0700 (PDT) Date: Sat, 12 Oct 2024 03:31:18 +0000 From: Wei Yang To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, liam.howlett@oracle.com, willy@infradead.org, richard.weiyang@gmail.com Subject: Re: [PATCH 1/2] maple_tree: check for MA_STATE_BULK on setting wr_rebalance Message-ID: <20241012033118.33rqa6xlpgxcuidj@master> Reply-To: Wei Yang References: <20241011214451.7286-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241011214451.7286-1-sidhartha.kumar@oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 28F4140003 X-Stat-Signature: 4a1ip8branqyewerugkgr8unbijgwtjo X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728703878-267659 X-HE-Meta: U2FsdGVkX1/X2EX9UDVqRDB6UTQSrX3EvN47BgJw9AMIP+JVqVcURQbaq3O4vbh3cpAxp9BA8ancTNtq1QEqYRBdyAVd2EynF25vZ8cV+l9uwOo9i9FO4OIMe8U+QDdLokHl0/AFZhsY6OEy3gg2UNi3evqR+wUylsEhOalqJHAfoVcT7vDFjSZyM30smTLJCpUo4DAGwaQNVEZwTdb98bwA24v6FRRouLmrPH4qG90gBzo/P+aw1XQGG+qQbTej3sQ7zvpuJ69DZEbe6U0WYzhVWfLo/dQwq8Ak+qP1A90zOCOcrRQXb9+aNUy3M2ZKh7sjv6lpuYhUjgke7WpHzuxXN59dS4Kw7nFWbH5RCqnF6Mz5OYuINueadjWaz9cubOEu1zs5wbesXZUi7i3zkQWMdibg/ngUlS0n+penX3nwECXyc5icwveECS9mlseLGNv4CRiwZiYHNPXae2Wcawhvz5tmj2UBYqRlsXKV0IAcnJwOcM30ozysXb6bri0lYo4EmPpfKUICPNlTxKOBiHlwsf6aE4+WeIWYd+mYCACQPf11SuKmURFyFNwGVRdTrIi36JMYjIKUOuJ3ItmWg3h4+88jeirIfTWxUnfd9H6qNTfzhM+xL3vB4NVhP9n1vQ6CyuYvNhntVhirpcW8u5wJgZ/qIuOETfAJKfhnwoGurr9RyAZ6qUP38EXcqEEiBMBDcC37GZWNy/Dyi+j6vhy7VDFegVvaYqHYZzNoAmErHENFm5Lx0peKyAq217u1W8N7B0mIqBJypQFgZ+TP1pTFTUgidjeS8lPs8UaIiRSUHrF4zXXHPmpDoePrjV3boT906Ztni8pdA0kFFBG2MO6kea6z9QiU9vJzGmYIzsSLl+lPuK/LvdpohbZbhAwoXfLqsiGsJ318QdSK4CQJHfPafozK9YBhtpQNAc7RS1yh0DwuQB2UEBRPZaKPf0kGXv0tJp/WZA+oyq3A1S7 MTVN624w ZJBZ0rGOKoAc1F1YlSbjXt/LiNNtSZM87JyoU1sWFAco8lXLjHmXoyfoYWEunAvY7XPOFdlmWVu3kyR7MEoEL2zmE4g8qHCw64OIvYJkk5fX9HyJiURd9d26SK/8ThVQsD9XclY1ljAvVStihomcXaOs5xUeAV9fkb9j3x6h4MOWewtKCzPA9SxFqte6SXhSjcQIkmfAK6RHvR9OiXqPL/8hkgdyXYxhxdo+hByvTxVUTJJ4e+NcW6t6E4KRAO20NQfZJmJ2do/Do9Q7/nNqflAjKz3IavNUhpLbi6I6QmNufaaPdsh6YKKPyzJ2SCdrvsLLXkoUhTMyWqgRM4no5vJhN1rEassfmdwbflZFNZf5HCrH1jUxxPoI9Cq745xwcEl1vE1nifbuGEPmp5bg1EKGr/xOQn9bQutYsLZkLPR++MKaAYZDMfsev3hrX8CHlu/DyIvgX1quxWXrzM9rBEu5I4+n14n4g602K5TFvygYnT70iykMmVSu+9QEQZq6rsi1P2kpLm3vG0hjXy16SzWIs6SNhuF1iJbNf4lhjW5INX3EvsbpXsN2t6aoaupQSJ1xpeBqRjyR7QrUFhf6Cvcj9C4XX6L/Rr/CRmgYqJFC17iHPlbyUlgf8IEEjSui7SYectLx+4aNNuJariiOM/88y7YOZibbns+9C4+b6VWeprxwH3D960KbfB+jUUXhU5VvbVjtE3NejD0U4hXy+ewJd+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.021174, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 11, 2024 at 05:44:50PM -0400, Sidhartha Kumar wrote: >It is possible for a bulk operation (MA_STATE_BULK is set) to enter the >new_end < mt_min_slots[type] case and set wr_rebalance as a store type. >This is incorrect as bulk stores do not rebalance per write, but rather >after the all of the writes are done through the mas_bulk_rebalance() >path. Therefore, add a check to make sure MA_STATE_BULK is not set >before we return wr_rebalance as the store type. > >Also add a test to make sure wr_rebalance is never the store type when >doing bulk operations via mas_expected_entries() > >Fixes: 5d659bbb52a2 ("maple_tree: introduce mas_wr_store_type()") >Suggested-by: Liam Howlett >Signed-off-by: Sidhartha Reviewed-by: Wei Yang -- Wei Yang Help you, Help me