From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AF1D24464 for ; Fri, 11 Oct 2024 02:00:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 946596B008C; Thu, 10 Oct 2024 22:00:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F5B96B0092; Thu, 10 Oct 2024 22:00:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BD926B0093; Thu, 10 Oct 2024 22:00:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 576F36B008C for ; Thu, 10 Oct 2024 22:00:46 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CBFC91A0D3F for ; Fri, 11 Oct 2024 02:00:38 +0000 (UTC) X-FDA: 82659667608.24.910394D Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf09.hostedemail.com (Postfix) with ESMTP id 0950E140022 for ; Fri, 11 Oct 2024 02:00:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VS6A9X9F; spf=pass (imf09.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728611973; a=rsa-sha256; cv=none; b=xJ09yh93lYdxtbGD9yUDwh5P7uiI4c2JZmiHmEDkjwyKduzQ+lGwgbsTDL2Disi7YIX88l Ty7ABB2l5jX5RHKWb7UVQOudpecFuB32XY1xLmDM4DM8A6FfpfDeCzzbNgxO10pu7nvGEg wJ67wVT0e5FxlOQCkMg4ULz6baFT7NQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VS6A9X9F; spf=pass (imf09.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728611973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MIY27C0tdIqOwD0lf08R7TNoajKeaviVN0jzboFZio8=; b=lGUTovoUYNFlfLdrSOR5Wxr57WBIz7i97JkhttPlV1XxNa+5G9gutjGFKOu19cmdLpPMLd v5/gCUzFXfXjfIEc9uDBHmlIld/qurANSAKrICOnw6tY3/qtj2FB8U/pfpxnxnUVWnp8UZ jrl7ohTjxG01I4rBvDDL9eMUSla+feI= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-71e3d45bbb5so54438b3a.0 for ; Thu, 10 Oct 2024 19:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1728612042; x=1729216842; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MIY27C0tdIqOwD0lf08R7TNoajKeaviVN0jzboFZio8=; b=VS6A9X9FIOy4c2Pv2SbLzSiSNneoqsidrAb1zwZtx4CCijL6T47YG7P3q6ZZTMbosE 10/4SdUiwNCfpVpNFOk2mB+0oX1cs4T7Q5tmia4vycKvs1sMF4hOvY19L+h+ScnPY3Jw qZmUAiUoDWXsId/LFlzDppf/DA9L8X3LbG8xI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728612042; x=1729216842; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MIY27C0tdIqOwD0lf08R7TNoajKeaviVN0jzboFZio8=; b=ZvdYfDzETPlvtCtM4XNnOySA39QbfdXQgn5shtP7BgguLKAlhb4WFt2zsceYibi7rO WK1oTfo3v227ppl+YVIIonNkv8mZta6O7p7tVVBRzO0Z1C2DnxOdSnVs3B+xRA1jnRHC zgmJlwwZxOGZqL7tkQczDoYC+ZkfvCl6oZvVID3MF5GkU+MfXGPVAuAeVEgh2A8zav2Q kVk5GaWHJ5byCEU+mn/MudjNSQX3n9v0EWfFSmuYSR+uIxXVK+L2OB98T+6LyX8wqNl0 8mBhj5/eaFu5WJYNjARXyTqQPW4/mK0Lqzb32AvIlwWTD1IhOEPb17UBfWH9vEknPQtU c+uw== X-Forwarded-Encrypted: i=1; AJvYcCVBm3TtZWXv7FrqDI4OL5POSZCHFdwBYuaVEE2XW47TWUeMKjXU1CHj2dcx5i/vEt8TapA7J4qQUA==@kvack.org X-Gm-Message-State: AOJu0YyjmnMmMq4EgyG08BmR+WZ2FUQ06/JGjxcS458uhzN8dG0ejqJW /hW1ocrPT8Y5511hHpp6M9A6KMQxR1SqDynGmea/+DOGgg+ivqirP735ABhAjw== X-Google-Smtp-Source: AGHT+IGJyjGx3ZGm+9HQWFGv7fNGUApFYuM6cF7ZnN4rjViPpPLM9Kc/z3JKRlbmwLWWBOIhgxfTGg== X-Received: by 2002:a05:6a00:2314:b0:71d:fbff:a4b6 with SMTP id d2e1a72fcca58-71e380c5f82mr1773228b3a.28.1728612042138; Thu, 10 Oct 2024 19:00:42 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:c13a:abb0:1c8:a3c3]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e2aa93b06sm1691672b3a.100.2024.10.10.19.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 19:00:41 -0700 (PDT) Date: Fri, 11 Oct 2024 11:00:37 +0900 From: Sergey Senozhatsky To: Pintu Kumar Cc: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, joe@perches.com, skhan@linuxfoundation.org, pintu.ping@gmail.com Subject: Re: [PATCH] mm/zsmalloc: Use memcpy_from/to_page whereever possible Message-ID: <20241011020037.GB1279924@google.com> References: <20241010175143.27262-1-quic_pintu@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241010175143.27262-1-quic_pintu@quicinc.com> X-Stat-Signature: zer7z3n1ndpf3guch4bjxp4rm35i15te X-Rspamd-Queue-Id: 0950E140022 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728612041-859406 X-HE-Meta: U2FsdGVkX1/GdQe6cO1zBqhHeBLD2hDqcumoFB6d9mRMiAG8G8WtOvX78YSTR/P0VaGqUSc76TZAWeC+2ROBdoMOM7GJYC/l26Toru4y3CrUInl+h64YPejHFBXewQwHmg41sMX8Qt3iI3ijrAk1wzF9p7+VR3gPbKdejIn4qLjrQLRHABmNQSyUMLVrbUrHNjgs3v0Un6oY1SWNppq6x2UxlIn46aqGzMgJLZz9zHOYH5xO8W4cB/3LbxG1+JwV0IdlodaOw2WzprMmXHO78OMnT4HOA8tzVfHvsuYFp5GURJvM+fYwgrMTSFGVBZ4zzJckmT4EqPTuC8N1v9L347YIaStwljhzUr8KuwEGAqCVJlXJNPW5EN/of+wEafisLIpqVsZeIOxWhqd0fe0ZxskadipXU6h4mejEKxrnRMKX1OGT8J1w3cfDkpHYq8If/PnRHKgjW0ABHhnvhsQrSvQWeONWOdHYBbwJH5jFW0UmlexyUZyb0wxffwdN2UgFWSIzt6st77kSS70mZD25RsnAmAc5bSUF2ufMtqFIMf1fk1CNaKENZgdkLUIvaSRbuuJIC75iOWWg8efGQ5nuKKi9qRj3fDpwv+d+wKaEDQ7YzNgxLoTShqyD0wAMltUxN2WiYXhnzJWktm7xJUsTMRZ7JC2OtnobjCtiMhUqzwlm3N0Nj/jMqYfIZjz2/tav+VPA2v/KMR2fU+Jr/aZ9FiSJi+NSqn+rZ7z2sv/cz7OTGs5d5m4AM6Qc5OMOik7gkhbIPFIeK9Rj+aVzCHBNnrNs3EZd7zbHyLdgaqWC91O0pVc1Rj34RjnrIDlC6+7w0aqd13Egv/n0imfaW9oyLRr9GNd0ZXA7NOpohhoteDGvPF20mettACtOoq1ik1LPDk3ECPIJ0UHlrndGseA7f9cibPPp9mVtsIOplqoCieNNdcNF2j/snk2tO4mOXYomqHZDFLo3/zFyc+HKgOj gYmuvAwM JbX4O5/3n/ARnlBzkrp4NZDHesdfu8EPb7d3TcN99E/v9y+7vDYHXZyYm8luGlDtRx/w4U7rlwriID5rciQ0yxlS/X4ZNCAd8WLU5RCBCrX94cSwX2+ci8lisDNeSP1lMdMoIXvkHd7N9skIcu3C4cw7kZVWuBD1HbBcCMhJbd/ouOCK8dTK7z3WjmohdtyxKMAqv341jwQXiwuU/wcHqFOXdsz4PWW1LYGXk4zAHA2ItpSNwX0TU48O6J1q/N1VKldJurRFPiQnx005EylhpLUxOhrkE+6aDaxMDrf3KAquvbaBb1vaMfJsMD/WARGUTyvw7zxceDQXohxnNodhyQu1BGpAt6eBkyW3VCIIXgT6Pb0RXqH8QgvWHCs4vZSWfp+sRjTw685R6aZUUh3ajmGg+VcDNPawWeojcRKOy4doMiDNxN33Z+iJO/RkwpztUiGtKh+6FOOOSC5UR4Ur1SlnZysqDazV3oYHj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/10/10 23:21), Pintu Kumar wrote: [..] > @@ -1511,10 +1501,10 @@ static void zs_object_copy(struct size_class *class, unsigned long dst, > d_size -= size; > > /* > - * Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() > - * calls must occurs in reverse order of calls to kmap_atomic(). > - * So, to call kunmap_atomic(s_addr) we should first call > - * kunmap_atomic(d_addr). For more details see > + * Calling kunmap_local(d_addr) is necessary. kunmap_local() > + * calls must occurs in reverse order of calls to kmap_local_page(). > + * So, to call kunmap_local(s_addr) we should first call > + * kunmap_local(d_addr). For more details see > * Documentation/mm/highmem.rst. > */ I'd prefer this entire comment to be dropped.