From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Pintu Kumar <quic_pintu@quicinc.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org,
akpm@linux-foundation.org, willy@infradead.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
joe@perches.com, skhan@linuxfoundation.org, pintu.ping@gmail.com
Subject: Re: [PATCH] mm/zsmalloc: Use memcpy_from/to_page whereever possible
Date: Fri, 11 Oct 2024 11:00:37 +0900 [thread overview]
Message-ID: <20241011020037.GB1279924@google.com> (raw)
In-Reply-To: <20241010175143.27262-1-quic_pintu@quicinc.com>
On (24/10/10 23:21), Pintu Kumar wrote:
[..]
> @@ -1511,10 +1501,10 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
> d_size -= size;
>
> /*
> - * Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic()
> - * calls must occurs in reverse order of calls to kmap_atomic().
> - * So, to call kunmap_atomic(s_addr) we should first call
> - * kunmap_atomic(d_addr). For more details see
> + * Calling kunmap_local(d_addr) is necessary. kunmap_local()
> + * calls must occurs in reverse order of calls to kmap_local_page().
> + * So, to call kunmap_local(s_addr) we should first call
> + * kunmap_local(d_addr). For more details see
> * Documentation/mm/highmem.rst.
> */
I'd prefer this entire comment to be dropped.
next prev parent reply other threads:[~2024-10-11 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 17:51 Pintu Kumar
2024-10-11 2:00 ` Sergey Senozhatsky [this message]
2024-10-11 14:41 ` Pintu Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011020037.GB1279924@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=pintu.ping@gmail.com \
--cc=quic_pintu@quicinc.com \
--cc=skhan@linuxfoundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox