From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 929F6D2444F for ; Fri, 11 Oct 2024 01:09:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A86596B007B; Thu, 10 Oct 2024 21:09:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A36E76B0082; Thu, 10 Oct 2024 21:09:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FD6A6B0083; Thu, 10 Oct 2024 21:09:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 711066B007B for ; Thu, 10 Oct 2024 21:09:53 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 87A16809BF for ; Fri, 11 Oct 2024 01:09:49 +0000 (UTC) X-FDA: 82659539424.29.2514D24 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf10.hostedemail.com (Postfix) with ESMTP id 0624CC0008 for ; Fri, 11 Oct 2024 01:09:49 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K8SuJc2B; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728608878; a=rsa-sha256; cv=none; b=neJ8mhSl77KwZETDMX9PWSOHrVz7sbrjJxZvERj1tY0Od5uW09taPLOMjiIYq2WsagjfCN K4P+nhtNhrTfyLQJFaD6uRF8ksv2AGUAJUGiqvUF8bBUo6AI6oc8H9HzeIXRe8HxUnz+sc QeqN676gNtAq66lmRF+n5dTzDjuGwUc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K8SuJc2B; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728608878; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zTHje0muZPf49FQkQjwDnqpyf3rz9rMv6QsPFUwU2q0=; b=tpM7Rc7/SSuiztLY8zb5U+j14wY4tdzVLVWf5crJrS1dQYL4el4ZpSu/wz1YDTopixrAJf SRZVbmKYeWpbcHl/gZBQ7bsmGw+x8S3kJMpjDZrZfvqnspXWHpgfF2VgyUt9JAtkSzN0R2 4uL+6kktPEedzDaHyTCouMO/OOkSvUs= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5c721803a89so1980667a12.1 for ; Thu, 10 Oct 2024 18:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728608989; x=1729213789; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zTHje0muZPf49FQkQjwDnqpyf3rz9rMv6QsPFUwU2q0=; b=K8SuJc2B6EAhz0G6hlJt9VWJgd0k8rQpuA9Q4ejPlGCxs6SoNy43ZlWm6XqI4yGO6l raLCgU/3gaXPchT6JR91M3Wj+JiiS2FsAKsY6n8Dhey9g5FVmkH9xW/F6Lnfypbny03m t18wPAq0blo83cC0PsPSbLnhYYUz6Pss5CwPUt3oBOgceUqe77TXN1Kr7W6auBdthYo+ YeOGnSozUAtXjVv+xx7FPNe6my2qNH7D2wTBBtBQnCCJ9ELPew7mtwKUv9wqz6A93MFF xy8YZNrzBt1y4obv7mx5xm/Vw5louq40UUgpH6WmG+ZmsJAFhfQ61DpGKFQs+WmTjBt8 Mcxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728608989; x=1729213789; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zTHje0muZPf49FQkQjwDnqpyf3rz9rMv6QsPFUwU2q0=; b=U/zV3L5JcSexiUB4GMoWyjGLXu4M+vRGgowqVt2EXI5gKFaR1Knd6fywFTYSJuXfAo Ns65e1YnAU6R856HJtlDC50Bu4i5ormO1S6qErxcSR9cvKYulYg0Z84p3QIYBCo/iqXM 4CwuRwvByTVO91xZtc7TF0kU2NeJQl5htgCvId7AO0mQlzKDjIyp6xo2Fv+OgRtzxpwA xlPM3Be8dDj6tHe8swskBqulrHb4INf0ilxVE1AqCRiWkLDmT9NiKxJcAOCqZJGrnEcn CPnuBnvCUfyr9R0oKNPzJz2s3AhUg0h48aP4aeTZaU4NREBFgowct7uRcGhIqoHqTWcg 2b0A== X-Gm-Message-State: AOJu0YyDfVlDw+z9hHaSV6NeB1i66lUmYE3dKIjakZZMFB217yCF0y3y Uv15NqsRRHJbqfTmxdlMELMP20/aa8wRs2N7gLwy10c9jtfoLckY X-Google-Smtp-Source: AGHT+IG9MwYDvF+nd2vSnJ9HW7qQhl2AOrp7z7oZAVKf8wELtMFSou4SIqZpfnmpwPFuiZTf4urQUQ== X-Received: by 2002:a05:6402:274b:b0:5c9:2a8c:8950 with SMTP id 4fb4d7f45d1cf-5c948cc83f6mr398182a12.15.1728608989111; Thu, 10 Oct 2024 18:09:49 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c937298d98sm1380250a12.91.2024.10.10.18.09.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Oct 2024 18:09:47 -0700 (PDT) Date: Fri, 11 Oct 2024 01:09:45 +0000 From: Wei Yang To: "Liam R. Howlett" Cc: linux-mm@kvack.org, Andrew Morton , Jiazi Li , linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Subject: Re: [PATCH 1/2] maple_tree: fix alloc node fail issue Message-ID: <20241011010945.usgu7kqjdzimrwo3@master> Reply-To: Wei Yang References: <20240626160631.3636515-1-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240626160631.3636515-1-Liam.Howlett@oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0624CC0008 X-Stat-Signature: cp616nbq4dxnikknkwuu9tgf3fpntner X-Rspam-User: X-HE-Tag: 1728608989-689612 X-HE-Meta: U2FsdGVkX1/AGdFxAa2COHSWUyEk5zaKT4m4p/g3Qfi2fSeJaQPLNg90JnRwXX7FHfXTXBVJN4TE7ycqthfH2701l0ATPds97iTE8SY76y/Z5lweoLhtgyR+3FsuHmplj6Ih+SfiEP0XA6rlr35O8tbh2XBEemaU91AWzyhWue89vscgOBON2nlNGUNMq5HrWqg0+Cp4Umz/NOjDog9NF/h5FL6XC4mSkCnbiaQRVl2y6SvWSvQsYgqUoeeLkDlU97E+f0EmyFdqhPw1EFvlOWbpwpQ7KywatvCRqQGLcllg7S1c4Ai93P7VLOJ0r5ed4GCuk5mNfJF4E4VWb1LW4pzCzhGsqQEQ8lckv7SbMi9F6rZPdeT6m90qMottKr0dP0PSwuB7TiYYKqDJC95431CeLLqb0HZH8cAda/VZU3g0d8vfJI2fkmfXr2G7OkRtnpaJ5uvnVUcCcLUxmKKOrvnQ3Twi4xiOKF8OC/zLTMzPUuEreLZb615wA8qk7gfLGYTXeXdCfGo437oKDk5+VrqMiOb+4nlh6qew1FtBRkmsoLQIwDhlzNIWtQG/P/mj+9YpP90bHkl1xikcmfZ+PV/A6xAP83/We41yrQYkZ3JtGEENR2Vg41kUZZqLiY2yUQLaFjCgPKQJ4cmhGCB8+yziACiF1Qnp3fugSEyPst9Hn2XK+t8CoRXUBxCr2w2Moufax2xABHLhXogCOs5t0C+o4xEClEfdzDz7WbnzIObrCm8SnoLk7DWj8TzJSSneOp97JC8VJcgRhMdzIys7gynXLwgsWQ2XRtUQSo0LpaVaOppAQpZwq1JxIi7OTtsBCSKyawIyPUnk9E4jlbRrEIj2lvMY3LAJwk0DpfzJyaj8h0Ego85lI3QxkJCV7a41uXfo+XAsNdnZnDqc38tmFveJXvvyiDNJKWJWUezTvg2zS4KuMsFGHdwFj3M8NPaEbMK8spJFRpJLBPyhlMF koPBKliX nyQbuLxyj6C1pW2ZVEyu84MQ+cTavoT5n4SEj3cF9ca8RJlUYaVLfdFxPK3mvek+/osp1cIxGpcr0k3atus6V9w6xed1yKTta9/QGHW9t5YLrk307QN/2j+LeHMKYMC4jRGivs25gtBGQtPQkNHcfQsvsressTgYq2XJsZ9oZyPNUHmy8k0kEUxq2tTMRl55F3+85TdGBt16mG80UuR8podxlyArTZ+lMK4k9YzuIlC3Qf5q1hLVJ6oVgdOr3HFL5cP7nhN+JHemJvnjnPpQ2N+ncz2sruyaiQWxG5QVwbqvuVdThbVUVaorX50oCAci3lGhhYIcZ63a4o+te0kFtzGpC/8gjF7K8AphX8CU6RFFpQ+2AmuVkbmC//n1/70h6QqsAnOeAtGdMuVDf9DbKTfpq/giOX59Lh6tdE4RkQ8hDc5dkYARp42kLvUG5S0f/yyvckDqwYhHVnWYrP/w3TM5Rt84eamzrYcvtIfghojr2m4arh5ekRx9XC1dUVyWQDkWOtNr6ODRaXKoZsawoOQms21lH0MbqV/jAiilWjl+Di/5kN6Sa7uochgUZma+uLd5wT7HmR2HqAkdcLlXzGLpty8s7U6tB2dmPJxu3v+DeDImktLupeCFgSFdej0eVccK981X1SOBfRAA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 26, 2024 at 12:06:30PM -0400, Liam R. Howlett wrote: >From: Jiazi Li > >In the following code, the second call to the mas_node_count will >return -ENOMEM: > > mas_node_count(mas, MAPLE_ALLOC_SLOTS + 1); > mas_node_count(mas, MAPLE_ALLOC_SLOTS * 2 + 2); > >This is because there may be some full maple_alloc node in current >maple state. Use full maple_alloc node will make max_req equal to 0. >And it leads to mt_alloc_bulk return 0. >As a result, mas_node_count set mas.node to MA_ERROR(-ENOMEM). > >Find a non-full maple_alloc node, and if necessary, use this non-full >node in the next while loop. > >Fixes: 54a611b60590 ("Maple Tree: add new data structure") >Suggested-by: Liam R. Howlett >Signed-off-by: Jiazi Li >Signed-off-by: Liam R. Howlett Reviewed-by: Wei Yang This looks good to me. I don't see it is in the master. Not sure this is missed. -- Wei Yang Help you, Help me