From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82581CF07BD for ; Thu, 10 Oct 2024 07:55:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AB176B0085; Thu, 10 Oct 2024 03:55:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15B426B0088; Thu, 10 Oct 2024 03:55:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 055696B0089; Thu, 10 Oct 2024 03:55:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DA0056B0085 for ; Thu, 10 Oct 2024 03:55:16 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 84F8A141BEA for ; Thu, 10 Oct 2024 07:55:13 +0000 (UTC) X-FDA: 82656932232.30.9BA3E77 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id AF77712000F for ; Thu, 10 Oct 2024 07:55:13 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="WAc+k4/M"; spf=pass (imf29.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728546778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XBd3SFTmECKxjtddnfLm2BXL3dybpXIHtlONUIhgR/g=; b=cNqLEnz6pH6WhdyiUDBCXySeb6BTHFvmlC4z977zjboz/oYU7H52990TQnG38nfgrShmXV r4WV72amSDeuEROgulIaOcoEwp+WivJYTi0wMRBkFXgKriVkzD199h99xSmIitNPatsXUj 742gk55MPdYA3rXJoBdhQk8Dolo7K2Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728546778; a=rsa-sha256; cv=none; b=ZlRRbvYXjusZ8t0cTo38dfM+X6kPDoqNQGqtIvf+y5Ac7UT5UALeMCLXGjYMyLDm/+KKdW JyrRPerivT2XMnFIMs01rSLZa5D+/oDZ6toehLvliMGokQ/7AZQz2877cKMvWzYx13yjGw 4ypHTn60Fd8TDY4vA80HvVhvHWMn6jU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="WAc+k4/M"; spf=pass (imf29.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 209CDA41B01; Thu, 10 Oct 2024 07:55:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5D0DC4CEC5; Thu, 10 Oct 2024 07:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728546913; bh=TlV3g42Y8W2VC/WGMkkTMms4/8FYUEorHOFIiXFAeT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WAc+k4/M+UZAe8IztD4HojB8IKP26NlNbaYsn8TdJGkQhuNFeBFhpeRQGZB9N3GWf 8Ar5yRJ9IRsCpG0R6NcPc4ulgtL9THFO1/Bai9Wu/WUNbsDg8+vu7B7pdyhvtwX1mo ZNdXCsAXbpGkKLH3PH/aOeCysNZ8QEIwGp3GNezo= Date: Thu, 10 Oct 2024 09:55:10 +0200 From: Greg Kroah-Hartman To: Linus Torvalds Cc: Dimitri Sivanich , Arnd Bergmann , Dan Carpenter , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: sgi-gru: Don't disable preemption in GRU driver Message-ID: <2024101051-yonder-doing-f793@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: AF77712000F X-Stat-Signature: tp1diqyu9ck3bjdkq8m7myqahqww7qfd X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728546913-486964 X-HE-Meta: U2FsdGVkX19SFOJBLYCoC1WgOGjU8o144F0PDK/vFAQgGcTgHqmoZDUf5bgWEGbJlwd07rp5ypxDj7NYFh/7Z3PM72GiDOvlZLl+VbQ1XeaLgReAhQ6659hOL5b3SxVijJnkTXefTh60d3uraMxd+i5jNq6PxaOgfL3fNXa2TuOxLSjlz3SprCO32+FQggFIEVduflz1NamHLzdu/UbLmn6k8FXOYJ+An0gRrmNsFyj1pOv4wNJHwntHf+zc7w1jPfQbfFDOS3+f3OxqshKIRkOrzrwgSolczxDltluLV6hPcZcanHRRelVj1Fc+n/2+d7CaQ9AzPXiqmB/kLHYrzvipylt1bCgw8xV9jYtPJn+qUHFYUaHpsu5SjvPVWTi6pycCBp7BpevAZqRVNBNxU1C+CGL9UolWpYyBOIx2FfXtVyGCPxky5/ENGlm4jtLrnxuJw8ALiqxi1q7BgxBPsJ3qPhHFqbajqUaCY6ytAiU+cWHpVpPpVWoEgNsSyEjdxcfFcgCD4uEmzMl1fTyKDTou8oGB0D6gGAzWsy8+of6emw/BtkUTQlrTNV8J+ZkgZW7BkjLTkT+FcGbn3k2PJitLldUD8+xROBea81APGNGqBPD0KQZfcCVE+PssulTwQrH3DsIwLdrtS8dCt1ZE0idfRAxqSyx6N85CXx4QXfbnHaKIwUkWL5GLYMPUxvj4QjNYnCn4FBcSvdnx0lTOj6wEyUk7krp8zajVP3FUJlWCRBm26JV1UnyY5NrsdPqCo4PImBo4WyN270kL1I6FrhzW/4LsCFUPJ1aaTqmW2lsK2db65+yKTgTJA69Ddce8hb/I+GtmkEfzDQGikVUvWe4F0tMSqGfso+fWJ9XxTidgh2acBq98o9kcPArds7dDpWAYWQVNJxq/GRCg9yFjFA9PbwKpX1DAYs/4/AF/syhU7MehDdhoXDPJwiFhQnXcze+tVTnftHaezX4dBu1 N8elFV4O G90o3bcCX4eyFoA7uDs7WZLBSNudjH1QTqROf6HtxlEFFu13FExA3VhTZbsTvP25SbetgDrLdXuy6bOlBm8jsFrxg0aB4X23bxY5T0vra2/8ZYhIypRGgWkZZ+BtNBajtqhP3RAClUIXBE8QXA+LVu4Ija4JacC1bYPt5fKMk01X18Q4BWQmucfkN/fql/TbR7fWvL8buNCZY3VKL4ZS9sjP3Mls9E8G2uN4QqtRbEoCMKUJqlSVxLCjBwMQy0AmJ6V5gIhaZd4XJBwyFXWWN1PfxOKvDZGERL1EOCt9+REN/gPvZYHLnA3qdYZTr3Zmi5Qa1BcFvanu6LTB6h8+Pz69e0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 09, 2024 at 12:49:23PM -0700, Linus Torvalds wrote: > On Thu, 19 Sept 2024 at 06:16, Dimitri Sivanich wrote: > > > > Disabling preemption in the GRU driver is unnecessary, and clashes with > > sleeping locks in several code paths. Remove preempt_disable and > > preempt_enable from the GRU driver. > > I've applied this directly, since it didn't come in through any of the > normal channels, and I don't see it pending anywhere in linux-next > either. No problem, I hadn't gotten to it yet in my large patch queue, thanks for picking it up. greg k-h