From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91810CFC5E4 for ; Thu, 10 Oct 2024 16:21:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 217BB6B0085; Thu, 10 Oct 2024 12:21:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C7EC6B0088; Thu, 10 Oct 2024 12:21:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B73E6B0089; Thu, 10 Oct 2024 12:21:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E11156B0085 for ; Thu, 10 Oct 2024 12:21:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BD826C0466 for ; Thu, 10 Oct 2024 16:21:51 +0000 (UTC) X-FDA: 82658208990.14.7B546D9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id A30EF180010 for ; Thu, 10 Oct 2024 16:21:52 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="f0fFDMh/"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728577202; a=rsa-sha256; cv=none; b=zNqkZK/M2EIon/NZvLXhe5l3R2uWS9U/GgZeTVJKRezPABfimgb6bem1Ywse3poqMY/VPN hKgVsYPJkcwdRoRS7wjbxCwhaLtX2Lf9yjUnqMQMF47ovbMJRpobBAvg49Et3rZwKI9oIZ q7D6IewQk/Uck9q21F7dynupqzbLhHc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="f0fFDMh/"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728577202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wkwifZXR/6bBSuolVOvZvMkrTTdiDRJkUwROqwHnzak=; b=QLG8v5ATrvFSdKGceikL8zLMUxM5AjQYfITIGYfQrDSLtYMQKIbK6DUQNj8lzMCaQYUSa9 UQ9rhEhW+zxLU+wts+hmmyt/bI6wiPBlCtgZV0AYe2SLc+4H2CXoUfEcZAh2dE/VP/vUxf eRYK9FyL726ktusaLxCUN60MDJTzuoU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 803C95C5FDC; Thu, 10 Oct 2024 16:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55F2CC4CEC5; Thu, 10 Oct 2024 16:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728577312; bh=kz1uQzRl/tKG/88HfwDveiz+2UzYrHTsBIr7zPlf6UA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f0fFDMh/87OOyJeRRxkBBT49Oi0tCUXfEsHBl1hvivDvTG1w4KdRYr7yrhD4HkRG+ 1+XvpWFLXl9wKKY9NibU1Eb2+aQbyzEhJRiPgYiNchl7n4bYQjgATt8ty4GorY9MkC CCb49B/v463PjCnEuAUfQiLWDefMIk+t68qQZBpkIoToJMe6L6AlMhvtcJ0lOBwcTO SL6a0ng58P+qGV+D0ki+g3KwOq52i/+MSl1lQ4nq1kVgpcK4MkkfXGiJcLl1IwfiVn XtmrGwaeHPaG1M41/+fCwIq49NhFvfUBFfZ5w9l6pUxvjoLu2u5ji6ZnHOaPCTlvMv rVXqshchTPvrg== From: SeongJae Park To: Jinjie Ruan Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon: Fix memory leak in damon_sysfs_test_add_targets() Date: Thu, 10 Oct 2024 09:21:45 -0700 Message-Id: <20241010162145.195696-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241010125323.3127187-1-ruanjinjie@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A30EF180010 X-Stat-Signature: 731kc6arfrrzpsuda3dg33sy5e83bbgw X-Rspam-User: X-HE-Tag: 1728577312-320954 X-HE-Meta: U2FsdGVkX180HbAE0YlSU7KFyIpcLEN/sFSkKczoYkzYPGqNzdQUVewnEzyeksLAT4Apw18dMcLcIPFirSLGH4tniWPLzDE+CPzmpIhKrEnQ2tgHZxVAYHgXdmaro4KIlnIl8+mrfK11E+QjeLxb59UdAOpmbyXgyr/DM4eZNdI7JrT9j0N7E2FV0Nej0MMBi2gxrecle6jH9d4Q4hV61dAlw46TtAJlsmc/YbCYdfcamxLS+jvFEia4kWhwBGqKMKr3LcM371aAqztCnS9j5Vr6paQp5HK9tNOuEAto+V8pfpew++wuy4DNlAOETXvjNgZDBIlazFej5bV899z8p5snotqBN+bBQl1mphXHp0dL/6JztNjjYM34e93LGohGERDpBmu6mQsrsiaZXECdO0f20bDbHanXFwteBXi9iOw/jpNBgnBXlmgNrM+AKTspRPtJDu9/NYX2dAm2AI9X+P6/YQHjoamHHQzu6Iuo5XUqjWBwHnBHhTMEkYfiL6MhTZJXFt7ZjOiW0NHYlyz4WDpkW3i2KfpxE+9emzA8VnPZtOUz/ORbOYnT/9GI+KqQk4hJeBYaYMKmHr0cqHNbndhc/vY6kw16gY0GE39Cmyl1VM6k4MTyemVXtgs8cfzSfyLVGCPGcsaL7+vhC7ZytqK15T0TQfcbDmdEcrGwgyb6IlePcKW0XG75UCXnf5R4eBVEm7WqDc8oH0/NininwFFbaQ/TF+VIBRKrfqri4QbWfs8E24z5BDlN0SS6OAW5Q2ip7o4ogohAROekWRAUVIf40RRfq3kATpAF9Keo/jRX6yORBPQTCKzPV03L+9E8+yQjM7C/PiUuIPIzcONjUu1vtcBEohQ13P+gXnPymEf0aE51ctKYoA/0bJcn/Rm02W99XaMVhXMEtE4BZwR1IEFTqSs/gBbFIkOR4ujT9bqkiLIzgsTm1Iccf9wc4qOfNMvM17ahBty3Qq5diP0 SKYHO16e mYqs1sRb+TqSGbxL/D/a7F1zsB2aghmGzMy455e1WVwO/ImVbAsp+fEtlObn0U3GOHK8YbhBCmyd2z0YOGBeHVoRt4G0qRwAHJIpn8Vlx/bWg2OGz2IfUQojllp1IbTIjuG07XY276tuB7jMHruLWKx+SbY7A5w+ShXkK1eBP0Lh/ZE1NYPMvG9nlqiLLk30VYmS7lQPr3D8YFyNRgaAGle8rkSJRxu4wWib9zAQrlHLx442b1QQcsNaZ1AmXkWREpQYoB933FrJM6BVh9KHvoQlbDW3XfflossxOqjmuQnIW7Dw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Jinjie, On Thu, 10 Oct 2024 20:53:23 +0800 Jinjie Ruan wrote: > The sysfs_target->regions allocated in damon_sysfs_regions_alloc() > is not freed in damon_sysfs_test_add_targets(), which cause the following > memory leak, free it to fix it. > > unreferenced object 0xffffff80c2a8db80 (size 96): > comm "kunit_try_catch", pid 187, jiffies 4294894363 > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace (crc 0): > [<0000000001e3714d>] kmemleak_alloc+0x34/0x40 > [<000000008e6835c1>] __kmalloc_cache_noprof+0x26c/0x2f4 > [<000000001286d9f8>] damon_sysfs_test_add_targets+0x1cc/0x738 > [<0000000032ef8f77>] kunit_try_run_case+0x13c/0x3ac > [<00000000f3edea23>] kunit_generic_run_threadfn_adapter+0x80/0xec > [<00000000adf936cf>] kthread+0x2e8/0x374 > [<0000000041bb1628>] ret_from_fork+0x10/0x20 Thank you for catching this issue and posting this fix! > > Cc: stable@vger.kernel.org > Fixes: b8ee5575f763 ("mm/damon/sysfs-test: add a unit test for damon_sysfs_set_targets()") > Signed-off-by: Jinjie Ruan > --- > mm/damon/tests/sysfs-kunit.h | 1 + > 1 file changed, 1 insertion(+) Can we update the subject prefix to "mm/damon/tests/sysfs-kunit:"? I think that will help readers understanding the change more easily. Other than that, Reviewed-by: SeongJae Park Thanks, SJ > > diff --git a/mm/damon/tests/sysfs-kunit.h b/mm/damon/tests/sysfs-kunit.h > index 1c9b596057a7..7b5c7b307da9 100644 > --- a/mm/damon/tests/sysfs-kunit.h > +++ b/mm/damon/tests/sysfs-kunit.h > @@ -67,6 +67,7 @@ static void damon_sysfs_test_add_targets(struct kunit *test) > damon_destroy_ctx(ctx); > kfree(sysfs_targets->targets_arr); > kfree(sysfs_targets); > + kfree(sysfs_target->regions); > kfree(sysfs_target); > } > > -- > 2.34.1