From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9827CF07AA for ; Thu, 10 Oct 2024 06:28:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8AA66B0085; Thu, 10 Oct 2024 02:28:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E13696B0088; Thu, 10 Oct 2024 02:28:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8C856B0089; Thu, 10 Oct 2024 02:28:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AA0416B0085 for ; Thu, 10 Oct 2024 02:28:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A950181B12 for ; Thu, 10 Oct 2024 06:28:46 +0000 (UTC) X-FDA: 82656714378.09.A6ABCDF Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf05.hostedemail.com (Postfix) with ESMTP id CCC1E10000A for ; Thu, 10 Oct 2024 06:28:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F78WmoTF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728541616; a=rsa-sha256; cv=none; b=AwUP9a6yCyP+1zwmAcEFpyEh/blSv0952NeXpe2HTaiM6xiJKkF/+dcv3y2wb0x8hWzgfX BPFx27BqkfgxsrbZDd8oXXhMZZE8uRKCBFog4s9/MYezsGDRTA82JL9Wv82+b9kLmQYwr5 R8lW+oOsp8E5lc4+MCO380hKm3wf9h8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F78WmoTF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728541616; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vQIRk9er/7JER8ZB4cm93/qw+JSPkCedJXj2bvL9sTE=; b=NZRMHN7EsFYoD/MQQTemopi0CgTr1GvEJ9j/7jbmLNCeAf2u+GPAus45g1NbmORyY/rClW RJEdPxMXLyt/c2nwI2rUpr0la8xQB5nx8Do7QlWJATv6VBWgfGD7z9AztgVC3A6LPmzVfL AduGnBALssI9CWaFJIB5/GZHPM4/qbM= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a83562f9be9so66868566b.0 for ; Wed, 09 Oct 2024 23:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728541726; x=1729146526; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vQIRk9er/7JER8ZB4cm93/qw+JSPkCedJXj2bvL9sTE=; b=F78WmoTFKhSanhLtNFuf/LBtNAThIcbY2nL7ON3/jPdUqy8MVkhyjx8z3ckUMav7r9 bEpxNhM7ZE+HK2aUcf7K2rTzuUUOUF4B/8LoXTag7dcfKspafFRlUF2ZmEDqQK/321Av ON6ufd6l03YFN5LvkxYIT0SmMwOr5RqmPYPlcS6+baHwMJMCHiphlZW2VeJ9u3bvuBGh InJI6vh2SancXaGqLbyip/DO5+zEXrmw4Rc/DjjZwUTX4alG9ofkdy8U2K663TUIXsxE d/enSoS+71qzX7V4IlQsvaSlXgUMP5kvSEWOngcTqEhoCMqJyL7+drThNSdqEw/GcSy1 qZ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728541726; x=1729146526; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vQIRk9er/7JER8ZB4cm93/qw+JSPkCedJXj2bvL9sTE=; b=Ma5gXEf0ixTwkSB+AZxxyBLR6oYjsqNkXC1Bw3xVcQIBRbugRJ6arIIN5QY0BDPD0p WzSklsn5rOCJgL/iZLGoEh4gf235Eyp/b3fVGpRDHtfgG3Og95JXVqVnuuooTRIhmSds DW7mHVY4emdKSd03i9fy/t5fFaLuRZ5K6g60o7aHBVmTJC/e/UlSzN0b3hl6IsdMF/m6 5VzuWjYOU/lczo6sFwEOUb5l2rrpYYITLBASH8U7j9DXmSHgLRDcN+cI8KxGOxYCmjk4 VYcQo9wEQAEr1GBQxD0+TegjmZfkt3Pmc91F/MUVSYSsBU9x6xICqiaZhhJ3bS+HTtWF qfuQ== X-Forwarded-Encrypted: i=1; AJvYcCXm1apRSwXgGib2/PttIu9+p/FKRVOHcxHY544vAyag4WUELzLl7pFgZ6n0NOEbWIUy6azIaE0fiw==@kvack.org X-Gm-Message-State: AOJu0YwFu6cuDwNUDfO+bdmvnThfhC5jmK0+SkYmxkuf0d8fyqutH4/K n3dOJyhmIf+Klsvgi6i9QDZDsHeXXLEavteXhQcBYTza9FLTzy2z X-Google-Smtp-Source: AGHT+IFMuVT3IEB1d/RlM1JoMKQlmjt2MB8ypTxZGTx0a7hamvKO0j6NZYswS1fnDDP3LOo01bemkw== X-Received: by 2002:a17:907:94d4:b0:a8d:250a:52b2 with SMTP id a640c23a62f3a-a998d114bbemr388572366b.6.1728541725498; Wed, 09 Oct 2024 23:28:45 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99a80f21f5sm39299266b.202.2024.10.09.23.28.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 Oct 2024 23:28:44 -0700 (PDT) Date: Thu, 10 Oct 2024 06:28:44 +0000 From: Wei Yang To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, liam.howlett@oracle.com, willy@infradead.org, richard.weiyang@gmail.com Subject: Re: [PATCH] maple_tree: remove conditionals to detect wr_node_store Message-ID: <20241010062844.vf4pyrd6isfddwo4@master> Reply-To: Wei Yang References: <20241009152007.2096-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241009152007.2096-1-sidhartha.kumar@oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CCC1E10000A X-Stat-Signature: c7geu4f8159ia8yqo37bm1wo5xuioain X-Rspam-User: X-HE-Tag: 1728541725-955206 X-HE-Meta: U2FsdGVkX1+EGLkESo49cZ5DJE1hamPvnty3WLFaf7lJHyEBmpNLgaib+V2eLghSx4A7C0mwQAhgPskMCXNMnK8dsKetC8ul2FS6MdxVfwrqdtyS5CZrIwH9pSEJh+9sRfpelY1QRJ1GJKfMfHQrfm0Jlx6iSW6sw6BWFL6qOJ12vPHVMnWXIxCl2VoEm36dfSOan58XdUOiTvIPJYPJUd1APFZ+e9bBE+d7dbTrlj2bGNjwadhKFWeZQd0cWdE6B972Vx9MtSd4kQQ+Cg541psXa9MSyQdLiSHLWQEq2zkVLSmvbBiAjecmcmwrAgiivgpm16f/N1pirZuo2wcg93QdLsk5dmTdjWf+1PGy42lxU9nhQpDpS6s16CXOEH2lQlYjba718tVzxuTr9T6egQ8T07pNQC+IbaeukoA8g3qY2gP97QTjzbjVWhFPxrX/mNGLQKESDWq94l3DotNDzMxvirRIS34uVzEGfxj15PlFqNanTvNKLbrwXGH0OrtRuRxCyHF2Tg/bXL3CrFPgZefCD/GxPljdPf4OALXaMjoAmi2oN65/HS1T9UUUE7dXkJW/8dT8A2ZZK+za77eRJF3xN+tMTJDOMEnLwbxvlhGaP1X8Ad//ZGtqY8AYAhN1dX4f/wUeZznZJs+8CeAxmp0z3vYPVvQSckMeJKCWd1nWV3qaNrf7OLylmx2Bm/EIOoEejcLu8Ipq5ogKdh5U8F4zz9O+Oi+hd/iBxbyERconF3rtuiSs2JgJhafMQfXUJ0v44PbqDvghaHOh3HExt41RSPQu0izjRw3tEDLoPCPpHMgJAzSKXgK3E9fBcMEm7/cyDD5mUVouwt9WplaMOrs2dWGK+yqgGMlnsHA2F+Emm1a81ezS7tBTJMsyo9LCCnSF9e6gMhk8YJ+zd3yNmRIIwybahBOVOvru7Agax3zhwfbQX+/d2NSTVIYFvCCQQyrcnDwL4JhUpL84IuO bbO2KsBi LecuGGjTL9hUlrs1L5SX9SXfSklGsdKrVQVsq5tw2iYmiimKzcCBolITsLba/FIQp0P9sDa1NiVnWykIgI/ByqBgaMqy9YiVfLF/4pdQeaVJaQLw4R+JOqXXhsI8YmLJynyCgEDclJ2e4rpuVo+CwQ7+chSxFjrT5YTgf1nLEwxSPqBmzKLtswhNcxm50A32HB4vpUCwPssdZFMQ99MCLoPa5HwdL6S7U7OMyVTSRJw1aACvVJ8ynBFavP4GS2yE6aRNVLmRGbuUOmTLpXDbt3azx72/1dbYEtKAfXHmbOFUNV7QPfvLg5mT7ULrFYMi5a1tlMJSf4SviAAonT4tyCdMcMB1UaJxnBF5onNveB6JRq/FgqZRq/+V57ZPdJK0yKnUXLKSVGaW1ub3nGPmh0x7ZX/IQAkhahmDmwq9JFuAC+3dOyVEsDb5aBRxMMBHtt9qI58mP6u7e08nxfDndgnuVbVbJnA1hY5D/xG88JlcObFcx0Hbcq+nt7IiXsFP9OMb6qtphPWTcbK2ETWrrl/H7QiHS1MPQYXyirH2zFigClOqPtOtEZ6X+Zg171eBQdKdj8vwRkfuBFMWQk9s5ICSVG818ouNqWvBn+vM78+bVqvVeTTxSMMHk6ztnolOrpLx4JDvHpUnZ/UBC+Jlj/VpbElPo/9lKX30EDvRS531nKENPegvA9lq3PJaofBvPdgMHxdh5QnQ1V8dBNvhplwsplA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000218, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 09, 2024 at 11:20:07AM -0400, Sidhartha Kumar wrote: >From: Sidhartha > >In mas_wr_store_type(), we check if new_end < mt_slots[wr_mas->type]. If >this check fails, we know that ,after this, new_end is >= mt_min_slots. >Checking this again when we detect a wr_node_store later in the function >is reduntant. Because this check is part of an OR statement, the statement >will always evaluate to true, therefore we can just get rid of it. > >Suggested-by; Wei Yang >Signed-off-by: Sidhartha Kumar >--- > lib/maple_tree.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > >diff --git a/lib/maple_tree.c b/lib/maple_tree.c >index 4b423330d83c..f5a12d37b352 100644 >--- a/lib/maple_tree.c >+++ b/lib/maple_tree.c >@@ -4252,14 +4252,7 @@ static inline void mas_wr_store_type(struct ma_wr_state *wr_mas) > return; > } > >- if (mte_is_root(mas->node) || (new_end >= mt_min_slots[wr_mas->type]) || >- (mas->mas_flags & MA_STATE_BULK)) { >- mas->store_type = wr_node_store; >- return; >- } >- >- mas->store_type = wr_invalid; >- MAS_WARN_ON(mas, 1); If my understanding is correct, here is the only place we assign wr_invalid. So maybe we can remove this definition? >+ mas->store_type = wr_node_store; > } > > /** >-- >2.43.0 -- Wei Yang Help you, Help me