From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C65BCEDDA3 for ; Wed, 9 Oct 2024 23:54:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD7516B0083; Wed, 9 Oct 2024 19:54:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D60576B0085; Wed, 9 Oct 2024 19:54:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD96C6B0088; Wed, 9 Oct 2024 19:54:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9C5526B0083 for ; Wed, 9 Oct 2024 19:54:01 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BC72380372 for ; Wed, 9 Oct 2024 23:53:58 +0000 (UTC) X-FDA: 82655719482.11.991B868 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by imf14.hostedemail.com (Postfix) with ESMTP id B4B6410000C for ; Wed, 9 Oct 2024 23:53:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=foc+DNAt; spf=pass (imf14.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.33 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728517902; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6ZwDMBVB87NFZSFlUIc6d+PSVcdqpsUoIYNN0kIMUVA=; b=4vmBMhfVEbVvZBduJBLda1bzVNGx7HNh+916MHYruapp+2ygG1S298OKu4NzoktC7XNGiT hgKqQURGX9iayZPa4kUDP6YQVxpMcFh/Icte2wpoMb2/rWneDtsyELRiLyvT7j6oqi8ryf z+J2H03cxRf/YBVALA2tAG8WZt8N9cw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728517902; a=rsa-sha256; cv=none; b=z3U1QsCjJLHLhmxrlQP1cqI1/SLZ8fSBrc/ICBL4Rox4l66CO9s7YOegxdz9VgX3RODKwI sEg72PeXjwswM4eqqmqWSHSpUgIFguOkWx9BtZeb7kElNKoYaxdrb5vXmaNaIJDGfxkaKz bG32PIcn3mmW0ySyiSlgDbbp6tyVCCw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=foc+DNAt; spf=pass (imf14.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.33 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20241009235353epoutp0392e9038a10307c09528c0a37596e2c63~87f5iD6hE0362703627epoutp03V for ; Wed, 9 Oct 2024 23:53:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20241009235353epoutp0392e9038a10307c09528c0a37596e2c63~87f5iD6hE0362703627epoutp03V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1728518033; bh=6ZwDMBVB87NFZSFlUIc6d+PSVcdqpsUoIYNN0kIMUVA=; h=To:Subject:Reply-To:From:In-Reply-To:Date:References:From; b=foc+DNAt6kjrOwSurZkwigTadLNEJd6vVFSA4hwF00qtm1SzWbrsBX4hqf92YPXe6 /P7TT8YoIeAOMSLC4z+wGwF3t7TUann1bDYj2LhRLEsK9mjV6Y3MW2uFoK4jl9m0LW i2oR4eqENInw0RriZ94UO3vNWyJzPmBH4uz7eXxU= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20241009235353epcas1p33c5fc79aca3f7116faf977c89e3eda6b~87f5Nh8ep1251212512epcas1p3U; Wed, 9 Oct 2024 23:53:53 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.38.240]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4XP8qP0q4fz4x9Q5; Wed, 9 Oct 2024 23:53:53 +0000 (GMT) X-AuditID: b6c32a39-5f9f8700000024b6-90-670717903816 Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id 50.AC.09398.09717076; Thu, 10 Oct 2024 08:53:53 +0900 (KST) To: undisclosed-recipients:; Mime-Version: 1.0 Subject: RE: [PATCH] vmscan: add a vmscan event for reclaim_pages Reply-To: jaewon31.kim@samsung.com From: Jaewon Kim X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <20241009134900.7cd8fe9000a9fafd7ca1c592@linux-foundation.org> X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20241009235352epcms1p681f02f15b1278e8cd5364a211de0d68b@epcms1p6> Date: Thu, 10 Oct 2024 08:53:52 +0900 X-CMS-MailID: 20241009235352epcms1p681f02f15b1278e8cd5364a211de0d68b Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" CMS-TYPE: 101P X-CPGSPASS: Y X-CPGSPASS: Y X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDJsWRmVeSWpSXmKPExsWy7bCmru5EcfZ0g08vmCzmrF/DZvHykKZF 9+aZjBZN+2ayW1zeNYfN4t6a/6wWy76+Z7c4/PUNk8Xsxj5GB06PnbPusnss2FTqsWlVJ5vH pk+T2D1OzPjN4tG3ZRWjx5kFR9g9Pm+SC+CIyrbJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUz MNQ1tLQwV1LIS8xNtVVy8QnQdcvMAbpOSaEsMacUKBSQWFyspG9nU5RfWpKqkJFfXGKrlFqQ klNgVqBXnJhbXJqXrpeXWmJlaGBgZApUmJCdcWz5dNaCt1wVO9dOZm5gfM3RxcjJISFgIvHk Yx9rFyMXh5DADkaJ+a/nsYEkRARkJObOfgyU4ODgFRCU+LtDGCQsLOAoca/1C1iJkICSxNkf V9gh4roSTd2rWUBsNgFtifcLJrFCzOeVmNH+lAXClpbYvnwrI4jNKeAt0TX1FRtEXFTi5uq3 7DD2+2PzGSFsEYnWe2eZIWxBiQc/dzPCzPlz/DlUb7HEss4HTBB2jcSKc6ug4uYSDW9Xgtm8 Ar4SF3++ZwN5hUVAVaJvNx9EiYvElE8bwMYzC8hLbH87hxmkhFlAU2L9Ln2IMJ/Eu689cJ80 bPzNjo29Y94TqAvUJFqefYWql5H4++8ZOAAlBDwkXq9MhgTyCUaJibe+s05gVJiFCNtZSI6Y hXDEAkbmVYxiqQXFuempxYYFpvCoTc7P3cQITqZaljsYp7/9oHeIkYmD8RCjBAezkgiv7kLW dCHelMTKqtSi/Pii0pzU4kOMpkDfT2SWEk3OB6bzvJJ4QxNLAxMzIxMLY0tjMyVx3jNXylKF BNITS1KzU1MLUotg+pg4OKUamHQcS/9Pjnv1So6l47jifZsv5Y+t/q443M/zIWqTeGDhsuK0 894tWawdnUsvTU/ev/OFzp8PxcI6x/lPLD0jlH7+V+rDDTVSjW5PZq9OkrWUUc0y/KLJGPIg b9ahcM65h0zvfb95/Gr0E/d2ycKM+9oa0xK2enF/naAok/V1DY9THuMeyXsBX3auaK65aLdh WWV05co0E+nrMpsuNbx8oth/Rd1qtU5Z/9aijyt1+RK99265ef3SxIhWtrWxC95ZiS902NMk +MdAvdZJccnxizHC67hEuy1dQk+x/1JbZfTjyLOvS3/s2cTMmM1X9ahYqiFx6dypizvfrT2c k278sIZzW/H/iR3B77c+W8Nc/lWJpTgj0VCLuag4EQALbN/LLwQAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20241009093133epcas1p39b770ebcc6d2d78cad2f9a522bc6f179 References: <20241009134900.7cd8fe9000a9fafd7ca1c592@linux-foundation.org> <20241009093124.3647359-1-jaewon31.kim@samsung.com> X-Rspamd-Queue-Id: B4B6410000C X-Stat-Signature: dq7ns1e61oa61h5fd9f118ubndaspc4n X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728518036-99493 X-HE-Meta: U2FsdGVkX1/Y+Mz2sFkK4/5p3OKu12hYzPgyyU/9muAACDMDEOEjqyEsGtfquAJVHyg6Wn3ybU65uuZBqh3Ap+GHSQ8RBQk6az36O1Nq8CugBbN5UxUUtVWhtS7CVa957NOm2PsZMvaoION23QYNhzic4R99MgvhnhJII+ocyX6Tlx8QJm5+7KZcxhORBwoT7+8obXqOsmiibdUCGG7WWJaxde2ccYHLvu/SrcKfxsfDI4qvMgltwQbgfUa0xN0F8chxBr9f1lAnVzIJKdswL+zq79rH33NDDimxvceXotbBz/8orbX2Ihf7iGXJDmWq+08Sas4iIlheZnj5z1GyrTkwMR0U+8MpRX8uIzFzwEahk4vn9zYkOxlKIJ23rfPNzipwYeaSFsi0QCvoBaxf8sk/XQVx6uzoIbQbMFP+yjeQ8T3kVYc27Kku7kVOlTrbFfx06SstBEeQI/P4oYYhI1ophjj5tM5mNBbjn7C/Scems7iPbVATi10a4E2LgtEAvFG/qugTXmonZ265fjDL0oUAKC9ketC7i+AS3c8fi8IzRPzVTObXPC3ElmxO/HWg7wqG5M7iOe1oeYKuFze9XriR1ozYAyxoLPJ7M4BrDza1BNH5MdcLqQe5cOFL2MIMez+QNPyODjQDF/WM9/T4+pmOIVvMzvxqOudcXRnN3FsTXrWpHUcurChFOP7h/iauEOSNtjKmv+gbwXaA1ZDe7cBNeCYzr4x2EsnrE0C4XYUOmA+QIE1LicwCHB8AxPB3C9TFnYy6l0jDSpiU8FFcxVsHeDIPs4TJ0sztEoqNWRuapp3eHE/azX9236wNwY3gZSX21lqZXtMKfJ3BZyvLHY+/80NqjCuWe1phmcYeyirRZ7kDwT4762GqfMgHVwC1/t995Jc6kO/9g3wfHdycmT+sddExBIAPR6QdDFeDpLskO/o5f3e7Rutj9juLkITK4vfeCXmM5YXtfOL/Kzm hMthHTl+ C9N+nXltGzi3FZcNX5hMzqg7DBmpTTzszoic/W/aUpXCcvaVeZYGicR0+QAcH7fODe9IwPPX9HLzLLJ0ocEVoXg80t5RDMAh1ZZZ5UE7B5anrjnY9cVUZcBS9V1H3Vcdd7EPD01cDuXzcsQEugxYI8FrMh20jWVpZmpfKryMDjs/CfkyBgL6BcvaQ9FGjrAKSjwVGqdDi+zMAy0YYAHE+Iejo79JQJDzMqqkVxJEtBkK0VpvGpfAHw50eHHBAYVX5WJ3wFyYZC/7nFhHmgefxd6UaECVK/2yXI8Mq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > >> The reclaim_folio_list uses a dummy reclaim_stat and is not being >> used. To know the memory stat, add a new trace event. This is useful how >> how many pages are not reclaimed or why. >> >> This is an example. >> mm_vmscan_reclaim_pages: nr_scanned=17 nr_reclaimed=17 nr_dirty=0 nr_writeback=0 nr_congested=0 nr_immediate=0 nr_activate_anon=0 nr_activate_file=0 nr_ref_keep=0 nr_unmap_fail=0 >> >> Currenlty reclaim_folio_list is only called by reclaim_pages, and >> reclaim_pages is used by damon and madvise. In the latest Android, >> reclaim_pages is also used by shmem to reclaim all pages in a >> address_space. >> > >This looks like it will add some overhead when tracing has been >enabled. Has this been measured and is it significant? Hi Thank you for your comment. Regarding the overhead, I think the new function reclaim_stat_add seems to make us feel overhead. I wanted to sum and print it once but I think I can remove the sum, and put the new trace_mm_vmscan_reclaim_pages into reclaim_folio_list to show stat for each node. > >Also, we're adding a significant amount of code for a simple trace >record. Do others think this is justifiable? The mm_vmscan_reclaim_pages I added is similar to the mm_vmscan_lru_shrink_inactive. If allowed, I think we can use DEFINE_EVENT for both trace events. Let me think more. Jaewon Kim