From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52FB4CEDDA4 for ; Wed, 9 Oct 2024 15:20:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8B278D0002; Wed, 9 Oct 2024 11:20:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D39D98D0001; Wed, 9 Oct 2024 11:20:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB4A58D0002; Wed, 9 Oct 2024 11:20:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9BE168D0001 for ; Wed, 9 Oct 2024 11:20:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2C8A41416DD for ; Wed, 9 Oct 2024 15:20:39 +0000 (UTC) X-FDA: 82654425882.01.AB9B765 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 783E01C0011 for ; Wed, 9 Oct 2024 15:20:38 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lm31+UCs; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NkTzABFx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bO1iP7Pg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/2IkfBLb"; dmarc=none; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728487211; a=rsa-sha256; cv=none; b=w4KxLn45cdiEgjR4rByXcKv1chYuqiSfWEE8JNksBxPPKQXzefjmzWcBPDW1VykENub7nx ZTea7UvwD91s2KpaKvczbnnQUpyCmd4Cei4wH/OaM6Zke59iKaJDqql6JpayRAgFIutMde P9RShbZIiXbSyjIrooBOH8WHYbz3pYU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lm31+UCs; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NkTzABFx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bO1iP7Pg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/2IkfBLb"; dmarc=none; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728487211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fo49WiSuG4sCrNKiK7epakneXryhlOqOWg2rfR6y4QM=; b=hS6EmUQed344MRnsDbMZRoA8CpDqzdPxK8mg5O6FSPTxdAx/E1nSNUoZiaiEUWEJyCMLah KWYKCAAzl0XbTp/YQww+QTjgq7A/AQL6VtqDGOaF6bZ2eB+QCZ13sS6cRNStJyon6ac/+l L5TAC+4J3c1BA70ZhLqecLa+TWCA6a4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A704021E95; Wed, 9 Oct 2024 15:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728487236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fo49WiSuG4sCrNKiK7epakneXryhlOqOWg2rfR6y4QM=; b=lm31+UCs8WiVSd9Yz1J4qR15NZmjejLPZpxLmG1snj2OxoJ6puP9kAkr40zCiPvsOdhoy4 Nenwu7oNjIBMbZOfWIOB2L9522SZ+TZEnhMGA0RXFnlKhHoYkwByO3IAEZWG4Q9jO9zsV8 TbQ4zX1RIJYVg4dr6k7xZavIE0LPv+o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728487236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fo49WiSuG4sCrNKiK7epakneXryhlOqOWg2rfR6y4QM=; b=NkTzABFxMLvbyceEfWppx0kZjoyp4JGq0im7v5G9Z3T4rmi9ZZuQ7s6q58mYLw16cueWhL O71qZmQdH7/HSMAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728487235; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fo49WiSuG4sCrNKiK7epakneXryhlOqOWg2rfR6y4QM=; b=bO1iP7PglAqwn/zSFWDlyQlwfCktWTI+5npTLXFpMEKBkqPQ5cDz61yjy/7G0a5E/IvSvh Kntnq4n0rugINGqoiduoUUgUTjfVJDFLD+PpUoipPd+0zJdEdYeoF/pXvNE8h3LetK+C94 pXZgLLy0yxTFlh2Bb3W5N0b39rLd/jQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728487235; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fo49WiSuG4sCrNKiK7epakneXryhlOqOWg2rfR6y4QM=; b=/2IkfBLbUv6CtoZSGlQXFUmV/rnKDxLKzCV76UqZs3ly9CiJMLWv9CwTuKPSKHRJo7fen4 O0kjlspb6FTkk8CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 99E6B13A58; Wed, 9 Oct 2024 15:20:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id t6GQJUOfBmfNVQAAD6G6ig (envelope-from ); Wed, 09 Oct 2024 15:20:35 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 43CD1A0896; Wed, 9 Oct 2024 17:20:35 +0200 (CEST) Date: Wed, 9 Oct 2024 17:20:35 +0200 From: Jan Kara To: Tang Yizhou Cc: jack@suse.cz, hch@infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm/page-writeback.c: Update comment for BANDWIDTH_INTERVAL Message-ID: <20241009152035.cwkzs2ryy2fdrs2h@quack3> References: <20241009151728.300477-1-yizhou.tang@shopee.com> <20241009151728.300477-2-yizhou.tang@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241009151728.300477-2-yizhou.tang@shopee.com> X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: xmtz6rs7df1y8kqbtjbd87137hsmcdz7 X-Rspamd-Queue-Id: 783E01C0011 X-Rspamd-Server: rspam02 X-HE-Tag: 1728487238-652149 X-HE-Meta: U2FsdGVkX19j7KjVXSOuuxn9+mUqJ8BYNb44jcejFq/7QylsMWpqfAx27+nkp4UiYUWjY0A8rU3212Rm83ahtPuyRV0Yl5aqF4jQAK3/NP9fEMKvQJE/YxyOQ7YHkMWNR/+lSIQ0pGwBqmokEVvChNKDIwn4tJH1Z5kw/NvWHNc0bT10z5wayRdNnad/lxt+ZDkEMnz0r6pqJMT1u0FvUh9CERO+hDrrKqq7gisuQTKwfITSQpaCUpcutm7BHLIuZdEfxhnNE8JSGQx5L9PvJ7GSxEvRTTP3frVaCDVph6wIHQYmnFwaTqvyqcVcPZFDgrNmC/iArsuwpw2aBWwkDilKOJ0TuLGNeUFUv4gGn8nXS8JQZg8hkErEhNWIMfY2X2PA1QvsbUMhu/eX9m+Vt6vwS9KsUSphcZAYWk4j2Idc0z2hNl1d6GRQ+3RMGSpP5/a5+kLxnH0rzqxWpvEjQ5dYbP1wpWafTA407iO10MDW3OcV8S8GKVn82rkQVuYW7OXM0wuV9TU9JkBxGxQgYB4zGB+7AHbFg1V8dlYZu8WXeWNJeNcyJx7pDhoD/whvN8fthhlMPtD1Li34yOmr0UQHF0QwfQjrszEZACYjBYk/R151M2VQETyOXGWlrLU2Dhg6ZQ55dyzLrBVg75VvaUbWz+ocmp87ONa2P0Ec7w+uvksj+t0BusOGAqxCmH7b4AZRxe6clfWT36loQGQsOr1zYb1NQSNTm5OUucQyrjla4rBW+36ywvhJSywSgIRgCAcoi6sMJ/RPWgjSlXfGZ7Jz/U6c8G7MP+Y8NNgYQkPHm4Bd7CmZAUAiNdRbY+63c3XWbByvqw7hRUm6DPYzXGwlo5v5hmKpAmO5l+173OqcSQndGsLeNaUmPvXmBv5J8ex9lJp0Lg22t7wnwCVdOi4Lv/xZE2w4gGbbF3HKyE9p0mN3L+xh2zTDCPTJ2vifuLkW0USiWZVRghogfLM eAngGsZl kY5j5aiovDj9PzvmRWlv+F0NriYQ3Ga1ESnBVNBqYf4Ict7y8QisGgi2NAKBtE0vTW5cxHkReuyFWQoODPRm6+C7Uh2RB85cBT0j6VZp3R59qCSpHXSfH9HyTQgSqZ4xXiwoW+rC7JelTonZ6BwkRzO+DOLfsO9yFVGLjBV35xyOwxeRfvruUIVqkdVs61EZB7tO7OWCLutZlpYYXmD4NcQ/3in1tVAF+/NkfxqDr0yD+2tidmx+L9lJ88/YQczGWJHOxu7PllJggEEl+zFu1AWhQtTPIVLY9ttpp9ObBAto505qyMVzUSge1BbOLO1AsNLovFYJzv/fFVW8e1+cz4yNBvF67J4Ivs/r2joIbqgSOgws7pUwURansUkY+anZwOQxmI1TUGAadFco7mUVIsxqwsIqkTedmVkbsLTv+h84Vrm3CvJKA8D03DU92vds/fkmJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 09-10-24 23:17:27, Tang Yizhou wrote: > From: Tang Yizhou > > The name of the BANDWIDTH_INTERVAL macro is misleading, as it is not > only used in the bandwidth update functions wb_update_bandwidth() and > __wb_update_bandwidth(), but also in the dirty limit update function > domain_update_dirty_limit(). > > Currently, we haven't found an ideal name, so update the comment only. > > Signed-off-by: Tang Yizhou Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index fcd4c1439cb9..c7c6b58a8461 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -54,7 +54,7 @@ > #define DIRTY_POLL_THRESH (128 >> (PAGE_SHIFT - 10)) > > /* > - * Estimate write bandwidth at 200ms intervals. > + * Estimate write bandwidth or update dirty limit at 200ms intervals. > */ > #define BANDWIDTH_INTERVAL max(HZ/5, 1) > > -- > 2.25.1 > -- Jan Kara SUSE Labs, CR