Re: [PATCH v3 0/2] Cleanup some writeback codes

Re: [PATCH v3 0/2] Cleanup some writeback codes

[Christian Brauner]

On Wed, 09 Oct 2024 23:17:26 +0800, Tang Yizhou wrote:
> From: Tang Yizhou <yizhou.tang@shopee.com>
> 
> v3:
> PATCH #1: We haven't found an ideal name for BANDWIDTH_INTERVAL, so update
> the comment only.
> 
> Remove PATCH #3 about XFS.
> 
> [...]

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/2] mm/page-writeback.c: Update comment for BANDWIDTH_INTERVAL
      https://git.kernel.org/vfs/vfs/c/d91c6efe8161
[2/2] mm/page-writeback.c: Fix comment of wb_domain_writeout_add()
      https://git.kernel.org/vfs/vfs/c/3cb5827bfa43

[PATCH v3 0/2] Cleanup some writeback codes

[Tang Yizhou]

From: Tang Yizhou <yizhou.tang@shopee.com>

v3:
PATCH #1: We haven't found an ideal name for BANDWIDTH_INTERVAL, so update
the comment only.

Remove PATCH #3 about XFS.

Tang Yizhou (2):
  mm/page-writeback.c: Update comment for BANDWIDTH_INTERVAL
  mm/page-writeback.c: Fix comment of wb_domain_writeout_add()

 mm/page-writeback.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1

[PATCH v3 1/2] mm/page-writeback.c: Update comment for BANDWIDTH_INTERVAL

[Tang Yizhou]

From: Tang Yizhou <yizhou.tang@shopee.com>

The name of the BANDWIDTH_INTERVAL macro is misleading, as it is not
only used in the bandwidth update functions wb_update_bandwidth() and
__wb_update_bandwidth(), but also in the dirty limit update function
domain_update_dirty_limit().

Currently, we haven't found an ideal name, so update the comment only.

Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
---
 mm/page-writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index fcd4c1439cb9..c7c6b58a8461 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -54,7 +54,7 @@
 #define DIRTY_POLL_THRESH	(128 >> (PAGE_SHIFT - 10))
 
 /*
- * Estimate write bandwidth at 200ms intervals.
+ * Estimate write bandwidth or update dirty limit at 200ms intervals.
  */
 #define BANDWIDTH_INTERVAL	max(HZ/5, 1)
 
-- 
2.25.1

[PATCH v3 2/2] mm/page-writeback.c: Fix comment of wb_domain_writeout_add()

[Tang Yizhou]

From: Tang Yizhou <yizhou.tang@shopee.com>

__bdi_writeout_inc() has undergone multiple renamings, but the comment
within the function body have not been updated accordingly. Update it
to reflect the latest wb_domain_writeout_add().

Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 mm/page-writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index c7c6b58a8461..72a5d8836425 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -586,7 +586,7 @@ static void wb_domain_writeout_add(struct wb_domain *dom,
 	/* First event after period switching was turned off? */
 	if (unlikely(!dom->period_time)) {
 		/*
-		 * We can race with other __bdi_writeout_inc calls here but
+		 * We can race with other wb_domain_writeout_add calls here but
 		 * it does not cause any harm since the resulting time when
 		 * timer will fire and what is in writeout_period_time will be
 		 * roughly the same.
-- 
2.25.1

Re: [PATCH v3 1/2] mm/page-writeback.c: Update comment for BANDWIDTH_INTERVAL

[Jan Kara]

On Wed 09-10-24 23:17:27, Tang Yizhou wrote:
> From: Tang Yizhou <yizhou.tang@shopee.com>
> 
> The name of the BANDWIDTH_INTERVAL macro is misleading, as it is not
> only used in the bandwidth update functions wb_update_bandwidth() and
> __wb_update_bandwidth(), but also in the dirty limit update function
> domain_update_dirty_limit().
> 
> Currently, we haven't found an ideal name, so update the comment only.
> 
> Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  mm/page-writeback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index fcd4c1439cb9..c7c6b58a8461 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -54,7 +54,7 @@
>  #define DIRTY_POLL_THRESH	(128 >> (PAGE_SHIFT - 10))
>  
>  /*
> - * Estimate write bandwidth at 200ms intervals.
> + * Estimate write bandwidth or update dirty limit at 200ms intervals.
>   */
>  #define BANDWIDTH_INTERVAL	max(HZ/5, 1)
>  
> -- 
> 2.25.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR