From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D667CEDD9E for ; Wed, 9 Oct 2024 14:43:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22D196B00C3; Wed, 9 Oct 2024 10:43:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B6596B00C4; Wed, 9 Oct 2024 10:43:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0575F6B00C5; Wed, 9 Oct 2024 10:43:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DBE206B00C3 for ; Wed, 9 Oct 2024 10:43:13 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 61B891616A5 for ; Wed, 9 Oct 2024 14:43:11 +0000 (UTC) X-FDA: 82654331466.06.3E72EAA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id C779F40015 for ; Wed, 9 Oct 2024 14:43:11 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AxAi7gMo; spf=pass (imf01.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728484855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hVSeVulzIXxFAOaQHQc1C9HduC6nzFi7yi14/OzxfWI=; b=erL3UTkOgdZYi2mNPa0IgaLY9Z82MqD+1Agjd/xegN2aHDggvxGSRweYfvd0mg8XMjN5ww VtQ7jov79y1Awi9ZM7RgxuGCmYcziBkQkcTXb2QtByXIA6vdYRiOUTqFFGQqS3K/LRmU6Y Hzj9jHzrfNVBccmkYxRt6AW93AW19R0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728484855; a=rsa-sha256; cv=none; b=JfCdavYm2dyqoXLKChSn9JeJgS1rhZ/UcPBlWZPOJXf2ypGyxVtgBeG2zmpkoU9t7yYhe0 TiQZNJntwbYI8qS35zyAN60X7pwv8QG/C209UxUCSLeD6R9xT8XY1tHPoN+YfdmwMMQWbS 2gdi7S5jqZY1wxuCA/03N8Cx63ZcItE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AxAi7gMo; spf=pass (imf01.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7744F5C059E; Wed, 9 Oct 2024 14:43:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56DCBC4CEC3; Wed, 9 Oct 2024 14:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728484990; bh=ghDXhJ8N/Fq5uvX13sqCHmKOKO+si/SzPYqkee2gkCU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AxAi7gMooCiJGqGzS0LWH7kBxoZwHJn5xIZ5q0R7f2JFhjQ8vFEszC3neoypcep6A T04nDesXSfu08Vf9+sA3K4h/yiH8T7lKmbtsmltNb0rLX7hIshVw4gzVgAfVGilHON T0lVRGhKcASYRRGMfUFMkMr67ctpsruVmTf/b0/87df+LAofBUCNmmbLqvjK7vPZ2k kspRbAd1hTXLUznLCT2elteYkVFC35t8ffslqZHPDDQVxJc3HWCIAs7chSvJU/deEg YmHhdQwxG3GwSOPLrsvvcQZQ+tHMwtBNb7AHKPREGF1DC1YOwPzF+LLL9SFcA8W16M a061/KbZx2orA== Date: Wed, 9 Oct 2024 15:43:02 +0100 From: Will Deacon To: Kevin Brodsky Cc: Joey Gouly , linux-arm-kernel@lists.infradead.org, nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, anshuman.khandual@arm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, skhan@linuxfoundation.org, szabolcs.nagy@arm.com, tglx@linutronix.de, x86@kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 19/30] arm64: add POE signal support Message-ID: <20241009144301.GA12453@willie-the-truck> References: <20240822151113.1479789-1-joey.gouly@arm.com> <20240822151113.1479789-20-joey.gouly@arm.com> <47e1537f-5b60-4541-aed1-a20e804c137d@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47e1537f-5b60-4541-aed1-a20e804c137d@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C779F40015 X-Stat-Signature: wo51mo4k4nsos8hkp8h7uuja4km4mwf1 X-HE-Tag: 1728484991-511323 X-HE-Meta: U2FsdGVkX1/WyDyJ+I2cdwF7mwPUN9hN/Q61274JKpbMB3JeUmvi2gbwn2reOEaQkWe4hbRLq6JA5NKVSJvK0UzF9XKNnKwX7KD10sDBfoSlzqnBvaosW2/W46/dNA5lQ2n1e6qvlAdsfawZ1nDSRFR7J6UzQ3w5ixoXMrtTEo6H03jm/UNkt9RiGg1r7kvar3AjirRwBo/M+Hb9dJJ0U8lvocazcmXSoGy1iJ6hXmsBvaASP7uq/ZvJwv1AacRoCUoJajxJemXDfi7Gu2n2u5fKJ+1UfU56tXo2pJNVYiLiK/ZKNxGalJ4VFce2ZyUHU/VJ4FTBDK5XUqgdIzP6QxZgF6sTfr8ETtS/KP2fzTtxCP3AyQMDhCqRyLwOps5HnNfpALDLQw5Bn9CPHT/ozCrOqux7KESpi0GB4qIwC1cgEfr5vcqgrxd3/wnl9Lj0TB2+7vOeNxOeNXZ1UuFO8YF/iP0WMUQbaGnXzMmzfFr+UOH9bV76NKJ8WULByKDqLT9U0ttPquJU5rHw0LI7akcXkUZUG9CgyKFXMEAZjBy1q5dU/J6MYvj++VVBhsPHNiA7KW0VvSnT6VB8TW1iZ4Fe97Wxr+vmSw+QCdnwNZn66rfSTbs5aR6J+pkDBmMX84Zhe+0ko1n2kKVNOfWuT9RcYYwbDbVW7/dm24BwrGP2GFL+AQud/axJTfS0Jt1YeAjTlNE9xeuZxiP70f7uUf5FAolPbcsJwp7y189TOftpJuHl7wtCl2eeNbZQLWV2g+vOc/DQIHb8PgkM19TZFQMxryiwLarEOgYYDMQIMOI0ntoiuTRFy193PezHlDPeo4b4Tc5X60u3QJelCdAWdmfFCkCGROptBz8tXfNuuGmFDFbJ0iSNLU2G41n5f9PU+vTWbjL7CAlsULZ1C/jDDxvPTNYPtiJO6N1ODmeXCEUPEf41mZwWk5xVPgq4OX5tAnRQJiY3LfB9y0mqAJd DQj4bTMz bKnu3DU6ZAeK18NRt79JCX3Dt+l3bFxphnQO4w2OvHJHKgXTvAr1HWzf8j5pZD4J6MEJN1XLdsA3uuVra6bc6/2wrSNLInB9zrqEOqpKueBolk8+rb6kfSEkgloXfJQ61eIwVBExGGBhSGg3AoyR5A3fCNeaKXMZ9WWQF7ML+Zxvx0iwpx5HhIXTtmNa1MitfJOcvUaBjmMB4LYeE3gDGO8gFti7nOc9edKoS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kevin, On Tue, Sep 24, 2024 at 01:27:58PM +0200, Kevin Brodsky wrote: > On 22/08/2024 17:11, Joey Gouly wrote: > > @@ -1178,6 +1237,9 @@ static void setup_return(struct pt_regs *regs, struct k_sigaction *ka, > > sme_smstop(); > > } > > > > + if (system_supports_poe()) > > + write_sysreg_s(POR_EL0_INIT, SYS_POR_EL0); > > At the point where setup_return() is called, the signal frame has > already been written to the user stack. In other words, we write to the > user stack first, and then reset POR_EL0. This may be problematic, > especially if we are using the alternate signal stack, which the > interrupted POR_EL0 may not grant access to. In that situation uaccess > will fail and we'll end up with a SIGSEGV. > > This issue has already been discussed on the x86 side, and as it happens > patches to reset PKRU early [1] have just landed. I don't think this is > a blocker for getting this series landed, but we should try and align > with x86. If there's no objection, I'm planning to work on a counterpart > to the x86 series (resetting POR_EL0 early during signal delivery). Did you get a chance to work on that? It would be great to land the fixes for 6.12, if possible, so that the first kernel release with POE support doesn't land with known issues. Cheers, Will