From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11BA7CEE34C for ; Wed, 9 Oct 2024 21:08:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71CCF6B0093; Wed, 9 Oct 2024 17:08:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CDA96B0098; Wed, 9 Oct 2024 17:08:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 594C96B0099; Wed, 9 Oct 2024 17:08:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 374636B0093 for ; Wed, 9 Oct 2024 17:08:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 33F571218B8 for ; Wed, 9 Oct 2024 21:08:24 +0000 (UTC) X-FDA: 82655302212.12.32FB6CF Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf18.hostedemail.com (Postfix) with ESMTP id F0FF21C0005 for ; Wed, 9 Oct 2024 21:08:24 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=POkOiRiE; dmarc=none; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728507993; a=rsa-sha256; cv=none; b=7WygApcGqKNsPqIFeGr+pqT31SESOPw4r8IcuRfbjEL8IPtQmGhzhWoPtwlton5L88JzDi Nq0RioPghWs3XpmNuwpBZMvHV5GrPekMOqwK25dlzZkmuXNMOcLWgWTp61fnC/h5ort73N lrUtUXBjqtqbvI0/svvNNLfxDcny1pI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=POkOiRiE; dmarc=none; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728507993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DV40A8kdCOUT025WDy9Zlt2AqqdDDMMCLgg4HGkUGgE=; b=mrXUXaNCepXw9c8V1WItmuCmbsgxX2IrYJljv3DFZ256opL7ObAMvb59YRrzlVVr9v6SOM LZRp8hG7CeKAqyblWVe7Bl7MYj7ABF0s18ZT/TMp6XQhml6VIxSzTa6H6+zPJxwJCJO8Q2 cSbVtdaZP4BxJE/XxX4uNFBJKNsnQA4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7CD80A41DE1; Wed, 9 Oct 2024 21:08:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4439FC4CEC3; Wed, 9 Oct 2024 21:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1728508103; bh=U7TqRRHty20VoO6nL6y+RwxqEmfTzgcg5lfdBgfAfGI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=POkOiRiEWJzuYqxdCw2+wcxgrHEgTMtvy0ldlVa/ja86aQgOsOysob5Z12hlD1xQo 3Zmm/93gUHdLijTIXqy8fYcxY2Aik8qSLPPvTH4z0pn5KoeVWQni16NonVdtq3UZYI XhWqVG4stAM9ZoMTDVGYG72VdEEoE4piiFYfVFmQ= Date: Wed, 9 Oct 2024 14:08:22 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: kernel test robot , Jann Horn , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Hugh Dickins , Oleg Nesterov , Michal Hocko , Helge Deller , Vlastimil Babka , Ben Hutchings , Willy Tarreau , Rik van Riel , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: Enforce a minimal stack gap even against inaccessible VMAs Message-Id: <20241009140822.0628a4d09312cbc19d73c6e4@linux-foundation.org> In-Reply-To: References: <20241008-stack-gap-inaccessible-v1-1-848d4d891f21@google.com> <202410090632.brLG8w0b-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F0FF21C0005 X-Stat-Signature: mi9xc56d36rtr7iubuoipoxxt47rqjzr X-Rspam-User: X-HE-Tag: 1728508104-682376 X-HE-Meta: U2FsdGVkX19waF70ocYMwlDRyjDwJIKMx5l9vrHhV5v7Q3UXC2ZZYRg/dGoCtxUxxjbwISPRs8lJ2oaWhtX/V3lQF4/n0ON+6qq6Dgt7HHM//OHvZsoC/ehZEpPRseflL1hed+31gRWxO+JDjXVdFwe82+1CcuOySy/0HD0zfcNfRalmVDuH6J0CRGfmlSbZyK3+AMe1fYgmFfsU7HsUCSSkZmsPvWOVpnZCWzWJWFqs0Taz49BgrcVrIBBie1leOY1DPmKhIJc06ArVd/Ep7xSpwK1+IWdedeE/lwCB0DfKRKOgNJuxq+MIhiH1GC7bkCOFcnRhIBqRpyvXtXkUtCHFLPFLDBWYYOV3OgmzN4xrYEShlTcWnIZ8yqwAQvJdeChzS5mFA4EOCqoKhbmiojiiRFBlWmonrW7xCialqqYjg1KnvYdWiTW36tODKnjGZeZ0hoNsS0zJzffdstWsgoftDk0WSUVDx6c7GA5fmQFuhYRtUU9d+QN6Ls6drn4GtWra7symAemSfA8wLo7MWvc76Hjjj4Un1KpKD1YWHj7/7dOoYfIvCoXwqOyb9MvnqFetnjHZzarqkcIL6T/yIHNTaazimOmq7U5FrsFh+DOehnSSWMhZdwOIq/qfNbJbYoBPvVxfv1GfDC2WZ2zI+9HJO6/u42xkbTs87Ea1gWZawDB6MaAXIkYLtGgwlotYoGlKhHLGWIm+jklHGW4GGyoviULzN5cirHP7lJklPXUFryhnB3bhpm7PVMkPuU0bfVqpzUXfw0HM4sx3B9DXSnNnV1ikyehC7bo/Lp2lUQfi3P7OlgMMtM4tCGe3FtsTXm+sChZvm/1elBMU466OAJunHaXzYkGPQjkk+lHsBT09bLgovYE/Qm4XM8PHqqLr+AtssXVnUE7PYGaNHHLQmNaJ5P6ZcMEEHtAAvzncdihUHskksKSbD2+QbjTwc/U2JS1+zUkODNIWBm45iDh 7AbCp1tn LV9cQUNdzwPIUq9K4SpEIHnndCgQKFbvKCJpIeGpn9SZP35D0Zw88U2d2dU0VRPlapzjMQeR4JomTWi8F0leBdxnufQOAHExrtweYbtwrYyK6RdH+5XkS16Z59uzvkQ3fbgKP8U/sR3s9gafPxSCnIzdtFrXZl3CZqlR4/QmJE7/gVuzYeolRwL0rTRMuBnTJ+EOQnMrC086yXJNBayHRdUTj1KYzNX2qL39MnFe76hicni23rT7D2JFB4R9j/sGrSL72pEuGN05GX0KOXgXnRK+vdw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 9 Oct 2024 15:53:50 +0100 Lorenzo Stoakes wrote: > > All errors (new ones prefixed by >>): > > > > mm/mmap.c: In function 'expand_upwards': > > >> mm/mmap.c:1069:39: error: 'prev' undeclared (first use in this function) > > 1069 | if (vma_is_accessible(prev)) > > Suspect this is just a simple typo and should be next rather than prev :>) Agree, I'll make that change. CONFIG_STACK_GROWSUP is only a parisc thing. That makes runtime testing difficult.