From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48902CFB43F for ; Mon, 7 Oct 2024 08:24:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4D3F6B00F0; Mon, 7 Oct 2024 04:24:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FDF66B00F1; Mon, 7 Oct 2024 04:24:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EB8C6B00F2; Mon, 7 Oct 2024 04:24:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6FAE26B00F0 for ; Mon, 7 Oct 2024 04:24:44 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CBC3DA094B for ; Mon, 7 Oct 2024 08:24:43 +0000 (UTC) X-FDA: 82646120046.13.49BC4DB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf03.hostedemail.com (Postfix) with ESMTP id 36E9520009 for ; Mon, 7 Oct 2024 08:24:41 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=nPUl42Tv; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728289347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=92rSkZkyrENyBMOC/6P9thGDF/nEJS05FTuOdUPjjaM=; b=oCO885vBVPJt7zOG28MY0eqiiuXYXipd0TclvDfDl3bXKaTpW7vklcflJXiLbbbjcWThvC ghezqo2ASfHs2smRVfw6yDoXHI840O+BFskOXPMGuabBK1Lj+/k/hH/TvAtKXjIilznKsc 2MdSI95EWPhh1KhDd4rZdGyUeNL/KIM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728289347; a=rsa-sha256; cv=none; b=PbOxsGo9v6/VHMaAcchkpiQzL08lUeBDvWCOYjP0RThwa0ePbdOMJcTRQaKbmZbXMAcgvh x3ARcGta+kdWux4MmMzJKc+M07tTPSOnbBEkRYN0xxy7N00P6Ji9irG3Ep/Su5jJzEmhSW Z1msoPHEcjNqutTEzEV2hcy+g/uBsKg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=nPUl42Tv; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D6853A4177D; Mon, 7 Oct 2024 08:24:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFF03C4CECF; Mon, 7 Oct 2024 08:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728289480; bh=/Fo2DjAvsIr3OHEbNLnOjnqG3h/3NfrKWkbkHLelb7Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nPUl42Tvh02I6DA1K6h0VfB2p2eLAJpgE8EcRiV2AVbQqIJabxzFb09GvY9oJzBMS Le8EhH1DNr2/3Hf8O/tU2zPVdtkerjwk6cItVxyM76TqvsiDhwP12Fvy1tNEFhTLaz 75M1aCCWTGalXKjkzuh5BhYj7KY8vSQmzr6uw2Is= Date: Mon, 7 Oct 2024 10:24:36 +0200 From: Greg KH To: Jeongjun Park Cc: akpm@linux-foundation.org, usama.anjum@collabora.com, peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: remove the newlines, which are added for unknown reasons and interfere with bug analysis Message-ID: <2024100748-exhume-overgrown-bf0d@gregkh> References: <20241007065307.4158-1-aha310510@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241007065307.4158-1-aha310510@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 36E9520009 X-Stat-Signature: ikpx8um7j4dmrnerxrzybdaom5qjjhqr X-HE-Tag: 1728289481-269330 X-HE-Meta: U2FsdGVkX18x0jOhoj5JueW7qBwdflUa6TXWhsQ7kBeYTHcEYL6lYdRxvNTd3cJhQnYaHMo4ITwW1gDr6UXM38vd05dF69A0ft+pCMDhvNAerwIJ661Yy44GJHprrv2Hheg+U2EbNPOi6EjDjazUHkTBhjK27fUiy5DTsZSScb+ZDe20zkm4opqmg69W1DB/JWpj6y7FwEc7ETC9oFcgkNwmvtzwd97mDPSHDhDWDPXdUGtKj54JGAutq6sVFVSloBOFMYdi9TO9wvQBQZN+BvtpJ7ZLpnh6Jbc2NAoNmACz4gQ1UQ7hqIhH9NZ1qwLF2uFhfm2zeGVod7XHkT0OSAgeBxcZtqO4MRbqQTjdXMqaIjc5Gickc9nHUHe2MhJP8ugsOBl6cUaH8NghAK/8a3YGb9DN50QQrekv6SfcXBofx1zgRugXZFZAI0FSqM5WVtb3Rz2ATgj7nFZqwRBRr22qus1CHwk33sGhRxXvSGEtUkJB2YEENF+OSx13EwSRw88ZoeFD55OtCZe4QxxwNDHAGrFZ+RwLujNurNN5EzunCPF2LOA13tHxue+edDMj3aMaHLlMSS6zjEvu7xiYR4d/vXinQWV+fjHoxdFUoslRxImiJCVatoYF+l3H2f9aMStSYf0f9eR+ETMUVw44CxyR3O3Aj+KQNn061gN0QRCLMKOt78qHDTlw/Y18bAhvpy90Et7o5rN1kISKBJH/qItv+ZuLoq9WWJ0oU8VzdabyqPpDYn5qakG905VO5GQqfXSifsx3OTsPkGfiDmRb1o2opLg+PZmUVzk84/RabKre9X1F07sPQmN7k/Mqm10P8LHiokOzWDURxwP9jVK5j95CBQ7RTpobLYyy9Gqprvj+TtGKUg/ut1ZscPHv+/Tma/FLuxOQGBhKiO3ZTbXb02jX7jw1RLnIcJqdiGCwd2CoUaCSxzvN1+OBBD6JC0BlpRupea21LhSMIQbH4K/ yfptWkGy KvHXdGvi69FvME6DLD2HM8Qd6bbjHH64ldafEdRz2M4Ll7VUqtG/WWW+PMJcYxvl3ElaEjTjWWZaplCoUsjtSej2HCu3kmN3kn4Emj8GbEHfp2Bp5UVtXFw64e6TbgmX2Dz6mSxV0yRv0qs21aIeQqZEGHKS3nIPUOi7BVUy4VdTZJwlrIvBwy1JN0Em0DwvjcqSQ16zYd57z0X7cAyqxilKJITpCrqcBad+MMZxJXjO1Kejru+NmC97kTdf7XXfNi8xsTE9Nq8he6ssNSF+8b0tDD8N7bAJ5thIo+8Rzw4bmm2d78Ue1L1s6UR88te+WnEFgzF8bHLPO5063/zMAXr/36UR3DvEvaScL4vWZD+0bAzSLHCHgPiUix/jcDPubjfoIt5o+KIZswnE0nWlI5o3ZFXyMpU++SKqOPW9Pr7RIpIc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 07, 2024 at 03:53:07PM +0900, Jeongjun Park wrote: > Looking at the source code links for mm/memory.c in the sample reports > in the syzbot report links [1]. > > it looks like the line numbers are designated as lines that have been > increased by 1. This may seem like a problem with syzkaller or the > addr2line program that assigns the line numbers, but there is no problem > with either of them. > > In the previous commit d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC"), > when modifying mm/memory.c, an unknown line break is added to the very first > line of the file. However, the git.kernel.org site displays the source code > with the added line break removed, so even though addr2line has assigned > the correct line number, it looks like the line number has increased by 1. > > This may seem like a trivial thing, but I think it would be appropriate > to remove all the newline characters added to the upstream and stable > versions, as they are not only incorrect in terms of code style but also > hinder bug analysis. > > [1] > > https://syzkaller.appspot.com/bug?extid=4145b11cdf925264bff4 > https://syzkaller.appspot.com/bug?extid=fa43f1b63e3aa6f66329 > https://syzkaller.appspot.com/bug?extid=890a1df7294175947697 > > Fixes: d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC") > Cc: stable@vger.kernel.org > Signed-off-by: Jeongjun Park > --- > mm/memory.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 2366578015ad..7dffe8749014 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1,4 +1,3 @@ > - This sounds like you have broken tools that can not handle an empty line in a file. Why not fix those? Also, your changelog text has trailing whitespace, ironic for a patch that does a whitespace cleanup :) thanks, greg k-h