From: Andrew Morton <akpm@linux-foundation.org>
To: Jingxiang Zeng <jingxiangzeng.cas@gmail.com>
Cc: linux-mm@kvack.org, kasong@tencent.com, linuszeng@tencent.com,
linux-kernel@vger.kernel.org, tjmercier@google.com,
weixugc@google.com, yuzhao@google.com, chrisl@kernel.org
Subject: Re: [RESEND][PATCH v4] mm/vmscan: wake up flushers conditionally to avoid cgroup OOM
Date: Mon, 7 Oct 2024 19:15:34 -0700 [thread overview]
Message-ID: <20241007191534.ceb663de5ac7ee3695a162a2@linux-foundation.org> (raw)
In-Reply-To: <20241008015635.2782751-1-jingxiangzeng.cas@gmail.com>
On Tue, 8 Oct 2024 09:56:35 +0800 Jingxiang Zeng <jingxiangzeng.cas@gmail.com> wrote:
> From: Jingxiang Zeng <linuszeng@tencent.com>
>
> Commit 14aa8b2d5c2e ("mm/mglru: don't sync disk for each aging cycle")
> removed the opportunity to wake up flushers during the MGLRU page
> reclamation process can lead to an increased likelihood of triggering OOM
> when encountering many dirty pages during reclamation on MGLRU.
>
> This leads to premature OOM if there are too many dirty pages in cgroup:
>
> ...
>
> The flusher wake up was removed to decrease SSD wearing, but if we are
> seeing all dirty folios at the tail of an LRU, not waking up the flusher
> could lead to thrashing easily. So wake it up when a mem cgroups is about
> to OOM due to dirty caches.
>
Thanks for persisting.
This patch has a somewhat difficult past and not a lot of review.
I'll await feedback from other MGLRU developers before proceeding.
next prev parent reply other threads:[~2024-10-08 2:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Jingxiang Zeng <linuszeng@tencent.com>
2024-09-13 8:44 ` [PATCH V2] mm/memcontrol: add per-memcg pgpgin/pswpin counter Jingxiang Zeng
2024-09-16 7:41 ` Andrew Morton
2024-09-21 7:51 ` jingxiang zeng
2024-10-11 20:01 ` Nhat Pham
2024-09-13 8:45 ` [PATCH V2] mm/vmscan: wake up flushers conditionally to avoid cgroup OOM Jingxiang Zeng
2024-09-16 16:11 ` Wei Xu
2024-09-23 1:44 ` jingxiang zeng
2024-09-25 0:41 ` Chris Li
2024-09-24 12:13 ` [PATCH V3] " Jingxiang Zeng
2024-09-25 2:07 ` Chris Li
2024-09-29 11:26 ` [PATCH] [PATCH v4] " Jingxiang Zeng
2024-09-29 11:47 ` jingxiang zeng
2024-09-29 11:30 ` Jingxiang Zeng
2024-10-08 1:56 ` [RESEND][PATCH " Jingxiang Zeng
2024-10-08 2:15 ` Andrew Morton [this message]
2024-10-08 3:26 ` Wei Xu
2024-10-09 4:52 ` jingxiang zeng
2024-10-09 6:21 ` Wei Xu
2024-10-08 17:12 ` Chris Li
2024-10-09 5:29 ` jingxiang zeng
2024-10-09 5:43 ` jingxiang zeng
2024-10-09 5:34 ` jingxiang zeng
2024-10-18 5:29 ` [PATCH v5] " Jingxiang Zeng
2024-10-18 6:36 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007191534.ceb663de5ac7ee3695a162a2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=jingxiangzeng.cas@gmail.com \
--cc=kasong@tencent.com \
--cc=linuszeng@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tjmercier@google.com \
--cc=weixugc@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox