From: Jeongjun Park <aha310510@gmail.com>
To: akpm@linux-foundation.org
Cc: usama.anjum@collabora.com, peterx@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Jeongjun Park <aha310510@gmail.com>
Subject: [PATCH] mm: remove the newlines, which are added for unknown reasons and interfere with bug analysis
Date: Mon, 7 Oct 2024 15:53:07 +0900 [thread overview]
Message-ID: <20241007065307.4158-1-aha310510@gmail.com> (raw)
Looking at the source code links for mm/memory.c in the sample reports
in the syzbot report links [1].
it looks like the line numbers are designated as lines that have been
increased by 1. This may seem like a problem with syzkaller or the
addr2line program that assigns the line numbers, but there is no problem
with either of them.
In the previous commit d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC"),
when modifying mm/memory.c, an unknown line break is added to the very first
line of the file. However, the git.kernel.org site displays the source code
with the added line break removed, so even though addr2line has assigned
the correct line number, it looks like the line number has increased by 1.
This may seem like a trivial thing, but I think it would be appropriate
to remove all the newline characters added to the upstream and stable
versions, as they are not only incorrect in terms of code style but also
hinder bug analysis.
[1]
https://syzkaller.appspot.com/bug?extid=4145b11cdf925264bff4
https://syzkaller.appspot.com/bug?extid=fa43f1b63e3aa6f66329
https://syzkaller.appspot.com/bug?extid=890a1df7294175947697
Fixes: d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC")
Cc: stable@vger.kernel.org
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
---
mm/memory.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index 2366578015ad..7dffe8749014 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1,4 +1,3 @@
-
// SPDX-License-Identifier: GPL-2.0-only
/*
* linux/mm/memory.c
--
next reply other threads:[~2024-10-07 6:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 6:53 Jeongjun Park [this message]
2024-10-07 8:24 ` Greg KH
2024-10-07 8:57 ` Jeongjun Park
2024-10-07 9:05 ` Greg KH
2024-10-07 11:24 ` Jeongjun Park
2024-10-07 11:31 ` Muhammad Usama Anjum
2024-10-08 1:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007065307.4158-1-aha310510@gmail.com \
--to=aha310510@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=stable@vger.kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox