From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D7CCFB42D for ; Sat, 5 Oct 2024 20:08:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4FF66B031D; Sat, 5 Oct 2024 16:08:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB1D36B031F; Sat, 5 Oct 2024 16:08:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2B096B0322; Sat, 5 Oct 2024 16:08:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8F5A26B031D for ; Sat, 5 Oct 2024 16:08:47 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50927A0E16 for ; Sat, 5 Oct 2024 20:08:47 +0000 (UTC) X-FDA: 82640636694.25.A79FB11 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 5FB0A1C000F for ; Sat, 5 Oct 2024 20:08:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CVP7Pf0A; spf=pass (imf21.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728158794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7L6m21ApIWYig/q11IA1MKr17jgGleFK15eNAui5Awg=; b=jTYoyA2zHgGtV1BaoE+Csa7cI1mHby0mhwWJS3NtzjR7OskpIU7c1OM5U4XoMgMU9fPkr7 i8E3TvLdl+WxCuc2N2QdVNPt8geVxq/oelnyh9B4Jx3GoC6u4SCNTaWVHgv0FYkB7OCybL LuQHsbWhxzNzM9z7ySmYMyeWgoUl/mA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728158794; a=rsa-sha256; cv=none; b=doZv2p9uWjKZvuh61OnReF8xdLh0pEx3EtlD3qlZJmP1Y5eRzKmMqn0DYVLpnEgFm55C97 zXQOUl365F7YV7WEzVFNdNWUUTtiGOI6lu83GkV25iyAn6sOQ+sMD1HSF33qm2O6J3oLKr fztmCMPXdzTbGeLRFcyNS561uO8P3Sg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CVP7Pf0A; spf=pass (imf21.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728158924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7L6m21ApIWYig/q11IA1MKr17jgGleFK15eNAui5Awg=; b=CVP7Pf0Axfy0EGdnriVbbwyZmSkUANrpTFkpKXoLwXrhT2EKHuDpfTzB9cbxwKID4QwkFx 8zteuUY9MLeHATqEIz1R3OBoKXz8WDpWpr4Wg7NYI+TlC3WNofmjuBuvWIUdnVfLHrORUd mVlKu0iy02ksmS8JTwQMo+/j58rl1nk= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-BJ0u1fDhNl-ZhALUG3veJg-1; Sat, 05 Oct 2024 16:08:41 -0400 X-MC-Unique: BJ0u1fDhNl-ZhALUG3veJg-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A705E1955EE9; Sat, 5 Oct 2024 20:08:34 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.51]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 295393000198; Sat, 5 Oct 2024 20:08:19 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sat, 5 Oct 2024 22:08:20 +0200 (CEST) Date: Sat, 5 Oct 2024 22:08:05 +0200 From: Oleg Nesterov To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, adhemerval.zanella@linaro.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, ojeda@kernel.org, adobriyan@gmail.com, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, mike.kravetz@oracle.com, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, hch@lst.de, peterx@redhat.com, hca@linux.ibm.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, nathan_lynch@mentor.com, dsafonov@virtuozzo.com, Liam.Howlett@Oracle.com, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, lorenzo.stoakes@oracle.com Subject: Re: [RFC PATCH v1 1/1] exec: seal system mappings Message-ID: <20241005200741.GA24353@redhat.com> References: <20241004163155.3493183-1-jeffxu@google.com> <20241004163155.3493183-2-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241004163155.3493183-2-jeffxu@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Queue-Id: 5FB0A1C000F X-Stat-Signature: zroe5o8xpz5cscymcq5gr9txd1s63599 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728158925-693367 X-HE-Meta: U2FsdGVkX1/aNgalcV2TueMM1NKULM09ADtUNRJUivYsS0akhXYgZfMTzAH3BVyMPDFOMv389CI3uc9KwpsYaJj4x18ITOqXAJlr573pCGKYSMOjmKTzs80xr9S9zrPmi80h+npqUe22avKJ0XADT7jUKNLLToC83ED/JOZmIq+B2SPapSNLdTk6F6bqpPa+D8ATHsVjm1VOx9XcwsieF53AwRM0uokXft9bwUp2FKvJ6RKIKNJcq7Q2/xIZQREMVmzgU58k5QfOsXQv+cTnM4xs/ItaFjvt3xKuXBb/o27HqbnF3qwMo4ZEWqYzVsPubcu7wB+lcPbJNRaYZngjemVLnJkjPI4pGArhuYynKfgPX+vLvlo9MR5Iw/J5DCHe4hpe1A6WI3MqxgXpVkR30e8G9ta/rK9I6NM1tj4+9osted/x66uIVLGDxJu1kFRN3f99FF7QsT1RmVHka0eODyi3coEOrzEXEjcZyue89vZcbdReNZKlq0tLUKs9IyXCeyaWpOUHUcrIkPxIIAKTxPv6XYrOdJy9kZgdd/oCDt1Rn4/ZVGgvnch/C09wJnZN6oBkv27lEqXBOiyevwST2tBl4jM0MNvc5qFNSDH7wO5ePW8MYotdcg+SfWvGC2sXCAR/dzH+Nvs5JbUr0hhHMZE/Y7MQXB6p0nQQaycd/h5Jfd99zV6xCiY0hRAzmNn4gO8FWyRpXRZmoS9w+iC9Yns5l5q41A4AyoJDBUEExI5ih+8QNng45bpaQlx8OIe4DqmgqoNJw/bRPWBoL1k773kI8sP/eMXkttOE3LSSaTs9rg4cydMqnTlLRx8iYYDDpz3wxvZ28nQWsWRHpQjIfqBihSC/Fqa4FRDFzZjBdlUjpKAGS7wG1CBXBZybmYzBz4yTQ06rwUx5ChIwQA25WmPD1ZLdIqxIZbl+ciwN12V+st0JM0PQWMFEaosy4FBj8W9OdJ1Ufg4Hesup//T /gxjK0mL whGEFtXlswH04xdQry5h3VdDwpp2vdxRB5vihktlp8YHuHlTKEN7s6CfSt9F/AA3LTg9HQ7sDlNXgUIspvuOItNci0Q8ZSCxb96NpdSxLbG7LQoS5t6trqF2fEoQ3W1uD6lZcawfQbkFkhWaR90fF8Srlu300UVCmCW6J7hTxE7ESjmKW4EWSe8Mt6LNPHcSNXOztwYRiIsU2KWn8szUo03GgL8dNKcWWLGlMYXdajrcbH6rL6V18cUu44XAk7kOWHma4DTnFLqgsEDQwAFmjXKNvNDv5fh2jiCIsP6krdHZ3hQvUq3ysiPL6FXt+mKjHi7CuB701DEuwk3wdNuErIK2HkAhOtSd0SeuioBvwtJtY3ViLn2bAocUaN78kfcPdAQSGt4pCTqAtFht+SdQN0u98oA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/04, jeffxu@chromium.org wrote: > > It is important to note that the CHECKPOINT_RESTORE feature (CRIU) may > alter the mapping of vdso, vvar, and sigpage during restore > operations. Consequently, this feature cannot be universally enabled > across all systems. Can't review. But as for uprobes, I'd prefer a simpler patch which doesn't need the new CONFIG_ and/or kernel boot options, something like the patch below. And I don't really like the fact that this patch changes the behaviour of the "generic" _install_special_mapping() helper, but I won't argue. Oleg. --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -430,6 +430,8 @@ extern unsigned int kobjsize(const void *objp); #ifdef CONFIG_64BIT /* VM is sealed, in vm_flags */ #define VM_SEALED _BITUL(63) +#else +#define VM_SEALED 0 #endif /* Bits set in the VMA until the stack is in its final location */ diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 40ecab0971ff..388373c11593 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -1510,7 +1510,7 @@ static int xol_add_vma(struct mm_struct *mm, struct xol_area *area) } vma = _install_special_mapping(mm, area->vaddr, PAGE_SIZE, - VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO, + VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_SEALED, &xol_mapping); if (IS_ERR(vma)) { ret = PTR_ERR(vma);