From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4620ACF8868 for ; Sat, 5 Oct 2024 01:13:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA1998D0005; Fri, 4 Oct 2024 21:13:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C50188D0001; Fri, 4 Oct 2024 21:13:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA3728D0005; Fri, 4 Oct 2024 21:13:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 820B78D0001 for ; Fri, 4 Oct 2024 21:13:57 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1650F1405AE for ; Sat, 5 Oct 2024 01:13:57 +0000 (UTC) X-FDA: 82637776914.27.C9793CB Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf28.hostedemail.com (Postfix) with ESMTP id 5475EC0007 for ; Sat, 5 Oct 2024 01:13:54 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KP6vw++8; spf=pass (imf28.hostedemail.com: domain of lkp@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728090794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RY0crmJAmKcbwXg3UxHqHUxT2/g1K+eAF2ZPDQ+FeoU=; b=dqKFy88pT895p8JmqE2MR64QasluJkUjC80yAo1PJ/VgAPmw0L92kLKUFqrOsNN5hqE/YF I9sEeq8zMqsSCqhKVTKzA9EJX+NwoGK27vCy64t1JIvqoVGlHS4q2773NuQsDj1SBlIjxt J9bdFaXlW7gKQAWdlrGmHX8JikfNgXo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KP6vw++8; spf=pass (imf28.hostedemail.com: domain of lkp@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728090794; a=rsa-sha256; cv=none; b=I7voV277+j5meGi4Ngh3FQThd7N5p3X6ph35VIod73TwYmST4Y51r2QmFJgYv7BKJzzp8c q3rh6695w6y6rlt00OTcQYw8T+p1BwnyZKG+1W2d7oDM6ztMcSSNRCdOqgfv1hE7d/PoKW InffQOOinGKBNC8nMSfn8/fQ1x4KDzg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728090835; x=1759626835; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ROpFcwVfpBZVEEAbzD/niLbgvfn+U8TQfekfFIK1SB4=; b=KP6vw++8GVapMl7QV3PzJjsYm9LSronEU5SAEyOORxx16hP5ILwO4X7+ 7+ODq3EQPjzeIeZdQDp6l0MBoxvTMvhtYC/rvzDl2UmebsLdKXfIwRNby rSHMjBBaXjYUXmufKEsrZnli9Nrq5bEWQ+YMDqtkLRnyESgOpZrm852rz ar/WuihPkAty9HHMPCYpvEWcYkkXqup6mM1l0yOSAV/93zmmfOesEongF CtT2TyTcXb9H6HcG56qKXbeY6qy3tcrtXZ6VRxfkIpbwtMPhctZC1+aaJ s5p60m8+rGzKhhkE7KNxVKC4ejxP53qOaRT0kz2uPHTeolf/44LD7066v Q==; X-CSE-ConnectionGUID: FRJtlID2Rg6PjH/bKmOBcw== X-CSE-MsgGUID: OXETr7UKSlOQmAJq0MzuRQ== X-IronPort-AV: E=McAfee;i="6700,10204,11215"; a="37891402" X-IronPort-AV: E=Sophos;i="6.11,179,1725346800"; d="scan'208";a="37891402" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2024 18:13:53 -0700 X-CSE-ConnectionGUID: Jq3hpcnDQ9SJ7qXh6xlIgQ== X-CSE-MsgGUID: YHkhactZQc2V34zPY3+UIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,179,1725346800"; d="scan'208";a="78857400" Received: from lkp-server01.sh.intel.com (HELO a48cf1aa22e8) ([10.239.97.150]) by fmviesa003.fm.intel.com with ESMTP; 04 Oct 2024 18:13:48 -0700 Received: from kbuild by a48cf1aa22e8 with local (Exim 4.96) (envelope-from ) id 1swtMf-0002P8-2G; Sat, 05 Oct 2024 01:13:45 +0000 Date: Sat, 5 Oct 2024 09:12:58 +0800 From: kernel test robot To: Andrii Nakryiko , linux-trace-kernel@vger.kernel.org, peterz@infradead.org, oleg@redhat.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com, mhocko@kernel.org, vbabka@suse.cz, mingo@kernel.org, Andrii Nakryiko Subject: Re: [PATCH v2 tip/perf/core 5/5] uprobes: add speculative lockless VMA-to-inode-to-uprobe resolution Message-ID: <202410050846.Zbsm9OI1-lkp@intel.com> References: <20241001225207.2215639-6-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241001225207.2215639-6-andrii@kernel.org> X-Rspam-User: X-Stat-Signature: cemgg655wf1zeoqbradu3e3pqbua3mti X-Rspamd-Queue-Id: 5475EC0007 X-Rspamd-Server: rspam11 X-HE-Tag: 1728090834-330246 X-HE-Meta: U2FsdGVkX1/pNVYvsgKxLIqHUlE+fpm0HskkPTekTdpCWC27qGcrP2vrCrhHXqZ9wtGlIEVx3xOAgvV9XvxzxBfe3yekJSZKORMhL+4OC6q9E/HHFA8hBCENwBffGI0k8sceWvzmeg39pAu/3PI2lf0SEnKwQFrZCsydrlElljtLV9ObIqwv9gZjWJ8/FsDTFvQy1L5yypC1qrE/w5qFu6tFaAMoIJ/amV7fnwQzluCwkC+Dl/0KitMCm1K7qj7PabTdFBtXgyZgSjtZVk0qbeA4t9wWWiEWvX2Yi84MVwEHzxr8REYJinU+PZtAS/3OxrLyj1S9fXdWdoziXXeiYi4xxwoOTNyd5kvHns0qMpYtobyTti6ZWhHAY+vkUZeEK2/uQk7gqc9gxHRKp/AZDY0fVOVH9icIVULyRCoxMroIP2UIxcjSNljS08b/MxehmUyxzQaK4TTJYEdq3uh+6XWxChhTg92MyQn/dw2v27Z6oJ55jAH2arKb5eBmI4VJwyRWzelcj5c1+mMRg2XVch8EYEDDpxX01eFMv5hiGUHnFwaoj04vJTl97RjX1EHy+QxwjSSrxg7XMZ0Kejmperfj9GCQQlirm7q0QdXXqjVye7pb6e5ll5kSY0YUxXVkleDKzCQymLKKO811fqbERO+/kXmxhVaoL6RO8PA+aqTwCSM2vou86629fqhj9sazve+B9cRTQFxpy4hAoyHJL67Mk2ER1rWg3dwUkH8o59/8CbViHjX6GPU+ID2l2K0VOVNOQ63JRe4BpFBsdYRCRP7W/PYRUY7mRmsU36ElHQrPk/swtwNFBpCH7n7y8CaPI8Dcc01S3MqJxJOE3JCEcZ6S8J94qkFwKFz6CogYdogw4PiCA3ttql97YRKbzCtShWveJdvEFx5RCk3FNjmF742PKUbZTFMQjVFFzxIbwR3HQ85X40fpnhmrn37eugFk8gyLAwAiMc9f5M1oI8v tiE6fmki R5torxJgBL6CQRq9nkBu8s/U+9S+Ii3RwGX5FJ8xbm66slMggJ93eQVmnqT4dUpCY4yGC3Uku0dYIUdEFDJzy+bikkSAqkyudve0zfqPVyIBPXm+hgy44OSVZcB6aw2kvwY4oeiuVdNCeYshDusf35BmjXg7QQSKWa5n+OtXalUrWlOy7nWZh6atJwUq58T/gYA8HY/iKdN7fZlF8qv9VwRE1jkqzVejlNCU1OlKRYoopCThtTNXIDwfcu1BKnhISCQi79gK6Otd7dHSqDUhvQyL5IfdCXPwpwg22WfvemGxwcWuu/6L+T0PIvpYCtGEfYEMMTEZkNvx7mrY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrii, kernel test robot noticed the following build errors: [auto build test ERROR on tip/perf/core] url: https://github.com/intel-lab-lkp/linux/commits/Andrii-Nakryiko/mm-introduce-mmap_lock_speculation_-start-end/20241002-065354 base: tip/perf/core patch link: https://lore.kernel.org/r/20241001225207.2215639-6-andrii%40kernel.org patch subject: [PATCH v2 tip/perf/core 5/5] uprobes: add speculative lockless VMA-to-inode-to-uprobe resolution config: i386-defconfig (https://download.01.org/0day-ci/archive/20241005/202410050846.Zbsm9OI1-lkp@intel.com/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410050846.Zbsm9OI1-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410050846.Zbsm9OI1-lkp@intel.com/ All errors (new ones prefixed by >>): >> kernel/events/uprobes.c:2098:39: error: incompatible pointer types passing 'long *' to parameter of type 'int *' [-Werror,-Wincompatible-pointer-types] 2098 | if (!mmap_lock_speculation_start(mm, &seq)) | ^~~~ include/linux/mmap_lock.h:126:75: note: passing argument to parameter 'seq' here 126 | static inline bool mmap_lock_speculation_start(struct mm_struct *mm, int *seq) { return false; } | ^ 1 error generated. vim +2098 kernel/events/uprobes.c 2086 2087 static struct uprobe *find_active_uprobe_speculative(unsigned long bp_vaddr) 2088 { 2089 struct mm_struct *mm = current->mm; 2090 struct uprobe *uprobe = NULL; 2091 struct vm_area_struct *vma; 2092 struct file *vm_file; 2093 loff_t offset; 2094 long seq; 2095 2096 guard(rcu)(); 2097 > 2098 if (!mmap_lock_speculation_start(mm, &seq)) 2099 return NULL; 2100 2101 vma = vma_lookup(mm, bp_vaddr); 2102 if (!vma) 2103 return NULL; 2104 2105 /* vm_file memory can be reused for another instance of struct file, 2106 * but can't be freed from under us, so it's safe to read fields from 2107 * it, even if the values are some garbage values; ultimately 2108 * find_uprobe_rcu() + mmap_lock_speculation_end() check will ensure 2109 * that whatever we speculatively found is correct 2110 */ 2111 vm_file = READ_ONCE(vma->vm_file); 2112 if (!vm_file) 2113 return NULL; 2114 2115 offset = (loff_t)(vma->vm_pgoff << PAGE_SHIFT) + (bp_vaddr - vma->vm_start); 2116 uprobe = find_uprobe_rcu(vm_file->f_inode, offset); 2117 if (!uprobe) 2118 return NULL; 2119 2120 /* now double check that nothing about MM changed */ 2121 if (!mmap_lock_speculation_end(mm, seq)) 2122 return NULL; 2123 2124 return uprobe; 2125 } 2126 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki