linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2] lib/crc16_kunit.c: add KUnit tests for crc16
       [not found] <20241003-crc16-kunit-v2-1-5fe74b113e1e@lkcamp.dev>
@ 2024-10-04 18:40 ` kernel test robot
  2024-10-04 19:59   ` Vinicius Peixoto
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2024-10-04 18:40 UTC (permalink / raw)
  To: Vinicius Peixoto, Andrew Morton
  Cc: oe-kbuild-all, Linux Memory Management List, linux-kernel,
	~lkcamp/patches, Brendan Higgins, David Gow, Rae Moar,
	linux-kselftest, kunit-dev, Vinicius Peixoto, Enzo Bertoloti,
	Fabricio Gasperin, David Laight

Hi Vinicius,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 9852d85ec9d492ebef56dc5f229416c925758edc]

url:    https://github.com/intel-lab-lkp/linux/commits/Vinicius-Peixoto/lib-crc16_kunit-c-add-KUnit-tests-for-crc16/20241004-050248
base:   9852d85ec9d492ebef56dc5f229416c925758edc
patch link:    https://lore.kernel.org/r/20241003-crc16-kunit-v2-1-5fe74b113e1e%40lkcamp.dev
patch subject: [PATCH v2] lib/crc16_kunit.c: add KUnit tests for crc16
config: parisc-randconfig-r071-20241005 (https://download.01.org/0day-ci/archive/20241005/202410050215.eU9509xy-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410050215.eU9509xy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410050215.eU9509xy-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> lib/crc16_kunit.c:29: warning: Excess struct member 'crc16' description in 'crc16_test'
   lib/crc16_kunit.c:96: warning: Function parameter or struct member 'test' not described in 'crc16_test_empty'
   lib/crc16_kunit.c:111: warning: Function parameter or struct member 'test' not described in 'crc16_test_correctness'
   lib/crc16_kunit.c:132: warning: Function parameter or struct member 'test' not described in 'crc16_test_combine'

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [m]:
   - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m]


vim +29 lib/crc16_kunit.c

    17	
    18	/**
    19	 * struct crc16_test - CRC16 test data
    20	 * @crc: initial input value to CRC16
    21	 * @start: Start index within the data buffer
    22	 * @length: Length of the data
    23	 * @crc16: Expected CRC16 value for the test
    24	 */
    25	static struct crc16_test {
    26		u16 crc;
    27		u16 start;
    28		u16 length;
  > 29	} tests[CRC16_KUNIT_TEST_SIZE];
    30	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] lib/crc16_kunit.c: add KUnit tests for crc16
  2024-10-04 18:40 ` [PATCH v2] lib/crc16_kunit.c: add KUnit tests for crc16 kernel test robot
@ 2024-10-04 19:59   ` Vinicius Peixoto
  0 siblings, 0 replies; 2+ messages in thread
From: Vinicius Peixoto @ 2024-10-04 19:59 UTC (permalink / raw)
  To: kernel test robot, Andrew Morton
  Cc: oe-kbuild-all, Linux Memory Management List, linux-kernel,
	~lkcamp/patches, Brendan Higgins, David Gow, Rae Moar,
	linux-kselftest, kunit-dev, Enzo Bertoloti, Fabricio Gasperin,
	David Laight

On 10/4/24 15:40, kernel test robot wrote:
> Hi Vinicius,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on 9852d85ec9d492ebef56dc5f229416c925758edc]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Vinicius-Peixoto/lib-crc16_kunit-c-add-KUnit-tests-for-crc16/20241004-050248
> base:   9852d85ec9d492ebef56dc5f229416c925758edc
> patch link:    https://lore.kernel.org/r/20241003-crc16-kunit-v2-1-5fe74b113e1e%40lkcamp.dev
> patch subject: [PATCH v2] lib/crc16_kunit.c: add KUnit tests for crc16
> config: parisc-randconfig-r071-20241005 (https://download.01.org/0day-ci/archive/20241005/202410050215.eU9509xy-lkp@intel.com/config)
> compiler: hppa-linux-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410050215.eU9509xy-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202410050215.eU9509xy-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>>> lib/crc16_kunit.c:29: warning: Excess struct member 'crc16' description in 'crc16_test'
>     lib/crc16_kunit.c:96: warning: Function parameter or struct member 'test' not described in 'crc16_test_empty'
>     lib/crc16_kunit.c:111: warning: Function parameter or struct member 'test' not described in 'crc16_test_correctness'
>     lib/crc16_kunit.c:132: warning: Function parameter or struct member 'test' not described in 'crc16_test_combine'
> 

Ah, oops, I forgot to update the function documentation for v2. I will 
fix these warnings in v3.

> Kconfig warnings: (for reference only)
>     WARNING: unmet direct dependencies detected for GET_FREE_REGION
>     Depends on [n]: SPARSEMEM [=n]
>     Selected by [m]:
>     - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
> 
> 
> vim +29 lib/crc16_kunit.c
> 
>      17	
>      18	/**
>      19	 * struct crc16_test - CRC16 test data
>      20	 * @crc: initial input value to CRC16
>      21	 * @start: Start index within the data buffer
>      22	 * @length: Length of the data
>      23	 * @crc16: Expected CRC16 value for the test
>      24	 */
>      25	static struct crc16_test {
>      26		u16 crc;
>      27		u16 start;
>      28		u16 length;
>    > 29	} tests[CRC16_KUNIT_TEST_SIZE];
>      30	
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-04 20:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20241003-crc16-kunit-v2-1-5fe74b113e1e@lkcamp.dev>
2024-10-04 18:40 ` [PATCH v2] lib/crc16_kunit.c: add KUnit tests for crc16 kernel test robot
2024-10-04 19:59   ` Vinicius Peixoto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox