From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCB7CF8852 for ; Sat, 5 Oct 2024 00:11:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0A478D000C; Fri, 4 Oct 2024 20:11:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB4B28D0001; Fri, 4 Oct 2024 20:11:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97D028D000C; Fri, 4 Oct 2024 20:11:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7A9538D0001 for ; Fri, 4 Oct 2024 20:11:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 23049A05DE for ; Fri, 4 Oct 2024 23:54:56 +0000 (UTC) X-FDA: 82637577792.19.04E187E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id 6F126140006 for ; Fri, 4 Oct 2024 23:54:54 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sLqgR0EU; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728085920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3llk7Wtmkfw7LDClzFVqBe4Ay9ufhlrJerTAwz0qTj0=; b=yyBAw3U87n20OUmOW3Il90UmM11BfwY28LDQyn6ledSvDHE9+HEIjbn8pLEVfhumcyDuRj /eva2EkToDB/HIHDGvPUvb4Bb0NLDuWf1q6Fyl0rs0RtOpeMA0hg8NqiG3CDAOFIIYOiSt g2/hlb9qqNSpivQe+kK+ABMyFeaXwAA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sLqgR0EU; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728085920; a=rsa-sha256; cv=none; b=SY176R7hD7QNacqsSPopBsG8Bt+FXxKVUnIC5Ee4KCCI6o62UnDkiZAiPrkNZ9rETx6C3L WaWwCuhefmpbEYY2AW1LPj+kNLkiA1WX8uCAQxOK7Yr3nmdE5V466tf07eY4ql0gBInjsI /FTMc92I1iQEWgBX4CV70ZGLew6nBpw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4CEA7A436FE; Fri, 4 Oct 2024 23:54:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C3D5C4CEC6; Fri, 4 Oct 2024 23:54:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1728086093; bh=LZdx3gL0E/kNckUlBb5kMa7MM9Cgn/wNq0iRBxAsnhI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sLqgR0EUWnEWQb8EqNX0usuYc/hjXeB4nbUmaHjuI+ltUanpS9PpIFPNjTtC5cov5 1m1TjD++q6FDFY44DY/OxkgOA1/+VIsk1BhM1ktW6baPYN08mlbMu/phPn/BFG98mK OwXou9kMMwlD1VhacmtC1HuK2EbnWHlXyIZq2QNU= Date: Fri, 4 Oct 2024 16:54:52 -0700 From: Andrew Morton To: Edward Liaw Cc: linux-kselftest@vger.kernel.org, Shuah Khan , Lokesh Gidra , Peter Xu , linux-kernel@vger.kernel.org, kernel-team@android.com, linux-mm@kvack.org Subject: Re: [PATCH 0/2] selftests/mm: fix deadlock after pthread_create Message-Id: <20241004165452.a28856a9404a5a67d6fd201d@linux-foundation.org> In-Reply-To: <20241003211716.371786-1-edliaw@google.com> References: <20241003211716.371786-1-edliaw@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6F126140006 X-Stat-Signature: ohygsqycap7os9dpuu1jtn8ctigymdff X-Rspam-User: X-HE-Tag: 1728086094-833645 X-HE-Meta: U2FsdGVkX19Tuj2PswLCZPFc65Z/MX8BOv3NLB4RCHNMPkGDu1fRxqy4fbSCVdlABPIgdKKO969vsQwkXlxZvIueU70uPdJbHfbxG6agj3NnOhecooNgM6Cf53w+dUMz14pk9iXATiXGrwl6lTC4xd5/4P3wuhFAPyZyinkLCTI+4fsKnHXCQKHIWQ9cHS4UmyuQHjeYcrbc5Qm7HLDnYNCGxjwlR9Y+OKUvjavlux5z0ljn6m2yendbtBGEGN8JMtM0FiKTY6Iq7pSnSLk4QoxWTdJFxHItwKiwtaG4iH/VWHie6fVDWfnvBlWSnMjb1jGRzaug0FYDGMsbYnWNnuDTm0PVzGXl2TEtB7O32aM2EThCZiVNau3YNHomHRl6iMtWEC+aV2DPa6ivDdvJNnd+9mwDOIFOIS2Z1BkmyJvJBOKsRbbqmM/nqh2MLy4Stl3s+jAuIVmuP/KMVpWzd0rjpxP8N9DNjvavKepnq4/GD6wb2+u0HXdmtJdAmsuknxOz04FbiRdZJFoKsXA8vEjl9KO9akWKUSoZknEXJmQJzHEXSjiZPUaoBE5I93HtfJtYjZBBmew0/cKDQa+BztPfYZvNACQjPeNRVCo/qclToWbUQiIz1mOfGIJHpxvtCrojYAeqgjw8ZR5ZrGGy/KOM5UzUSYqUG0nIx/LM6tau4+if5knDdopXD2Gim7zuiI+8LAyHW9cRJ4Gi+VnGAi8IEmxqSrGFHHn8l7D4/lZ4WiI+hWNj8SKGLKztCYdkPYv4mXEbRlo25RCy0NwGU7tqIx+GVcfYGEJ6BqxJKaXF5IGUAzyq6ze8qw6XNmgPeYSoSC8Fc6LMxiRGjGfEBNkEsclWbqzA/dvvDGP/rDvPQ1m0LF+ZHin6O4UUhoWO9Oqceddkcq3GYOkcvOXruV3vTZiDiu5dI7Ek9Jvu0UNpI6p+dtv+2TITw1FPdChxkOADVYF2vjhdj6evoAh 8Phvmdcx fJC+mFDe6ijbP9czqVtzPDKjbiwOpPlU1KpOF6LuFCtfaQiha3O3CvN4ZJYesA36J8MsGavsTZRHS81YoLvo2P3eiX6P9T38ere8nXeM+80cbjtppyRHijcLXVJCD/OfOrYAZKUn9z+krEWFGbIpVoRcf4MBHydcOn+Nbxf7YdrBBfBQf2dIhdzWTxjgNwjBMBkbrg0cjpTyRwv1vgqgLFs548ihCyRhcNiHmGtjdhiROpKcVgcCsUeKxsfVdOeQAfdobDoZ8rf50nHjOJ3EsNnvwzpGKLNFDgpFqAGJtgTKegdWI/wZigBSoe+hBPezFhIzy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 3 Oct 2024 21:17:09 +0000 Edward Liaw wrote: > On Android arm, pthread_create followed by a fork caused a deadlock in > the case where the fork required work to be completed by the created > thread. > > Updated the synchronization primitive to use pthread_barrier instead of > atomic_bool. > > Applied the same fix to the wp-fork-with-event test. > > Edward Liaw (2): > selftests/mm: replace atomic_bool with pthread_barrier_t > selftests/mm: fix deadlock for fork after pthread_create on ARM These fixes have different Fixes: targets, which might cause backporting issues - some kernels might end up with one patch and not the other. Was this intended? Is it OK?