From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1742DCF884F for ; Fri, 4 Oct 2024 22:39:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 279006B010F; Fri, 4 Oct 2024 18:39:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 227D66B035C; Fri, 4 Oct 2024 18:39:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F1916B035B; Fri, 4 Oct 2024 18:39:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E458C6B03DC for ; Fri, 4 Oct 2024 18:39:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4C40D16039E for ; Fri, 4 Oct 2024 22:39:51 +0000 (UTC) X-FDA: 82637388582.24.F73D22C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf03.hostedemail.com (Postfix) with ESMTP id 7E17220005 for ; Fri, 4 Oct 2024 22:39:49 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UYpoEf3O; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728081483; a=rsa-sha256; cv=none; b=ZcamFxyFTN4gIKMYTxwH1bUkxigFRWbIl7ZCfFxXRXHKRyyHF0kpxVn2JXUa68TsBOtfFB MyDeWvCJNL+wrIL2fjeGhOI/X/OdR+ShFbEfYk6lXA0nVxKlpOCuRFbUCOO+hc+pMp6y1T DsUhPv3uNAwK5lsHmSxozKsGc1pn71M= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UYpoEf3O; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728081483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rzewkmmtMNAyugscIFRv2QaNd/DzyD5uy00RwRqqc+8=; b=Ub3OTDY1UhsaDGMMVIp3SVIWKYcynWpbGTC5SqzopggsLk/svhrtUn9pr2YbZ394+JpaiJ ZDaTh6VSu9k+e5Ef5SjYrqIdKGL15bN2I1oyBD00DLJ+Bs9bxDlNzFPzA2lafHFTiGxLvp vAvnR2iA26NHnQ2CeBUW7x+MTKwn2R8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 420C3A41ABF; Fri, 4 Oct 2024 22:39:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 262F5C4CECC; Fri, 4 Oct 2024 22:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1728081588; bh=tEnRZ1CBS1ziqRHjQFppqFl4cK5/fPc3AdB8hdfr7X4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UYpoEf3OiIJX2B4yG4MqhZy+ZfcvOWrLLY3MM2JJuemYyp5Cy+FFXT6gHAbGROfbb PCZVofPX7veozsAFvIu8xu5dGPRfwOwScY8KecTBaiQZF3dYoeLZB0fINfBYvvec1C MLLg19IrUOxHjLsFJoIftSh6CYo5IqdfqqWFoQV4= Date: Fri, 4 Oct 2024 15:39:47 -0700 From: Andrew Morton To: =?UTF-8?B?6auY57+U?= Cc: Frank van der Linden , David Hildenbrand , Xiang Gao , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: =?UTF-8?B?5Zue5aSNOg==?= [External Mail]Re: [PATCH v2] mm/cma: print total and used count in cma_alloc() Message-Id: <20241004153947.43c5b16b7f75b0f60e918019@linux-foundation.org> In-Reply-To: <2a7b7fc3a48d4bb9a6394e51af074017@xiaomi.com> References: <20240929032757.404707-1-gxxa03070307@gmail.com> <2a7b7fc3a48d4bb9a6394e51af074017@xiaomi.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7E17220005 X-Stat-Signature: acgjxisa7beiuh93zzs9powemixs6brf X-Rspam-User: X-HE-Tag: 1728081589-839443 X-HE-Meta: U2FsdGVkX18ZUQGvLqmpx43iZ1wmBDoTHqX2GPkE1qWPAR299BkbzDAB7oE2zjWFcYZBNVcSYET10dKIWznUJlTbF9eYa9Ocz+h5pnSG4BtupLb2cUDJ56+wUp1etIbxWrr9wiDcwAsXAmgXPifXXt35J/56DMu9YYV9bgAsFcdApXUYqS60fH5lmUDOzso9XFHodbgHi1D3dxkjG8UvChRLiuH663PI/jxUmXALty8KYfvafVo7Ectf1tBFWbkQi7EphyuTGF5I8x8gGu1mZ4fgCttxj47Ig5e5EOwJBKrWSBSnISwd4Af3b+NFFpVbXeQheb7DDU0MaT6xSulMSn4HowU0be4KAYOwHC6Ik0EMUezTl6tslhupLraQ3qFJGlK5+px66MuXy/Fmdy9fsezGhyo2M4RzmlxKJMUj2/1byf+UqRwZhnwmJpzNOxFfPFeTAed/OTKz6OOWI2ludK6KtLUc+eCaAsRTuiaU4055YtUzkjnTbJniwiz575x/iXQP/sjfbzvL1u6AzuukF5SsBIHbVI2N14p5w5Wp6+KMLM/3mK5+2sFeEXhZFjfjnX6dCRtIo9GsRKcP6qkropGihZlzHrEKWriCq0g/y/nqrwF7bBUepwCBuulRwvrVhJFYVluWMNvaH2/3BPSV3kCAqvQdjGxBTnZLowSIgNmvm9nPwu0FIhcZNmuPKJdhgvQsIUXWh61Q8H0x5klUnafM2wOt341mnOLSDw93tD5Tay1Fy6ecFPfYgb3TnG4ivB38MiaYTslBqOBOLpFRWLlaqhkrIFlaCKycXCiJGgXtocP4lBMN/Mf03YVvye3Pqd0EfHyyBUNfew83QdjrKvnBsSCrPnSvBPUNaE2yUmyKkHXilLYMt+8oez/RoEd6DK+xdU5COZuDskPJMe6XhVP3fAF19pr2DTpzBJ5HABx+lS9opnlibGqDTJpPSOj8aLKj7g9KrP6loGa/1M/ Jt9LNEIa DLYC9Quiz3ceF+G6NUHxdBCAXQhP/V3GamIiWBQa0e5Xx3F8mpG7hd4hz31MlSkc+gT6dqTH33famBdQc6hrL+kCFmQ4Krw8a04eIaOGRqXPsJ+f1r0gweNtdAT2zoofDBpOgwJ4YrPIB6ROXi4xN9IF4fJM7T1smrwNxXxg5Q22QKHF6BY674YBzrOFmH9SGgG483q3tivGdGPvwsaa7KlMAiaw4f6ZtPoBqqJcEULJWqxACFFSPrCdcVrCdY3mMOM3reXvSTQGvnqDmWOFZKVHwdkw49w6Qc3KUXlCIfTOyJYggc+VF9gs2m/VfODTuS949JoYSStXF0vL5Pe3Q7HHyi/MCfdup/ApHuqVFNeY2w+w/WAtPFfbFyPTHAZ+VKTmCRcj53MW9hu1owqlamrVoMQceOppcjgTK3d3i0E9sPCxygNJB03JYOF2KjQgloyuP/rKjtsYUqRxDsboNMg1knKpOzbqKRZr7iGUzYoh8H5wawbJOQQjkjuAa8hDHomSM9hlM7iIW5SQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 4 Oct 2024 12:23:30 +0000 高翔 wrote: > > > +static unsigned long cma_get_used_pages(struct cma *cma) { > > > + unsigned long used; > > > + > > > + spin_lock_irq(&cma->lock); > > > + used = bitmap_weight(cma->bitmap, (int)cma_bitmap_maxno(cma)); > > > + spin_unlock_irq(&cma->lock); > > > > This adds overhead to each allocation, even if debug outputs are > > ignored I assume? > > > > I wonder if we'd want to print these details only when our allocation > > failed? > > > > Alternatively, we could actually track how many pages are allocated in > > the cma, so we don't have to traverse the complete bitmap on every > > allocation. > > > > Yep, that's what I did as part of > https://lore.kernel.org/all/20240724124845.614c03ad39f8af3729cebee6@linux-foundation.org/T/ > > That patch didn't make it in (yet). I'm happy for it to be combined with this one if that's easier. That patch has been forgotten about. As I asked in July, "I suggest a resend, and add some Cc:s for likely reviewers."