From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3188ECF34A1 for ; Thu, 3 Oct 2024 12:13:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6B264401C8; Thu, 3 Oct 2024 08:13:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FF064401B5; Thu, 3 Oct 2024 08:13:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 894944401C8; Thu, 3 Oct 2024 08:13:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5D79E4401B5 for ; Thu, 3 Oct 2024 08:13:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 04296A14A4 for ; Thu, 3 Oct 2024 12:13:12 +0000 (UTC) X-FDA: 82632180666.23.4273B18 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id C8D80C000B for ; Thu, 3 Oct 2024 12:13:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XHlOASG1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FLB2yonR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XHlOASG1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FLB2yonR; dmarc=none; spf=pass (imf22.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727957495; a=rsa-sha256; cv=none; b=f5kz1+1SzMjuRcWPx6Nn3eledSPFCTtuXz1VJWMYhL90J1fSbNOt7aq71Od4s3VCIZ281c pbmvyOd7eFdBt5Ynhq/Z8lJWLot736+jajm4bQoM1nb2bQqw6DRIlMn1TSL7dxPhWx1gQr fW15m4E5boLgpgOiCFlx/E47hhWDgws= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XHlOASG1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FLB2yonR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XHlOASG1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FLB2yonR; dmarc=none; spf=pass (imf22.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727957495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YmDERVK5Bjc/XeyReSYqm539EjnZa14Ik4KdwHWDMhA=; b=OryZxOQRKpZnyKhSaHMDr3LjbrZEarBmSZ/A+gUBn4WRXe+Tj3XHAKFulrnuVG1ypCBR3K 8OLJAy102Uhb2xSgGaSk5mM1aBw4Crxt9r5L4Q9qw3hUW/YV+a3QF2tw6mNH+Ce3jqy47w tLnkNDbaBE7S6A5fBwvtKxY21wp+mSQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 65D3B21C03; Thu, 3 Oct 2024 12:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727957589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YmDERVK5Bjc/XeyReSYqm539EjnZa14Ik4KdwHWDMhA=; b=XHlOASG1XtOXjH9Ll6eRj7NR60sQUaktDbEdmUb2GBrh5e1Vn5NMKWXh3cG0Vb4LF+wa/W v9+OIwmg3CDOKupnArecYb48DZMzNM6zXh6J2JPRNAdUaSSbiL+nHPnbEd5AlP8Yt7sGxX +plBcN7tmjOB+qF2ThHL8loAeB0AH2I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727957589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YmDERVK5Bjc/XeyReSYqm539EjnZa14Ik4KdwHWDMhA=; b=FLB2yonRDGwAdDIY9qTyqPWbywTauirq+ZYTd+3+CEPo8E9U+ysqhRSFmBjHOVxENQq5aP Mucg9UAU4w3mUrDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727957589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YmDERVK5Bjc/XeyReSYqm539EjnZa14Ik4KdwHWDMhA=; b=XHlOASG1XtOXjH9Ll6eRj7NR60sQUaktDbEdmUb2GBrh5e1Vn5NMKWXh3cG0Vb4LF+wa/W v9+OIwmg3CDOKupnArecYb48DZMzNM6zXh6J2JPRNAdUaSSbiL+nHPnbEd5AlP8Yt7sGxX +plBcN7tmjOB+qF2ThHL8loAeB0AH2I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727957589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YmDERVK5Bjc/XeyReSYqm539EjnZa14Ik4KdwHWDMhA=; b=FLB2yonRDGwAdDIY9qTyqPWbywTauirq+ZYTd+3+CEPo8E9U+ysqhRSFmBjHOVxENQq5aP Mucg9UAU4w3mUrDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5905B13882; Thu, 3 Oct 2024 12:13:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HJi6FVWK/mbYIgAAD6G6ig (envelope-from ); Thu, 03 Oct 2024 12:13:09 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 0E9ECA086F; Thu, 3 Oct 2024 14:13:05 +0200 (CEST) Date: Thu, 3 Oct 2024 14:13:04 +0200 From: Jan Kara To: "Matthew Wilcox (Oracle)" Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/6] migrate: Remove references to Private2 Message-ID: <20241003121304.fhrjs5ocuzyqbemk@quack3> References: <20241002040111.1023018-1-willy@infradead.org> <20241002040111.1023018-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241002040111.1023018-7-willy@infradead.org> X-Rspamd-Action: no action X-Rspamd-Queue-Id: C8D80C000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pq4b671sdt9qo44q6ytijukcc9bnzq7d X-HE-Tag: 1727957590-569013 X-HE-Meta: U2FsdGVkX199xgVWOcuJaoG0V8/21K6scnzGw/8gb6JA8AzcI/w5PytxevwKjeLbKHlVd0ewAos2fxPpas6dYGCk8lxwGnp0jqu9z23VenXumPMPWBxaTb/rkfU2N0U5VNzieiSiAxvzHazfHV0C56Eq6JOPSMMh4zz3gbdCGgdfGJH7rzGxKB6xhymc1mgx6oEyqP1mKbw/P7MXsq/x+fl/ASwy10/6C92FhEwTyTADjDCEJEZeJGB9eoLFiHpxVWxrcGqsJl9xHBCXkalQ9AtlXtj+n1imSaeF0K1EGtpTgdgfac6hdCiJzcdufWRhCkQA8xTPdo9SprpB1iX+8wx/wA0rm06j044XTvTcb1SSMNyS/yMrbOCje+imX31yHoV5QVKLhcRz5NJyViZqMtZKMTGiJ1S7Cf/Phka3l0Lq+PASnuoKWYlOjLz/T3Bh1UN0EPKk83z0eLlBAU5mf1B334J6STzEgvPGeZarzUFRBQCaYBeOEO1tZYUc+6ban23f4Wc0w+U1zgeXA0/Sc5PDAzxD2InpkL8uPlqVqewRBAva9IgSOotdQqpimtZJcn7zh0W5YV7ZPcWj+9cibvptqboIPMn3PajkEY6LocNsLogqM0a6DpwKQMBfPOO/e8cTyOUcG8Q6M2bnRD2blGEUDgRLyrUVSiEY2maSLmGGsDDJJe1/aMb3HfEsb1qOTprZvT05lXp3ulfQZyEett9QwQrM3W6iymo54SbsOoZVpaP242twtAHIP2ew3f+g766qF1fu0s6i10x/DRZjyo0PuzUeOPXdgTKQ/oZ7hkySpvxALKvXH20EaAXe+o1E1kQAZG7mEjH2QfOW5mqJyYC48YPXyIwINV6/d4sUpEX4zIsrbzS4eePKsPts0Nq+jc3Hc3mzOdEKRrswaNKkULYbp70CrljMU6sg2dKBOexyHlQj8jK5MlIYMLH0JIfKTbP4i9tOqOz319RQpYk /mxsA4M0 R71+/RgGOYtk2FdSH+BYQeYJtp9q+4Ansv6B1nQZf6xJKZaPCPUpqzP1TKviu5Gf7vmnJFWrYPdBTuoM9HUgrWvFKwc/Vbdujfg+q+ugpGxe4NWvZECLxSIr1qggGB6XWwJiduPfbpkAgbrXbhzzNFAdWekuhz2JxrrFBvVubyrUGHV1QzgqZgyDHee8jC8+6K6j0aHDMjkP+Do9Pb4/He24RZjwVjlNUB8pkzt2HLGliRu6jPNppo5OabKfdxQM/4hAkt3tVxKYLVhhFnQM5OXP0tHePbCng0BO8KQnZ3kjW4w3D71EsL01ZBS/JxhVtPCnqMs1wAqAgGRXNY6HpVqoLsx9blNdg9/pJ6L+gPfpdnHGDZWVJ/OnrHn9Saw+Aq8EckcCKRJg66ww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 02-10-24 05:01:08, Matthew Wilcox (Oracle) wrote: > These comments are now stale; rewrite them. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/migrate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index df91248755e4..21264c24a404 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -472,7 +472,7 @@ static int folio_expected_refs(struct address_space *mapping, > * The number of remaining references must be: > * 1 for anonymous folios without a mapping > * 2 for folios with a mapping > - * 3 for folios with a mapping and PagePrivate/PagePrivate2 set. > + * 3 for folios with a mapping and the private flag set. > */ > static int __folio_migrate_mapping(struct address_space *mapping, > struct folio *newfolio, struct folio *folio, int expected_count) > @@ -786,7 +786,7 @@ static int __migrate_folio(struct address_space *mapping, struct folio *dst, > * @mode: How to migrate the page. > * > * Common logic to directly migrate a single LRU folio suitable for > - * folios that do not use PagePrivate/PagePrivate2. > + * folios that do not have private data. > * > * Folios are locked upon entry and exit. > */ > -- > 2.43.0 > > -- Jan Kara SUSE Labs, CR