linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH 6/6] migrate: Remove references to Private2
Date: Thu, 3 Oct 2024 14:13:04 +0200	[thread overview]
Message-ID: <20241003121304.fhrjs5ocuzyqbemk@quack3> (raw)
In-Reply-To: <20241002040111.1023018-7-willy@infradead.org>

On Wed 02-10-24 05:01:08, Matthew Wilcox (Oracle) wrote:
> These comments are now stale; rewrite them.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  mm/migrate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index df91248755e4..21264c24a404 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -472,7 +472,7 @@ static int folio_expected_refs(struct address_space *mapping,
>   * The number of remaining references must be:
>   * 1 for anonymous folios without a mapping
>   * 2 for folios with a mapping
> - * 3 for folios with a mapping and PagePrivate/PagePrivate2 set.
> + * 3 for folios with a mapping and the private flag set.
>   */
>  static int __folio_migrate_mapping(struct address_space *mapping,
>  		struct folio *newfolio, struct folio *folio, int expected_count)
> @@ -786,7 +786,7 @@ static int __migrate_folio(struct address_space *mapping, struct folio *dst,
>   * @mode: How to migrate the page.
>   *
>   * Common logic to directly migrate a single LRU folio suitable for
> - * folios that do not use PagePrivate/PagePrivate2.
> + * folios that do not have private data.
>   *
>   * Folios are locked upon entry and exit.
>   */
> -- 
> 2.43.0
> 
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR


  reply	other threads:[~2024-10-03 12:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-02  4:01 [PATCH 0/6] Filesystem page flags cleanup Matthew Wilcox (Oracle)
2024-10-02  4:01 ` [PATCH 1/6] fs: Move clearing of mappedtodisk to buffer.c Matthew Wilcox (Oracle)
2024-10-03 12:10   ` Jan Kara
2024-10-03 14:19     ` Matthew Wilcox
2024-10-02  4:01 ` [PATCH 2/6] nilfs2: Convert nilfs_copy_buffer() to use folios Matthew Wilcox (Oracle)
2024-10-02 13:11   ` Ryusuke Konishi
2024-10-02  4:01 ` [PATCH 3/6] mm: Remove PageMappedToDisk Matthew Wilcox (Oracle)
2024-10-03 12:11   ` Jan Kara
2024-10-02  4:01 ` [PATCH 4/6] btrfs: Switch from using the private_2 flag to owner_2 Matthew Wilcox (Oracle)
2024-10-03 17:09   ` Josef Bacik
2024-10-02  4:01 ` [PATCH 5/6] ceph: Remove call to PagePrivate2() Matthew Wilcox (Oracle)
2024-10-02  4:01 ` [PATCH 6/6] migrate: Remove references to Private2 Matthew Wilcox (Oracle)
2024-10-03 12:13   ` Jan Kara [this message]
2024-10-04  7:24 ` [PATCH 0/6] Filesystem page flags cleanup Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241003121304.fhrjs5ocuzyqbemk@quack3 \
    --to=jack@suse.cz \
    --cc=brauner@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox