From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0496CF34A0 for ; Thu, 3 Oct 2024 12:11:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FD9E4401C7; Thu, 3 Oct 2024 08:11:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 586B34401B5; Thu, 3 Oct 2024 08:11:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 400F74401C7; Thu, 3 Oct 2024 08:11:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 16EF54401B5 for ; Thu, 3 Oct 2024 08:11:29 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7E9CCC1419 for ; Thu, 3 Oct 2024 12:11:28 +0000 (UTC) X-FDA: 82632176256.15.90645DA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf19.hostedemail.com (Postfix) with ESMTP id 438D31A0008 for ; Thu, 3 Oct 2024 12:11:26 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pc3LaxDP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DWIT8qCG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pc3LaxDP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DWIT8qCG; dmarc=none; spf=pass (imf19.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727957381; a=rsa-sha256; cv=none; b=MukyZuebZ/HBQToTlU2XX/xcW4MNId1EUvA+0rictb7Bdr9P0+jGblNKBLcd0vYtqfc5Qt jB9HdW9uoIFqcFs9PNYFIVDYadus+STV9//hUa2XA7emw11kDdq8fb/E+VxUOdV3wygyin G7jUcX2rz8xSxkAMwR5LiIPDTWWRbDU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pc3LaxDP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DWIT8qCG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pc3LaxDP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DWIT8qCG; dmarc=none; spf=pass (imf19.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727957381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vXa718mvxoZtEoHrrlnbDE2eswunncKSuvkTSZBqt3I=; b=ssdTYJtAeqWL1Olx+RGTUL8CskpljK+6jt9IP0n6aiPEZzF64eXyc3VYhBBoG5uWHFLmc1 MnkdbwzoSBwS3JaVYxCDMQl+E9xHzvXs2qFG2lmbJruzJWjyHB32V9oW4Jj5KzoMjsdJco D6GpNvPB0m1yFArSctosM8UwkZ3gMbk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A1D091FB6C; Thu, 3 Oct 2024 12:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727957484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vXa718mvxoZtEoHrrlnbDE2eswunncKSuvkTSZBqt3I=; b=pc3LaxDPajCeSWM9YjzyTbxTLcQANrCSqJr4NBF/bm4DSHSbwPz2mBdLVsF0YLSgFDoJqD tQyYSWsou1JCoM7gaU2ISbQqf1TpK9iE43vOkMLEvmLUBP8tv8T7OvF6+ZnIRP/pPoDPhU 2fmUtl/gDX0L8A++s2YVOFjTddXPR8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727957484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vXa718mvxoZtEoHrrlnbDE2eswunncKSuvkTSZBqt3I=; b=DWIT8qCG+HIrbl5MbCsm4V/nCR9wr8GrAcc6S/EeV+O6Gaps1QixCLdoCmW6XLnXfFu7BJ ykzV3QHIu+uoa3Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727957484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vXa718mvxoZtEoHrrlnbDE2eswunncKSuvkTSZBqt3I=; b=pc3LaxDPajCeSWM9YjzyTbxTLcQANrCSqJr4NBF/bm4DSHSbwPz2mBdLVsF0YLSgFDoJqD tQyYSWsou1JCoM7gaU2ISbQqf1TpK9iE43vOkMLEvmLUBP8tv8T7OvF6+ZnIRP/pPoDPhU 2fmUtl/gDX0L8A++s2YVOFjTddXPR8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727957484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vXa718mvxoZtEoHrrlnbDE2eswunncKSuvkTSZBqt3I=; b=DWIT8qCG+HIrbl5MbCsm4V/nCR9wr8GrAcc6S/EeV+O6Gaps1QixCLdoCmW6XLnXfFu7BJ ykzV3QHIu+uoa3Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 985DC13882; Thu, 3 Oct 2024 12:11:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bXAzJeyJ/mZLIgAAD6G6ig (envelope-from ); Thu, 03 Oct 2024 12:11:24 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 528B3A086F; Thu, 3 Oct 2024 14:11:20 +0200 (CEST) Date: Thu, 3 Oct 2024 14:11:20 +0200 From: Jan Kara To: "Matthew Wilcox (Oracle)" Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/6] mm: Remove PageMappedToDisk Message-ID: <20241003121120.gdiibqxse3mu63my@quack3> References: <20241002040111.1023018-1-willy@infradead.org> <20241002040111.1023018-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241002040111.1023018-4-willy@infradead.org> X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 438D31A0008 X-Stat-Signature: chicbqzmggacczo7p479whkmkfee1abm X-Rspam-User: X-HE-Tag: 1727957486-602984 X-HE-Meta: U2FsdGVkX18inBo71FhpSK8q9HaiWDVTfh6rq2a60C1P8kJHYBA31hx9zAaMHO/BU+RJenHMWv2A5uVnxfm+fAj75rqtKqUpwK7OTf0WYcWHYYufopC8DOEwzM42y+khYfRPr+3gWViACEPFSZfK/9O+HM3+FyiT6zf0fdMjURZXA+aCxhnF5TCgcmI7gVIfNgMl2LVAr3JHItTIHVjhldfhrWWHGTKLmuv9GmIt94IVteAYqcXSdu0wlV76/JGZcgwaMEXqviQNZ/o0nPXhP9rq4NQz8nLCh+20SS/ccnq0PyLybSqr928PzjI0+9l7f0CjvT5hDdtd6hZqKrQ1iZMzH8ZnxRRdZPlYA64BDaSaTYf9I4w8xUhD7KSoOoIR2rFqPvPsP7CHkCjnEmZfCZ9ifWzRtu2X4OiImoQ+wg0oFOtJc32wIKDX5kW08qMEsbZqEkyWcV9rbHFIzYdUVF23jU4ooTZqBbx+TTUGDLsQELndjnzdu78f2GCv/8h238cKWE1FUhchEfri94K8Lqqhm5eKr4NGBsc2Dgxzjj97HIc1dmsaWagIxZFEuA6fCbiBTBi6TcZTpFKd3ZT0+Eq8DkhzieH+ZqFXSinNbC7mPRIS0sa582y/bYwCKS7O8ULGejLQJRkptVlkfvLBPZEJgN02rSARlqhpyRhx/CcdCNJVor9SvRrIr663H/IGXg1cZVOAxhcmpEWvZN2jWLy5Ka5OQrvUjiqySW9GScQy9CzuLPrdUEHN2FbEGl0yP+5s3VG2+ChAx5AkTP6wYBfuvNTgI7KJXYKrNZV1+haIoGEz5Xyijd3fIWPKtHxi+mZ0Tn6+0/RzkCozr+aOdzrlY3Vk6OkaGmIWcoGa+amhr3tQLSoWU8tLq4AxFk08tMmOG190BBENSJmL+sWmq2eueE6UwlMRH9a0rPixbKFPyED3AMo0EoZbgHWUWkU8olmqWce6HvGqPiFnYvd O0QMoegb dj4Fk3kuwdwSySWCUVjxodWwVPAQRkzItbr0mNoRkKMo/XIhu4iuZeIUkeTs+lKw5p0M2RVpNo75YUBfmgOOkcxRqLWW5d8MH/DjaOHhKalQLJdkXOPDxW8/VLg/tmY0a1pAyPRYAncH0BIMvKuY8sqz5aCyVvNbtDnj2dKrAN2wv/QnoRQaDVtsWo87B5JXobPpDQVpnp1vftrSpmGpjP5CYRZCen4eB9PLLp+8oLO4nGbSNmZ6JXgsCYIols+xj+mD1pxTdprG9kPBaOlJa8nDOxwJGTIWKt9+9DEqsrVRYZ+4cEsQsafo7siBlc4XB0Sq8f8YMfyu1XQfBBBQubXzVM4+zeTBouBcGoDM44CtAaJFPSfkHzdPxW0ELzdSSdB/uRR621/GgRuQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 02-10-24 05:01:05, Matthew Wilcox (Oracle) wrote: > All callers have now been converted to the folio APIs, so remove > the page API for this flag. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > include/linux/page-flags.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 1b3a76710487..35d08c30d4a6 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -554,7 +554,7 @@ FOLIO_FLAG(owner_2, FOLIO_HEAD_PAGE) > */ > TESTPAGEFLAG(Writeback, writeback, PF_NO_TAIL) > TESTSCFLAG(Writeback, writeback, PF_NO_TAIL) > -PAGEFLAG(MappedToDisk, mappedtodisk, PF_NO_TAIL) > +FOLIO_FLAG(mappedtodisk, FOLIO_HEAD_PAGE) > > /* PG_readahead is only used for reads; PG_reclaim is only for writes */ > PAGEFLAG(Reclaim, reclaim, PF_NO_TAIL) > -- > 2.43.0 > > -- Jan Kara SUSE Labs, CR