From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C244CF34A1 for ; Thu, 3 Oct 2024 12:10:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F6C46B037A; Thu, 3 Oct 2024 08:10:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 985406B0489; Thu, 3 Oct 2024 08:10:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 782AD6B0373; Thu, 3 Oct 2024 08:10:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 440B46B0301 for ; Thu, 3 Oct 2024 08:10:36 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DBDC5C125D for ; Thu, 3 Oct 2024 12:10:35 +0000 (UTC) X-FDA: 82632174030.07.36220BA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id 65005180018 for ; Thu, 3 Oct 2024 12:10:32 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DX6Q+IcO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="2/HesUIE"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2RTKKfR9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OnCmJlo8; dmarc=none; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727957337; a=rsa-sha256; cv=none; b=WLbmxZ9P9KeS9wult0/8H1Y1YKq1ExOayUIiLBqoGWASqT2U8oU8Yw/Q3Ow7fkaQwq25JB c1Yg/b/M6GUJYz0LTDQBc5Tr0c9Rm2tMjoApH+Cl59gpqw5uv/2jV4rY1bZKxTBzgmoHLz Npes2oZP8T30B0mht5vVZVh5mbJy+D8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DX6Q+IcO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="2/HesUIE"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2RTKKfR9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OnCmJlo8; dmarc=none; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727957337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yG3NFZF51ik4yscefD7bkZR402j9YJxhaCsaR0zppt0=; b=5SN60S3I74cNJO8k/W7WV7MxGrf3heoDxrBMlJwbtSHbGBDUw/WzrmeH4nuqj3tnsJwwSs a/fvFx+bbCzUK5MzXgjBzRt22FKjAMksOXMnZN94Jy9QKIcodT2nnhMupdehsF+mBSA4Ea ghE1O/H8297y5M8alrPLCHRXJaE3Q1g= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DE1D921C03; Thu, 3 Oct 2024 12:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727957429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yG3NFZF51ik4yscefD7bkZR402j9YJxhaCsaR0zppt0=; b=DX6Q+IcOKvn0idhPKrKqNBfY59zlsQI/8qqsUrs4LQrv/glwrwJGWwk1l6cv8OXMTcZOAK KKhn5fygOM3RxqgXEIdjWFumDGDvNFPdQ7fmYYcJ/1cyZRA8oJgo5rMqyrglBlU91OuyHA QQf9vmG22B6Ax6bElFk+FVMOe+UX7Bo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727957429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yG3NFZF51ik4yscefD7bkZR402j9YJxhaCsaR0zppt0=; b=2/HesUIEssTze+NqyrHmAYMmi8MGHX1vMe1NOqatVdqXzkSsuWV0zP3kHJc9mtkFO8fqsA m5iM2vQnNkMaXfCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727957428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yG3NFZF51ik4yscefD7bkZR402j9YJxhaCsaR0zppt0=; b=2RTKKfR9AB/92GFNRoE0nJ86pUWxvTougnYOGH7IVgarOqkCINZOCjyB1SUaurqq9NFOOn MIuP4I4sdY7WoYee5gKe4kujQAAFQThXxMQkTx27rEPmS90WcPKyk3QCsVbxs31LINxdL1 HBj55Bsd0F2pLSR9/X0IC9K0fxT6acE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727957428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yG3NFZF51ik4yscefD7bkZR402j9YJxhaCsaR0zppt0=; b=OnCmJlo8h9QOp897FRSqi0wLna1CSY6Btyz90g5l5u701jwVFEegyet3F4Q6xzZiI7qAdb UFwzW7zhcEs7C5CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D323613882; Thu, 3 Oct 2024 12:10:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aWqFM7SJ/mYMIgAAD6G6ig (envelope-from ); Thu, 03 Oct 2024 12:10:28 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 90EB7A086F; Thu, 3 Oct 2024 14:10:20 +0200 (CEST) Date: Thu, 3 Oct 2024 14:10:20 +0200 From: Jan Kara To: "Matthew Wilcox (Oracle)" Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/6] fs: Move clearing of mappedtodisk to buffer.c Message-ID: <20241003121020.36i4ufbbuf4fbua7@quack3> References: <20241002040111.1023018-1-willy@infradead.org> <20241002040111.1023018-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241002040111.1023018-2-willy@infradead.org> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 65005180018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: g1itjbohg4kdfoakrdbtroo5mqgrtzgj X-HE-Tag: 1727957432-470577 X-HE-Meta: U2FsdGVkX199Mid1yuOTLLAerXHRlOe0E42mPGWPQWluTNukwAHGnSrvOix5+OqiKAXXoU8jVi6PDPfQDHr11MAPcmhUJ8zJrPrd0HI9NKdpi0E958hHUlVeQvIGa1pdJTnxR36irLJPuttkzpEYilq7RRTvGZSwGnuyvIQU01I2ttW9vXT4pbXGvGo7BfVCQZqzSdD8Nj4fYoR7a9N29GmYtcv9JELsvj7z9EtkwIxlXZFxD+JayeEJP7w/IT4OsyORpQ+pKGnfPxQ2WShyy6nne+28tAlErXhEOUDweP18UQre5O2G4BOIAIYso2mECNHR+p3PJaQ6EpY+UzsjENur2g9FHQYnExJ5hEOHC850sWNz5A7lSndmYK6Y3WvQrd264OTPJODem95uFb652V1wCVbmvNOV4KDNjdE2GvNk3nxsFieW75bdORhZcI320Opmct301GVDO3nFU6od2Nw7L88Y9M+zhW5Q8cxwNehz5EBgYGKP/EYvRYJQ0zcBk3xPIApd9J2DkqS0oj5dEKZd/EKEgzFySoXm3LSLIJLyR/ZsqjTydMHaEIV+SbeKcdhSUdheMnP7DY0nDA9K5CEsXvyg3nGY1n37eUbz2czS0TH9+wDwPkCyLsB8ql1LR7GvF+uXxw+KPo7aomwZKd3ShYCAc0Dzd0Y95hsPtsyuhCMQ3SQU09Z8TI0745Jy6ZcA/0/ximPywCqOLbdCEyTPcJrSZLcttsmbZbURjCwWYbAKS155d11J04+7WdlXbEWdOWMUaCUX2rVtxkey02JIoTWNIixdVAJTDp83yaYkueqqkWSvbi2kPEBUuCfnzB9KbBPqpLRbbgLw1tHZdxtbYOLjNKGZMzBYbgRC3HoHJGnDDudylGSMVGv6cDzte8IaOIhrltSMGFcUAHoWUdd4zPfQF0gJ+nvB806lnVH5aT07b4CV5w9v54svLLaM+k0XPukncKHwmY8Un7C rMNUflk1 EEc891jwrk8WnB9X+7gGMwTyMp3hy+GAs6hR7UqQh7WYY89hfB9iqbr7lr6o59Yn+yj4SFykAASYnOXbxMuIq5vR2Rs3wuI6j/tVWYKB+eYq7sKy6lrJUsqp8G8edFL9uutuiMeV7Nbk09/3Pge1+dkV8goEJ+VfHyMz3BoEVU+WGgLDGdvg+CHbYIJ4SfbqShX2r1mlliqHnvl5hrBXEkCE0LrsKMflPXj71RfIF5VtI5i6i6GtU8sRMvH+kw37epqO0jhs10o4JU1OyslsVp1gAuG05h2vLDmXBPwdgP2ftoyHkwcMUdQGJhePuUTfdkl3ekVkwsQsDuzGMxmSbLKeQJwIKB+E+CwIOlMi/hrdvxHowbUQvKTsPAP+39G/WkpA+epoy2t0ezmI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 02-10-24 05:01:03, Matthew Wilcox (Oracle) wrote: > The mappedtodisk flag is only meaningful for buffer head based > filesystems. It should not be cleared for other filesystems. This allows > us to reuse the mappedtodisk flag to have other meanings in filesystems > that do not use buffer heads. > > Signed-off-by: Matthew Wilcox (Oracle) The patch looks good. But I'm bit confused about the changelog. There's no generic code checking for mappedtodisk. Only nilfs2 actually uses it for anything, all other filesystems just never look at it as far as my grepping shows. So speaking about "filesystems that do not use buffer heads" looks somewhat broad to me. Anyway feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/buffer.c | 1 + > mm/truncate.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index 1fc9a50def0b..35f9af799e0a 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -1649,6 +1649,7 @@ void block_invalidate_folio(struct folio *folio, size_t offset, size_t length) > if (length == folio_size(folio)) > filemap_release_folio(folio, 0); > out: > + folio_clear_mappedtodisk(folio); > return; > } > EXPORT_SYMBOL(block_invalidate_folio); > diff --git a/mm/truncate.c b/mm/truncate.c > index 0668cd340a46..870af79fb446 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -166,7 +166,6 @@ static void truncate_cleanup_folio(struct folio *folio) > * Hence dirty accounting check is placed after invalidation. > */ > folio_cancel_dirty(folio); > - folio_clear_mappedtodisk(folio); > } > > int truncate_inode_folio(struct address_space *mapping, struct folio *folio) > -- > 2.43.0 > > -- Jan Kara SUSE Labs, CR