From: "André Almeida" <andrealmeid@igalia.com>
To: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
krisman@kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com,
"Daniel Rosenberg" <drosen@google.com>,
smcv@collabora.com, "Christoph Hellwig" <hch@lst.de>,
"Theodore Ts'o" <tytso@mit.edu>,
"André Almeida" <andrealmeid@igalia.com>,
"Gabriel Krisman Bertazi" <krisman@suse.de>
Subject: [PATCH v5 04/10] unicode: Recreate utf8_parse_version()
Date: Wed, 2 Oct 2024 20:44:38 -0300 [thread overview]
Message-ID: <20241002234444.398367-5-andrealmeid@igalia.com> (raw)
In-Reply-To: <20241002234444.398367-1-andrealmeid@igalia.com>
All filesystems that currently support UTF-8 casefold can fetch the
UTF-8 version from the filesystem metadata stored on disk. They can get
the data stored and directly match it to a integer, so they can skip the
string parsing step, which motivated the removal of this function in the
first place.
However, for tmpfs, the only way to tell the kernel which UTF-8 version
we are about to use is via mount options, using a string. Re-introduce
utf8_parse_version() to be used by tmpfs.
This version differs from the original by skipping the intermediate step
of copying the version string to an auxiliary string before calling
match_token(). This versions calls match_token() in the argument string.
The paramenters are simpler now as well.
utf8_parse_version() was created by 9d53690f0d4 ("unicode: implement
higher level API for string handling") and later removed by 49bd03cc7e9
("unicode: pass a UNICODE_AGE() tripple to utf8_load").
Signed-off-by: André Almeida <andrealmeid@igalia.com>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>
---
Changes from v3:
- Return version on the return value, instead of returning version at
function args.
---
fs/unicode/utf8-core.c | 26 ++++++++++++++++++++++++++
include/linux/unicode.h | 2 ++
2 files changed, 28 insertions(+)
diff --git a/fs/unicode/utf8-core.c b/fs/unicode/utf8-core.c
index 0400824ef493..6fc9ab8667e6 100644
--- a/fs/unicode/utf8-core.c
+++ b/fs/unicode/utf8-core.c
@@ -214,3 +214,29 @@ void utf8_unload(struct unicode_map *um)
}
EXPORT_SYMBOL(utf8_unload);
+/**
+ * utf8_parse_version - Parse a UTF-8 version number from a string
+ *
+ * @version: input string
+ *
+ * Returns the parsed version on success, negative code on error
+ */
+int utf8_parse_version(char *version)
+{
+ substring_t args[3];
+ unsigned int maj, min, rev;
+ static const struct match_token token[] = {
+ {1, "%d.%d.%d"},
+ {0, NULL}
+ };
+
+ if (match_token(version, token, args) != 1)
+ return -EINVAL;
+
+ if (match_int(&args[0], &maj) || match_int(&args[1], &min) ||
+ match_int(&args[2], &rev))
+ return -EINVAL;
+
+ return UNICODE_AGE(maj, min, rev);
+}
+EXPORT_SYMBOL(utf8_parse_version);
diff --git a/include/linux/unicode.h b/include/linux/unicode.h
index 0c0ab04e84ee..5e6b212a2aed 100644
--- a/include/linux/unicode.h
+++ b/include/linux/unicode.h
@@ -78,4 +78,6 @@ int utf8_casefold_hash(const struct unicode_map *um, const void *salt,
struct unicode_map *utf8_load(unsigned int version);
void utf8_unload(struct unicode_map *um);
+int utf8_parse_version(char *version);
+
#endif /* _LINUX_UNICODE_H */
--
2.46.0
next prev parent reply other threads:[~2024-10-02 23:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 23:44 [PATCH v5 00/10] tmpfs: Add case-insensitive support for tmpfs André Almeida
2024-10-02 23:44 ` [PATCH v5 01/10] libfs: Create the helper function generic_ci_validate_strict_name() André Almeida
2024-10-02 23:44 ` [PATCH v5 02/10] ext4: Use generic_ci_validate_strict_name helper André Almeida
2024-10-02 23:44 ` [PATCH v5 03/10] unicode: Export latest available UTF-8 version number André Almeida
2024-10-02 23:44 ` André Almeida [this message]
2024-10-02 23:44 ` [PATCH v5 05/10] libfs: Export generic_ci_ dentry functions André Almeida
2024-10-02 23:44 ` [PATCH v5 06/10] tmpfs: Always set simple_dentry_operations as dentry ops André Almeida
2024-10-02 23:44 ` [PATCH v5 07/10] tmpfs: Add casefold lookup support André Almeida
2024-10-05 22:47 ` kernel test robot
2024-10-06 5:10 ` kernel test robot
2024-10-02 23:44 ` [PATCH v5 08/10] tmpfs: Add flag FS_CASEFOLD_FL support for tmpfs dirs André Almeida
2024-10-02 23:44 ` [PATCH v5 09/10] tmpfs: Expose filesystem features via sysfs André Almeida
2024-10-02 23:44 ` [PATCH v5 10/10] docs: tmpfs: Add casefold options André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002234444.398367-5-andrealmeid@igalia.com \
--to=andrealmeid@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=drosen@google.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kernel-dev@igalia.com \
--cc=krisman@kernel.org \
--cc=krisman@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=smcv@collabora.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox