From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7563CF6D28 for ; Wed, 2 Oct 2024 14:05:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2669A6B0435; Wed, 2 Oct 2024 10:05:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EFC46B0436; Wed, 2 Oct 2024 10:05:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 090346B0437; Wed, 2 Oct 2024 10:05:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CD8E06B0435 for ; Wed, 2 Oct 2024 10:05:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 31B57160704 for ; Wed, 2 Oct 2024 14:05:03 +0000 (UTC) X-FDA: 82628833686.03.00F8B4C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf05.hostedemail.com (Postfix) with ESMTP id 2D34310000E for ; Wed, 2 Oct 2024 14:04:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=EOWSXfod; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727877878; a=rsa-sha256; cv=none; b=sZPVHq/+jcrF9fhpXmoeGHKI2902x0IQ1SS7n1zUb5SQwceLA9UcWPK5INFf+XMHu8iyNZ tC5FS19EY6BWSAymTpCSSa8fvFkoDRDc81W7kJtwlh8rrbbqpXXP5i8kYaKui6XIEqUZxa hG4SFRuftMMbuaO/FAZRflgnkEYC424= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=EOWSXfod; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727877878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=u4SfnWY8O8IVsScRiFF3IfsLutSnrq9Sfe7AzGRNUAY=; b=VCRll5jAjhmfrLcDSl00TG8JLcy9FlgPhlaVjov/5CGXC57Rs4cD3JL8QRskMMl9snDA3w z97A23CAWPEnFRscU2R1XR2g0qceXqCvwKX8o2m0FUYU0wjMYHUTWruWx+iCL4ilmbAfU5 wX2mS8dLvdO7TodKKPE7E0pBOSPVXqE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727877900; x=1759413900; h=date:from:to:cc:subject:message-id:mime-version; bh=V3mZRy5RQR1Eu05wsO9e6qyZguDVh74fMnPcxO7KWxM=; b=EOWSXfodGpJZVZCjmGoFwwe47/Nw8oVzyS5DNI7dE3I9SU8CHk+Uoniv W4AJTgdkSjJOCfGl9R8HcyFc0A/1zmQOVPVWLjYPjE/9/ypMcfK8c+3ze lY281rX9zpt6OXRWMU213u5/x20PavGgjzkHg8boBK2AoNenMSNK7bwEl fkffIYVqy0UoLxFfrnACDU+0YYvxrltuaI1pVNm0TOGsEBRPbEA0KYu1y uSAKGQ+bWDihnJ9jvhh0rDLeYxDZq9WDqjXmlCmmY7wM5a5yAU/I1Atve Xq8nR6jDH0EPzSbYJi2t1b6LROgJJthkoExo9ArM9pg/07ukmEQlz1X9z g==; X-CSE-ConnectionGUID: PLTEv2TMQMioQdSBhz+lNg== X-CSE-MsgGUID: ngo5A13oSh2zBviGbuKmgg== X-IronPort-AV: E=McAfee;i="6700,10204,11213"; a="26840319" X-IronPort-AV: E=Sophos;i="6.11,171,1725346800"; d="scan'208";a="26840319" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2024 07:02:44 -0700 X-CSE-ConnectionGUID: ngE4dKQ8QhuXepPyCKUuzw== X-CSE-MsgGUID: XGe+RQGIT6mNO0MyqxWKJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,171,1725346800"; d="scan'208";a="73880526" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by orviesa010.jf.intel.com with ESMTP; 02 Oct 2024 07:02:42 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1svzw8-000Sxk-15; Wed, 02 Oct 2024 14:02:40 +0000 Date: Wed, 2 Oct 2024 22:02:26 +0800 From: kernel test robot To: Jani Nikula Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: mm/failslab.c:19:5: error: redefinition of 'should_failslab' Message-ID: <202410022126.z1ggl2C9-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Stat-Signature: bkqxpakohq8wgxu1468xzhj4uayyn9bx X-Rspamd-Queue-Id: 2D34310000E X-Rspamd-Server: rspam02 X-HE-Tag: 1727877898-513055 X-HE-Meta: U2FsdGVkX19Fn43Vy7iCkEMsK5f6VRV3JPptoHkrPwLUSn1rMekKa6NX49Luw19/NtbTib0T/rJ+n3Sc9rvQivCH46gsISYv46uNOgAGKbh5yYXqCFkeXkoyONns2SsDv/TIhkCv4W4rKOWc8R5eFYuW/iy9JdU4y28UQu8HLRYARrz7AY8fMn/jtQ3AUaSP9GkC0JDF9iF98/ZXPdHSOuV3x4BrFYvQW+1Q5m+geVF8v76VV2LMlXWOjlfac+d/wZrM3vvyV7hpDaErgChnykF73EuhCqbxty/OJBlvGihiiW7OS1RzY+Az2D1dq4guRLGquyuMp0I4KU0/W4SDM8wqeWGp84S7EHDoHUs8DCm/409/0zKzIbSbUOMjvDd+4C8t/XFszdZVL0oV70THSnskX4vkgbw5XD8weTfxEJv+G5RdEHWo3xALir2JcM67esaDUi4h8VjoGzjR08cQwgO5qPNyWA6Jdu/BPXETX10KlXQxLJzQe5GtiTVfcgXtt4OaoHGyfYPbHrrDtMZ0zwGG6t3BoAOQSUURQQ1QbXJVl+A5FeJ6IlTSM79j5CYlkC8L4jyv7M/If5wRabefKtnWaLMoscyx+PbIkj2MUVBSJwzHE7cybJDtNCxZLXlzScpjJUfuWD0iHeF7w6GDgeZICWZ0qcDxJjSOU2CCo4PSZfzA3Se6tveqpLKauGykjQUh1vjyK97OWVkJRFwtHIGltfKV35lu4+NBVabzmn+jo6EaxmCCm7QB7cI174t4QR+m4D7i6B1CrASEJ3xsvlVj+EXN2ci8/3KroCvz1197s0R3V/Ny9nvXgFF2IF0rIl0ddLSrioea1yxadbm0Ihp+R6HclAfMcOmMcAfjo/GkZviP80k2WP/nDwHAHhn6Frq+pRJSpt0ffU+wc7dENweh9DvDNtacXZSB7bxrbuBwOyKr/u3pP5cXPjVTCFD+iMrfSIhvFZA2UW+CQmb DM8YeUdv H1KrmdKDkiA5FFA96afxmgBysdY33lWnN5kqdy4jRrAG6jleGXOxKUwBP51NV6gxs5m8Su2FTVAZb9gOmnxAoEHIQK/XxRGXO3luJHrM8SytCixWOmbI+V21hLjeGQvBbLT6fAy7YdWIPX5snuoupFplX2pZp1SJK+eoBEMDixT4RVRNDssIVqvlyp2hA2rcZB0J4TOlynZcJRttWXgjJ6W97ne3TAjnKKjnvsDoW88Rk7ppjhd2z+AoRJp21QFWqo4jqSXb/WfD3brFvY5+5MSbVGKuL1nuEw03YKstet1neIwprEH248dl0XUm77IkH/AZWhC0xMZiBNJF2W1+2DgyLa3SZCvXJr/GVOXLcxhh67eNizcu/nEeNPWQRWcER7Yd/K72Fkld89ItkCWSXTmuLYo5tFsZYRvzKuIIU4ifzp8NswKCN2a50Mg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e32cde8d2bd7d251a8f9b434143977ddf13dcec6 commit: 6ce2082fd3a25d5a8c756120959237cace0379f1 fault-inject: improve build for CONFIG_FAULT_INJECTION=n date: 4 weeks ago config: x86_64-randconfig-r133-20240215 (https://download.01.org/0day-ci/archive/20241002/202410022126.z1ggl2C9-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241002/202410022126.z1ggl2C9-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410022126.z1ggl2C9-lkp@intel.com/ All errors (new ones prefixed by >>): mm/failslab.c:14:17: error: 'FAULT_ATTR_INITIALIZER' undeclared here (not in a function) 14 | .attr = FAULT_ATTR_INITIALIZER, | ^~~~~~~~~~~~~~~~~~~~~~ >> mm/failslab.c:19:5: error: redefinition of 'should_failslab' 19 | int should_failslab(struct kmem_cache *s, gfp_t gfpflags) | ^~~~~~~~~~~~~~~ In file included from mm/failslab.c:2: include/linux/fault-inject.h:128:19: note: previous definition of 'should_failslab' with type 'int(struct kmem_cache *, gfp_t)' {aka 'int(struct kmem_cache *, unsigned int)'} 128 | static inline int should_failslab(struct kmem_cache *s, gfp_t gfpflags) | ^~~~~~~~~~~~~~~ mm/failslab.c: In function 'should_failslab': mm/failslab.c:44:26: error: 'FAULT_NOWARN' undeclared (first use in this function) 44 | flags |= FAULT_NOWARN; | ^~~~~~~~~~~~ mm/failslab.c:44:26: note: each undeclared identifier is reported only once for each function it appears in vim +/should_failslab +19 mm/failslab.c 773ff60e841461c Akinobu Mita 2008-12-23 8 773ff60e841461c Akinobu Mita 2008-12-23 9 static struct { 773ff60e841461c Akinobu Mita 2008-12-23 10 struct fault_attr attr; 71baba4b92dc1fa Mel Gorman 2015-11-06 11 bool ignore_gfp_reclaim; 621a5f7ad9cd1ce Viresh Kumar 2015-09-26 12 bool cache_filter; 773ff60e841461c Akinobu Mita 2008-12-23 13 } failslab = { 773ff60e841461c Akinobu Mita 2008-12-23 @14 .attr = FAULT_ATTR_INITIALIZER, 71baba4b92dc1fa Mel Gorman 2015-11-06 15 .ignore_gfp_reclaim = true, 621a5f7ad9cd1ce Viresh Kumar 2015-09-26 16 .cache_filter = false, 773ff60e841461c Akinobu Mita 2008-12-23 17 }; 773ff60e841461c Akinobu Mita 2008-12-23 18 a7526fe8b94eced Vlastimil Babka 2024-07-11 @19 int should_failslab(struct kmem_cache *s, gfp_t gfpflags) 773ff60e841461c Akinobu Mita 2008-12-23 20 { ea4452de2ae9873 Qi Zheng 2022-11-18 21 int flags = 0; ea4452de2ae9873 Qi Zheng 2022-11-18 22 fab9963a69dbd71 Jesper Dangaard Brouer 2016-03-15 23 /* No fault-injection for bootstrap cache */ fab9963a69dbd71 Jesper Dangaard Brouer 2016-03-15 24 if (unlikely(s == kmem_cache)) a7526fe8b94eced Vlastimil Babka 2024-07-11 25 return 0; fab9963a69dbd71 Jesper Dangaard Brouer 2016-03-15 26 773ff60e841461c Akinobu Mita 2008-12-23 27 if (gfpflags & __GFP_NOFAIL) a7526fe8b94eced Vlastimil Babka 2024-07-11 28 return 0; 773ff60e841461c Akinobu Mita 2008-12-23 29 a9659476d4b391a Nicolas Boichat 2019-07-11 30 if (failslab.ignore_gfp_reclaim && a9659476d4b391a Nicolas Boichat 2019-07-11 31 (gfpflags & __GFP_DIRECT_RECLAIM)) a7526fe8b94eced Vlastimil Babka 2024-07-11 32 return 0; 773ff60e841461c Akinobu Mita 2008-12-23 33 fab9963a69dbd71 Jesper Dangaard Brouer 2016-03-15 34 if (failslab.cache_filter && !(s->flags & SLAB_FAILSLAB)) a7526fe8b94eced Vlastimil Babka 2024-07-11 35 return 0; 4c13dd3b48fcb6f Dmitry Monakhov 2010-02-26 36 ea4452de2ae9873 Qi Zheng 2022-11-18 37 /* ea4452de2ae9873 Qi Zheng 2022-11-18 38 * In some cases, it expects to specify __GFP_NOWARN ea4452de2ae9873 Qi Zheng 2022-11-18 39 * to avoid printing any information(not just a warning), ea4452de2ae9873 Qi Zheng 2022-11-18 40 * thus avoiding deadlocks. See commit 6b9dbedbe349 for ea4452de2ae9873 Qi Zheng 2022-11-18 41 * details. ea4452de2ae9873 Qi Zheng 2022-11-18 42 */ 3f913fc5f974561 Qi Zheng 2022-05-19 43 if (gfpflags & __GFP_NOWARN) ea4452de2ae9873 Qi Zheng 2022-11-18 44 flags |= FAULT_NOWARN; 3f913fc5f974561 Qi Zheng 2022-05-19 45 a7526fe8b94eced Vlastimil Babka 2024-07-11 46 return should_fail_ex(&failslab.attr, s->object_size, flags) ? -ENOMEM : 0; 773ff60e841461c Akinobu Mita 2008-12-23 47 } a7526fe8b94eced Vlastimil Babka 2024-07-11 48 ALLOW_ERROR_INJECTION(should_failslab, ERRNO); 773ff60e841461c Akinobu Mita 2008-12-23 49 :::::: The code at line 19 was first introduced by commit :::::: a7526fe8b94eced7d82aa00b2bcca44e39ae0769 mm, slab: put should_failslab() back behind CONFIG_SHOULD_FAILSLAB :::::: TO: Vlastimil Babka :::::: CC: Andrew Morton -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki