From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B4ACF8548 for ; Wed, 2 Oct 2024 22:56:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED2A66B04F5; Wed, 2 Oct 2024 18:56:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E82E86B04F6; Wed, 2 Oct 2024 18:56:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4B6B6B04F7; Wed, 2 Oct 2024 18:56:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AF2DF6B04F5 for ; Wed, 2 Oct 2024 18:56:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5D71B160B9F for ; Wed, 2 Oct 2024 22:56:00 +0000 (UTC) X-FDA: 82630171680.01.78259B6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 923E820010 for ; Wed, 2 Oct 2024 22:55:58 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NaNQ5BFc; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727909718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9ErRaxNAtsAQ+oarXnqys95GTES6Lba8S+999roV8+s=; b=PcF/x9pEdhM6CLIs6L/7lp+sYtLxmqJ9Jj/vFmIHALOxgT5Kf7TKsyBC7KOE6UsFcijfDF Kp/1lIUADNKxzoufFrT9uPsB6bJXigZE4aaOob3uI1d25AnNqwpdEbnN6w7lG796KZ6/ZZ Z4ep/QAxtmtiHHrM9VQOyJ3BoQ339wI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NaNQ5BFc; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727909718; a=rsa-sha256; cv=none; b=cPRqGPhy3xjX7V902EPs9c4qmZyNXf5z0afjKwOWlZt6AKnKD66YBDQ2rAepJW+qHczKBQ B55Yz9HVpUZ+adavkyk+/C7HR6RrwYEF/7mDV6fAwRx+20/rEgaDIMqEhkmqSzfXQGIh7W z7Yq/x5A47OQbYxh5JfXb5N6aIKaffk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EF8F15C4B78; Wed, 2 Oct 2024 22:55:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72634C4CEC2; Wed, 2 Oct 2024 22:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1727909756; bh=hISdmrroN3z/ouzw/ahGkbNjtKr7wuAcEVgGI4iucIA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NaNQ5BFc0EogH4hGv2L5VXb2PjEsbiIYyespXgp3cTKFOHhtiMd0IhN2R06wsYtDi WqRouJj2Rex11BlXtzt+iQjz4hBpDNc9AehzwbTFL1zehH9m6DmovbFBL+xiU+MCu4 yhjC+ILDwpsDDDnFsi8Wl7Wviay4DKbZyMCC4XB4= Date: Wed, 2 Oct 2024 15:55:55 -0700 From: Andrew Morton To: Shakeel Butt Cc: Johannes Weiner , Matthew Wilcox , Yu Zhao , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] mm/truncate: reset xa_has_values flag on each iteration Message-Id: <20241002155555.7fc4c6e294c75e2510426598@linux-foundation.org> In-Reply-To: <20241002225150.2334504-1-shakeel.butt@linux.dev> References: <20241002225150.2334504-1-shakeel.butt@linux.dev> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: sx54m4t1x4fc6acjkctw7xo1jgc46akr X-Rspamd-Queue-Id: 923E820010 X-Rspamd-Server: rspam11 X-HE-Tag: 1727909758-55631 X-HE-Meta: U2FsdGVkX1+FMexLEwgOpZ2Elx+MVVvYgpjmVCflrgRqYJS8V997v8eb+F6DXd1OmGgkBKSkI5tPqQRSYLxM/LFs6Z2cCOxhFmCaSimEb/ACSiGiX+cLY+3ac/bVRr32t7ZVH2jDQMTY6oe6Tb0AyajkaHHRDWCRKlldudSCjTfotIQH/VnIQMRXqVj8Shrr1cujTpzzF3RVOXs+/g0UAlCP+TF9KuUdoFH9HQnFTiV726erxVI3wUcgUeqlmzuFl4zLELfoE4p6NWtm4w11rDTZfeflAo43OjXbrC87l6D3Mpq3xkHySKJtTPKARnI4GrlNP+w8E8A5353Owl0d8unEJZDvbSBUlqtxdn7U/9BkOo8rcank62rXddIl80RJwlGGM3LRSGOzPVDQ9CVoyTbo4Gq8JvyRKmvOVMkxilBYXoD9N1o5LFk1YHs0I65k2wNri36Ireo/+mxRjm7LOwT5DcbhC9Y71qZK7jWukpOERvJUEz1M2pQO7bDFXmCrqfAOWi4tcaXlueVfA9VNClu+exHrqlaxXAk9Lg6NkYJz9Ths4Xjk8Lq9aI4/AGpQNixX+AUODhY4qsLejktgM7UFSdxvrOIxOrwqU1T5cvI/cZoTsrq4hsXDkpDZHwadqa7wNgNDKnnKljP/ft6gVN8+bKPsHM9Nz8xfHvGTUws57OjWn8ogHrl0A9MPhg5HUFRq/1M/fBC9/UpZ51MSUFQ+I3sHFAAIA1YMluQj9YQ4LslV84HkdH0N9svJBn7jTyc5P6uFIwjNhIo9G4kIOzgJ+ZIxE38I3pZ1YX7ZpbtQLz8IEkdgiinv98SIAfEhX2AjxqXQ80RbCCPZEui33ZlETwIG8du77dLtrEaGIMrRUQjsEd5rqcMtOtK/6XfcIYsBW1t+yl85rY+Y0jK6SPBS2iwJRD+x5/+BIgbV9Q9QJb2jLVej+EzhX7i+Qbr9uedFN5NpiYx9GCN3nT0 TFu0U7ta FOjFtmj4587fcosxEwGr1kXqVrDHBbK9P+m4N3jX/eaGh6dp+h+BlmAmvJvxATTM8KT5GuPv/ymfiAYZ0meE3Q6npNo37y6U4SzUw36dZexCc1clQ4IpO4jJ3pUt+LWNf0Qbw7qO2ld9SmO8LfzUUOEQzmCkgbdG+DpTDlfnDV52v1WHM/IAmwlv8KHhEhngMWIZuvZMs0VBYOCGbyf5L9P9oZvj3n9GDeLZlZXfQXx4O0PGWf5MCbfbXUNhoV/tiBekYLcmQZy3iHdZqy6NhXQS8T6Q1eknuAR++QBeOD39iCrA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Oct 2024 15:51:50 -0700 Shakeel Butt wrote: > Currently mapping_try_invalidate() and invalidate_inode_pages2_range() > traverses the xarray in batches and then for each batch, maintains and > set the flag named xa_has_values if the batch has a shadow entry to > clear the entries at the end of the iteration. However they forgot to > reset the flag at the end of the iteration which cause them to always > try to clear the shadow entries in the subsequent iterations where > there might not be any shadow entries. Fixing it. > So this is an efficiency thing, no other effects expected? > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -463,10 +463,10 @@ unsigned long mapping_try_invalidate(struct address_space *mapping, > unsigned long ret; > unsigned long count = 0; > int i; > - bool xa_has_values = false; > > folio_batch_init(&fbatch); > while (find_lock_entries(mapping, &index, end, &fbatch, indices)) { > + bool xa_has_values = false; > int nr = folio_batch_count(&fbatch); > > for (i = 0; i < nr; i++) { > @@ -592,7 +592,6 @@ int invalidate_inode_pages2_range(struct address_space *mapping, > int ret = 0; > int ret2 = 0; > int did_range_unmap = 0; > - bool xa_has_values = false; > > if (mapping_empty(mapping)) > return 0; > @@ -600,6 +599,7 @@ int invalidate_inode_pages2_range(struct address_space *mapping, > folio_batch_init(&fbatch); > index = start; > while (find_get_entries(mapping, &index, end, &fbatch, indices)) { > + bool xa_has_values = false; > int nr = folio_batch_count(&fbatch); > > for (i = 0; i < nr; i++) { > -- > 2.43.5