From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40126CF31B9 for ; Wed, 2 Oct 2024 20:36:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC8CD6B0302; Wed, 2 Oct 2024 16:36:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A78B14401B5; Wed, 2 Oct 2024 16:36:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93FA76B0304; Wed, 2 Oct 2024 16:36:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 728906B0302 for ; Wed, 2 Oct 2024 16:36:47 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 122B5A7BE9 for ; Wed, 2 Oct 2024 20:36:47 +0000 (UTC) X-FDA: 82629820854.18.ED21EAB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 39BFD10000D for ; Wed, 2 Oct 2024 20:36:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=khij2IsM; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727901383; a=rsa-sha256; cv=none; b=IDVNWE6yVKZjUjXxV2/UNA/yaHukB+sVs0tjNA9v/3OOTvVti/az2+Qt89Pi67m+cjFvF+ eUJYXyJtLfImCOnVe84NmfrXyWDfam+PFvKIfwQnJPP7W659N6hEbE0FKRog10bWxLaQaz 3E1Ce3TVg5YAyWzAOEL81CZLQJSp/jE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=khij2IsM; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727901383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=woExZXHj865B3+m4W9FxVaiZlRPNv9R2J9Vug2Et1VY=; b=UyHU2LFoRshhs63j9EYmhRb5gg72xB7nOMhUh4IVuFhYnot3arEE7w3ZyRzth/RWrT3U8c kD0nkcszLDIFgE1Tff5KH4q9uwYzjQVDJteeF3MqgVxCWqIMb2nm2NoksvElXb7TwcdweC ijIC2VTj6+txXTIirjqTQNgtgOAT0Aw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AB7955C34F7; Wed, 2 Oct 2024 20:36:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91288C4CEC2; Wed, 2 Oct 2024 20:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1727901403; bh=7Q90UDF/UXJoMNqvwpZtCwy+y7YaVocRA82hXYI1X5s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=khij2IsMKR9mnmH2fhhORaViyOTYM0kuKk77hNh5XjMssyDJy/H6rDp+tfJilWtLu Kya2efhEJzmwT3T2pep0T6Ga8zGEtHwbkKAW2NCJ6tPMte3Ke47aYXBr5Mwj2WKETE N3am6dME2bjQr8gCNRXYEN0lND7Fmfz44ikjH6NE= Date: Wed, 2 Oct 2024 13:36:42 -0700 From: Andrew Morton To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v2] mm: swap: Call count_mthp_stat() outside ifdef CONFIG_TRANSPARENT_HUGEPAGE. Message-Id: <20241002133642.9e9b82e53f2ff14f541d7864@linux-foundation.org> In-Reply-To: <20241002195547.30617-1-kanchana.p.sridhar@intel.com> References: <20241002195547.30617-1-kanchana.p.sridhar@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: k5zywnruwqhk1frfu46c7ehqnfyys6tz X-Rspamd-Queue-Id: 39BFD10000D X-Rspamd-Server: rspam02 X-HE-Tag: 1727901405-78144 X-HE-Meta: U2FsdGVkX18YbjSguF6zKHcCfTl7TM06EErb3ouYglpTzcCuNRrPdA8bTeJTFekQUWLinLBkqFHjx4dI9CQFtds0ugZ1Iwa0EUHmOrtIlcnAKBEnsi7Qcwwmdwb+dv9XGlj2+EYmz6ddnwCp9Zt1yQeEYAmGtJA87/OCWnYNbKsGW7iv50MXVVIExjOfk8kGJUsf0UiWaY7UUWVIIr55CVwBD6F5GM4zxyObFKlWPrUaJyzEces5HCSAqNRy5u+3vN1MFBLXA8kI0DaJDtsM9ErjyGbSHjCJwL80pT3zVdGY6toDI8lPJj82MZmZUhBI8J+CctVkQzloMuMWutpYxOddpt0CX0m26f/4O2j9ETl0/0LbvpxjwqUQ2CwKxOvGBfSwIgWTpTqExUzkrWi2Hxiso8hhRMvmqYHZulWWkNAl/ruqPkrcLusS800lja/97yNhWgzR5rWXxUZ+AI2ZR27uZ21mY7pExpEppBcM6FaCOBOWh5q7McfvToHkXOd5mJoUD/BpnQBAdvzA50AP/0DbV08LMrDKKRJkMT4fZwy7ykFeqz0t67WVnS7C7Pvg4ftJ8PrYomIXQ8bZS2TgNgpDKQLHHzG/XwW3cDvyPueJEvTLo85k8T3lZVlSlEfMUfex0v23x534edwznZNozgrKaB4F3J8eERVI0RCMxxQFsTwks8Atvw5pMbmLMZJ273HohyoOmTNErL1ZjKbgSk00gWXsGrmn6kN6qLOMMD4XWRmj8dMzsgeQdeoJFMxGOZ5/UmOYXw4z4H29W4CTOTRCsoXS16gnVqdj5JqFyIli4vY0nrYjsQfrJ/Up2zA6RpsyIDkH6oA33kWc6ZC1i++RUeDNVHjmzzmHWI/ohlNdQ5t+4w8vda/drj+tlOvcMdzxcry/bOIkNltX9em3KObKyJSzydKyvaKd6LY7feYCI2eF4wpI2ec5FXHbJJfb2CUFxBIDMugdNX7MEhe ziVCNnSl GlAjnOOHmzfPa4YrkViLFuhCgF7gUUEk5jEURvZyMfufCJhiJz9TTJaMPdAzHmteqUaeGUQd9NtCk/bS8jwZI6i6dFG1w9BAy8rY4gKl8rpGeQBZE8M20CGaV+IMD6I57uoSf96cJlSXyuc5qCUaRbkf8l3VKnvgySQCsQXyY8BagQZXK+b6OW4xkd9IXIC7h3+hoJzwI6XyjTwyOd9bhjEcBpWZX2NLiqcV+ripmBKhbnr6BSExfgsj/jSp6rXG0JK6J1J++hmhJXNDbogjEAGhEBuB3w0uUa3SAKqnAh0egWxoAjl7hbwQ9C5YoZkmPBWrS1uSI2aWS7fnzNZLEChgVbJOWzVSLXy0P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Oct 2024 12:55:47 -0700 Kanchana P Sridhar wrote: > This patch moves the call to count_mthp_stat() in count_swpout_vm_event() > and in shrink_folio_list() to be outside the > "ifdef CONFIG_TRANSPARENT_HUGEPAGE" This is very apparent from reading the patch. Changelogs and code comments should explain "why", and avoid explaining "what". > based on changes made in commit > 246d3aa3e531 ("mm: cleanup count_mthp_stat() definition"). And I don't think that explains the reasons for this change either. So please resend with a changelog which fully explains the reasons for making this alteration.