From: Andrew Morton <akpm@linux-foundation.org>
To: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com,
chengming.zhou@linux.dev, ryan.roberts@arm.com,
ying.huang@intel.com, 21cnbao@gmail.com,
wajdi.k.feghali@intel.com, vinodh.gopal@intel.com
Subject: Re: [PATCH v2] mm: swap: Call count_mthp_stat() outside ifdef CONFIG_TRANSPARENT_HUGEPAGE.
Date: Wed, 2 Oct 2024 13:36:42 -0700 [thread overview]
Message-ID: <20241002133642.9e9b82e53f2ff14f541d7864@linux-foundation.org> (raw)
In-Reply-To: <20241002195547.30617-1-kanchana.p.sridhar@intel.com>
On Wed, 2 Oct 2024 12:55:47 -0700 Kanchana P Sridhar <kanchana.p.sridhar@intel.com> wrote:
> This patch moves the call to count_mthp_stat() in count_swpout_vm_event()
> and in shrink_folio_list() to be outside the
> "ifdef CONFIG_TRANSPARENT_HUGEPAGE"
This is very apparent from reading the patch. Changelogs and code
comments should explain "why", and avoid explaining "what".
> based on changes made in commit
> 246d3aa3e531 ("mm: cleanup count_mthp_stat() definition").
And I don't think that explains the reasons for this change either.
So please resend with a changelog which fully explains the reasons for
making this alteration.
next prev parent reply other threads:[~2024-10-02 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 19:55 Kanchana P Sridhar
2024-10-02 20:36 ` Andrew Morton [this message]
2024-10-02 22:23 ` Sridhar, Kanchana P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002133642.9e9b82e53f2ff14f541d7864@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=21cnbao@gmail.com \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=kanchana.p.sridhar@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=vinodh.gopal@intel.com \
--cc=wajdi.k.feghali@intel.com \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox