From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A9DCF3195 for ; Wed, 2 Oct 2024 06:23:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABB5944017F; Wed, 2 Oct 2024 02:23:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4354440175; Wed, 2 Oct 2024 02:23:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90BE544017F; Wed, 2 Oct 2024 02:23:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 637E0440175 for ; Wed, 2 Oct 2024 02:23:23 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B66B21C6DFF for ; Wed, 2 Oct 2024 06:23:22 +0000 (UTC) X-FDA: 82627670244.13.2EF7899 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id B889340006 for ; Wed, 2 Oct 2024 06:23:20 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KHOYNLfM; spf=pass (imf04.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727850031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CoIq6U8qofHBQZGFVoSjI+GCS/TwH5xAxtMOanCM3vA=; b=hj5Pk0UEO8JxOwTZ8BOka6Lvl7e56GskfCBqys7gvGGuTq80ohr8T9wHRRHYzsXCvmRowW 6o5E27CGUueJGH06uCXQ7+IQIg0I8hfpfp2dKBhxM4ztQ/748EK+uBLS73hR9rVEVea6u1 HubkLDjAbh4K6mxbzneoRYiC8uwVX8A= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KHOYNLfM; spf=pass (imf04.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727850031; a=rsa-sha256; cv=none; b=RUHyN0DHCEiHDSGFKuuOxGwDoudPMjQu1Uwh1O5Dc9Ucv4Z2o77JI4T5zj0jABjieOQZp/ BU2Vnzw96f/xI4IgDzBkbNWIMSME4XblkcufkOB51Oa48cmgD57VvhMvKN5IxJ30ps2yV7 NP5BfNKmjocoNHeJqp9zAviFN0JHWMM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727850200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CoIq6U8qofHBQZGFVoSjI+GCS/TwH5xAxtMOanCM3vA=; b=KHOYNLfM6dmBdqQVanKOkVEphknBmEar7vkafClc0n2+PHPT/mcMVyJGC4ZVYgqTQZPv+S wMOz7aa5gtyW/Sc4TgOTQOnA3bXqe6dbEXnYyNqQ5EGSzLtioxjCUjP3ZlfZedjVZ6dnYX LOQRu1pPc5oiP/YanzpTfLUXVPgptmg= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-33-y3H0uhPmP4q3HNzJ2LXVCw-1; Wed, 02 Oct 2024 02:23:14 -0400 X-MC-Unique: y3H0uhPmP4q3HNzJ2LXVCw-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F3B1419560A2; Wed, 2 Oct 2024 06:23:10 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.196]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 30ABB19560AD; Wed, 2 Oct 2024 06:23:03 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 2 Oct 2024 08:22:56 +0200 (CEST) Date: Wed, 2 Oct 2024 08:22:49 +0200 From: Oleg Nesterov To: Andrii Nakryiko Cc: linux-trace-kernel@vger.kernel.org, peterz@infradead.org, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com, mhocko@kernel.org, vbabka@suse.cz, mingo@kernel.org Subject: Re: [PATCH v2 tip/perf/core 4/5] uprobes: simplify find_active_uprobe_rcu() VMA checks Message-ID: <20241002062248.GA27552@redhat.com> References: <20241001225207.2215639-1-andrii@kernel.org> <20241001225207.2215639-5-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241001225207.2215639-5-andrii@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B889340006 X-Stat-Signature: sybqgqrno9f9muai8ikgyunj17nk65e4 X-Rspam-User: X-HE-Tag: 1727850200-125550 X-HE-Meta: U2FsdGVkX18gevZeUMyQhzvySZyXGMa9wNTseer1RG1kmtrXYUwg18nXqGWsJ/9JQjEmORDbE3Y9+lwkhKjJEBdlNertadunRhfY0g7EtekNN4ld6lDDOPkP6n2Q0Oh8tKewSZDhBWQuy2rJqMx7sUDtrxq0MQaSy2QaP7ElQF0zzysjDAscOMsQXox+ldJ0VwRZaO6fyV4S85VNPK6+XsfuTp1qeSMdJJzLxaeeyZaVDkrYoMELN76KcoDegu1FAinqvk9KOkQFpxXX2MIDPvKZXI1o2A/6Ea2o2o2bdNhhx/6ZkxowTWaPt2icsRHj7KFJFTAOedrHK3urWgUYEk4Jx72+6xvY0BBfFTajrNFjO9Za+LQvnQBT595RBhihKd0Vr/KA9lZHLKoQNVweU8VBwghIRbEVmLEWjrz/nUjicQyAzPL8ijjRkckEo2KbK0k8yrOhcYsO70LOmxOatqRCxU9QRCYd22zMoQnUbDOcQOerXHzSrN5+Bv9eoc6kZIkJo1jTbfWYdYwFtEq6iL/tqiLW/vXPunSSNBN3eKqenvWodRZZ507/HOKg8+miDE+ZotfsT+++6nQ7s0hXtNB6BVxOQj3mN21VRlERCS1kHAa8wZDOFL2dq+JLrBns0GeLVmPm5J7LDghc0AEE7bgGc8kqyJym1fhLOvi5WJZ/AcuScvvUxIudw8UNE5hKDDnv5i3iSwnXZvVUNxC9Emf9UNfukuVt3mOoEAyDM4qrE7vQEBcTpndZe025n7EDhtJIsvjOyAGNYfJInJxeqG3oOn4aw2E0inXjbDP5ZZ31mV/bax4V6SlLXmnET5XctCNzsM4QY2fjcYb0UKNHdMubiBAIbp3bsLffDXCH9Se4oIjvWun/+2hR6KptLw1LtNksZ0idwpWQ1QgncXZloB0HBqcUrWiPEBGB2M91flS+ZLYUGvpzeR2w3fCQsXG9zqgRopbGjdBATX7tZH8 aOkSMAk6 HbKP8d1uv9tmW+/3bNJwWkQtfSvcY2fgK/qeu0O9fA3pxyJtd+PEgq3et3HUu36RkdT4iMpCcOD+kOnALj27IoErhd9L4Ujoc2yg52sU2qX9iNmF53VahwAaFpNrlAUNk2CEsZM2GgyezXhVnJVFumc1DP65dOJgATFEgJ58+7ifTbjGnE1UeicYvtfgB/6fkt0MneX9Vk+xcUnTZrLOKkha4DYW9A78AyZLbh8dKZXTJzPbHi+MB2M/B6dEbot5VSh3FLVmK+oXjrnjgijowWNfN/EFw8uBNM2eZOBF4VJdGOZ7I1HvwEFF72b4ovoy7FuD1Z53O4XyWS102v+9wdBmFnspxGJ2oGf7EINM887S/vEqCs+nfJY1ZxPWeXx6Wx3ass/VSyaZOdjbOONvGtCTIMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/01, Andrii Nakryiko wrote: > > At the point where find_active_uprobe_rcu() is used we know that VMA in > question has triggered software breakpoint, so we don't need to validate > vma->vm_flags. Keep only vma->vm_file NULL check. > > Suggested-by: Oleg Nesterov > Signed-off-by: Andrii Nakryiko > --- > kernel/events/uprobes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Oleg Nesterov > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index a2e6a57f79f2..7bd9111b4e8b 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -2091,7 +2091,7 @@ static struct uprobe *find_active_uprobe_rcu(unsigned long bp_vaddr, int *is_swb > mmap_read_lock(mm); > vma = vma_lookup(mm, bp_vaddr); > if (vma) { > - if (valid_vma(vma, false)) { > + if (vma->vm_file) { > struct inode *inode = file_inode(vma->vm_file); > loff_t offset = vaddr_to_offset(vma, bp_vaddr); > > -- > 2.43.5 >