From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76E9CF3194 for ; Wed, 2 Oct 2024 03:19:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3F776B012B; Tue, 1 Oct 2024 23:18:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEF886B0173; Tue, 1 Oct 2024 23:18:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98F5C6B026F; Tue, 1 Oct 2024 23:18:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6FB476B012B for ; Tue, 1 Oct 2024 23:18:59 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 88082403D1 for ; Wed, 2 Oct 2024 03:18:58 +0000 (UTC) X-FDA: 82627205556.19.4C4EA3E Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf26.hostedemail.com (Postfix) with ESMTP id 95588140005 for ; Wed, 2 Oct 2024 03:18:56 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=G7s6KJHn; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727839033; a=rsa-sha256; cv=none; b=Hjaaqpu2SbQONRQZ8attmWD4sr5BeCL3fpCZsu1mTnVcu3UGXpK/L8jDmVZrcVXs1zJhpK L7w0oNlcSvq9yGvlEJ4P0FeLQM2ng06hxUerFsN+Rlg3Mz801oKfz+9rn4Ma3as9CrtqrN l6HSqvZlCbZpH33pQGSDIn96fnnNXx4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=G7s6KJHn; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727839033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=00LDcROEMqvWeinbcoEjEcHLwHipcWBtgKWf9IRMo+c=; b=jSeVJMKXfYIkZzgx3/WXrc7Vra5XqdbgmtT+CA6Q93l3ut6NyM6nrZp7g+flz+RocKnBXw +xRYyFPMkW/z2uzaUqcn6VHwDEl47LoAihg9a5UAaKVCwfAfkwzl3VcKCP6aicwhJWBm8Z n2yCuP/VsCllBWLO1WgNM0vwwMPY9jI= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20bc2970df5so6980715ad.3 for ; Tue, 01 Oct 2024 20:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727839135; x=1728443935; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=00LDcROEMqvWeinbcoEjEcHLwHipcWBtgKWf9IRMo+c=; b=G7s6KJHnNALxWBZWYF4Zgm7SYarxwTCZONpU6kA+v1ymsD6dvIQZ0l939aE3EOrzaE jvqoOQqZaVTv9qXACquEbLXYnSm9ZoOQ/Uh9GYiJSubZfpwf/KvT+S8AlIr6VDpPRGcN LKXETphhquDoETQcPkpWpLcJE5q0uHRsp/LcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727839135; x=1728443935; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=00LDcROEMqvWeinbcoEjEcHLwHipcWBtgKWf9IRMo+c=; b=P2DcdtlN1N3mmsPkHbq6YQcrwiWI/4Yf55s0vAihY/L4hPVk+FLDi3crAL8qn1CEy9 Th5FSqAr/VqudHc9/YzaJEwsNEqYy6aHZ3U0OjLKr4uM4+pct0zov4y9WNJN6/EBvru8 MjPywdx6scdUi1EF8e32BCM24WqhUkg8kshano0TxnpvZ6gBejWiyrPTTvEeR5H126zE 5lkcskFBFbB3yeKnbX91jmCNYFQzP4g8MKSnpSeVl1mX4jen7WMJAhziYTn7QxKjXjT6 RxdgatKhagGvcyirmZBMmu25xGN9Y0q8nCmc/6kANYWh5pVbzRbepaHj4UswXAiz1LJh oTnA== X-Forwarded-Encrypted: i=1; AJvYcCURdYGWHEho+QjxP4FqywzmX5D8wj9Yo3Gr8bVxCktonZtNU4svBYqUsjz8XhxP02r/9771YJHj7Q==@kvack.org X-Gm-Message-State: AOJu0YzjmRhBlYRCZN/FWeu6Keb5bpdeZiIEAXr5UBe+kHvlLBuGVlQb DjhScc6nT16J3pw3TLpaKDIDIrTzn74eF/A7qWTpQqqdH+0dE2fCvGG5avPUAA== X-Google-Smtp-Source: AGHT+IG/t+BpAn6gYcxJkVP6Y44GdpkycmxdlXzbfQvcDvAvrMikUtY5nEES9IiucZUn+sgLVWbsbA== X-Received: by 2002:a17:903:60f:b0:20b:af36:ea5 with SMTP id d9443c01a7336-20bc59c3584mr20822795ad.18.1727839135055; Tue, 01 Oct 2024 20:18:55 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:8dcb:9ffe:3714:b8ad]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37e61e14sm76516435ad.279.2024.10.01.20.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 20:18:54 -0700 (PDT) Date: Wed, 2 Oct 2024 12:18:50 +0900 From: Sergey Senozhatsky To: Pintu Kumar Cc: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, joe@perches.com, skhan@linuxfoundation.org, pintu.ping@gmail.com Subject: Re: [PATCH 3/3] zsmalloc: replace kmap_atomic with kmap_local_page Message-ID: <20241002031850.GJ11458@google.com> References: <20241001175358.12970-1-quic_pintu@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241001175358.12970-1-quic_pintu@quicinc.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 95588140005 X-Stat-Signature: ka5wq6icbq9wy6rhi5iu854duz46ky8y X-Rspam-User: X-HE-Tag: 1727839136-980256 X-HE-Meta: U2FsdGVkX1963LFiVhae7jmM9iUl1/eSTAZ7rheKO1YI/uF5yPkecDXc0fZXXqkclsK1kqi7WN2Cy8oiBeX102vbE0apTxO0peDBM2cNmKb3juIuV2yXsk8CwV2wmQN7XvDH9fFgbIDnHAosEBR42P20ssjlO9bC/Nc75dLpvttF+SiGJbf6dR9gg4P64B5Qjj/qyb0TD9c+iSzpoX77OOyQba51rrlYcj6EzA1b8fTT3LMVbkrdxaUCoH31ZM3NEZkZFwyGYrj24TcoPMOvV4xs7IerHaWFWEV3nnTpun/fP753cP74JHUfLebIolRcIK1inQaEDGF3uSWAzLFdVOOBUy/5ErTk7vdUmwVZB1xL7E/yQ3qMJBEysBbEJcEWYoPBPqUsVsJ4jXKb8GNBjUL3mtyFzrBVEDgVH1CaH680wh9UL61VmKlgufsngWQJ/CUp8PD0MzBx128R5QcyPP2QWjWMpRy61H0eKRx6LUcSjd7xeK8LwaaG8uUJs7l1/FN45dva4jHZnkZXcVNtnww1J0GRauOKt+ETJQ02ysOuVpO2rwrBaojvHZXg1O3Gbah6oLJKfAB6ruYTfCRxG4VORo02GLXrgrN6m0ssNMnuZUsaDpbPpNizrLVe1pyC8uFEiDglAWOfa/tm7+6FIXHKnRZhEPfyQAEY43XjWtpE9HUPGUqBF8J2qSZcWC75xNRJ3qCfQtbUliGyGmylyaJIn/TcdzXX2fL4oDBgLol9vH8sGaJLxqDyPWRAR+ApcHgdvN0i/cp3UayNLOX0tuxXKNmOfN8XOmGObmP47ZWicEwkVBUhHs1e1j6a3V3bJWCkUfkmaJIMrZQZ3mnf68HQ1SZyB+pm30bC12hmn866eU3wvSv+Yox5PjbY0uYTaWTfbPUhA04BmUfJeA+Qy8r+oS1HZC4qUDqMko+sDkXCwr50zcLybk5lBHSeboXqzzX9DYxGAztZf2/1yhx M7Nayjmv cuNyzB3laSh7gDU2Dp5P/7sCVapDQ+YQnslVPlCf/df3BA7KNlzs0FmwU13S5bq+gUgy8wr59t0CLbk2ikVn8OkKrF8+3XTOzirT7kBGnRLplEaXps7qQEiqdVg2foSaYB6DF+G9ZWxguLxgFI5o196phqxRKrE1IN6V6yGwFnCg/2skeHeztMOG/UyrFLZ/CVjzBF4OjvvDicZq01gIX4A5mvhKRIFif1l9qhrK4FBcGGWXMRCl1YdYo88Bshlsi8Wpi2G/1nWa8gxNmPf1dQdCPvqTODqDCAoHhyaw6qveWJDrF18RxHbZjPpuD/zU4cDqqmNYgpz0Zb15hNK3UO8qOyi5Fh+mnBMVn3Z9GB9j+z+o5+qHXG5q4T2aXZx74BEl+xo1YUsYDY7XMcLi3WP1LUz7HEFt0TqJCDXAt18+T0ZbNJ71E07mBh1KSB3AG3McYOo+xIaYCAi6CQi5/3um2Ju4ZVFfKbVjR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/10/01 23:23), Pintu Kumar wrote: > The use of kmap_atomic/kunmap_atomic is deprecated. > Replace it will kmap_local_page/kunmap_local all over the place. > Also fix SPDX missing license header. > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > WARNING: Deprecated use of 'kmap_atomic', prefer 'kmap_local_page' instead > + vaddr = kmap_atomic(page); > Can you also update the comments (that mention kmap/kunmap atomic)? --- diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index d3ff10160a5f..5c3bb8a737b0 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -263,7 +263,7 @@ struct zspage { struct mapping_area { local_lock_t lock; char *vm_buf; /* copy buffer for objects that span pages */ - char *vm_addr; /* address of kmap_atomic()'ed pages */ + char *vm_addr; /* address of kmap_local() pages */ enum zs_mapmode vm_mm; /* mapping mode */ }; @@ -1050,7 +1050,7 @@ static void *__zs_map_object(struct mapping_area *area, void *addr; char *buf = area->vm_buf; - /* disable page faults to match kmap_atomic() return conditions */ + /* disable page faults to match kmap_local_page() return conditions */ pagefault_disable(); /* no read fastpath */ @@ -1099,7 +1099,7 @@ static void __zs_unmap_object(struct mapping_area *area, kunmap_local(addr); out: - /* enable page faults to match kunmap_atomic() return conditions */ + /* enable page faults to match kunmap_local() return conditions */ pagefault_enable(); } @@ -1510,13 +1510,6 @@ static void zs_object_copy(struct size_class *class, unsigned long dst, d_off += size; d_size -= size; - /* - * Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() - * calls must occurs in reverse order of calls to kmap_atomic(). - * So, to call kunmap_atomic(s_addr) we should first call - * kunmap_atomic(d_addr). For more details see - * Documentation/mm/highmem.rst. - */ if (s_off >= PAGE_SIZE) { kunmap_local(d_addr); kunmap_local(s_addr);