From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A28F8CF8540 for ; Wed, 2 Oct 2024 21:28:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBED16B0450; Wed, 2 Oct 2024 17:27:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCFAD6B0452; Wed, 2 Oct 2024 17:27:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5E4C6B0451; Wed, 2 Oct 2024 17:27:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8AFDE6B044C for ; Wed, 2 Oct 2024 17:27:54 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F133F40FCB for ; Wed, 2 Oct 2024 21:27:53 +0000 (UTC) X-FDA: 82629949626.27.E488D61 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id 2BE95A0015 for ; Wed, 2 Oct 2024 21:27:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tzCXJ6wf; spf=pass (imf25.hostedemail.com: domain of jlayton@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727904344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2niIZp+S6Ffg2N//A/i1ylAEzsQj1OJY1M53VeI4qYQ=; b=IlEGI9rIcRNZ5enXYHZ+FCjUU511pVMkmNkxgJnKsUrfXvmFKgeveL2Bmfgoq+NMUi28hZ yaWxg023IU6IYlwJUcOaZinThBzrj7N4bt3QMFzZP4jzJhBqBBB06ztIHa854RSuJEouW0 3EYXPV7fY3kluN7bafVFbbjZr8kxiwI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727904344; a=rsa-sha256; cv=none; b=JK2lZ58fwayNDDCGIzQ/LPFL/VqYHgIIA5nhyHxrA74zV009ets6ITuv6Bm9l7Z5z59Dsq B1Px7qH/rhKgQQcpOGumwOOrMmvgnKn2my9Vc+e5OT+NJxBoBApJoMEoB6rL1npYpNQAx2 LyZ6lwz9z65XGYlb5H3LIOLSRgJ/Fps= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tzCXJ6wf; spf=pass (imf25.hostedemail.com: domain of jlayton@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B83A1A42600; Wed, 2 Oct 2024 21:27:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17306C4CED1; Wed, 2 Oct 2024 21:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727904470; bh=Z8ARvNSJ2qaGQw9gXXGsklzintCaz0parTyIMYimjOU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=tzCXJ6wfC5VMb2ExRKKrzQ20m0/cMA8alt1mx22BM50xuDhE0GS9gVEFsrjSveh5f HFH5VS9B24S84IqvZUpSgC0C1q24ouXK3xTB7RbQfG8UaeRZcICfAK6HDjmfFkfBV7 3aO9o2M1mNeM3mDVEnXkN4uh72RWd1d3J5IlhvmQyO4+hhMRETQlHKR4X9G6/DFhRe YSYJkbBlozjLOXMmaq1m2Gt9EFtR/FJhOO+7ql9Vva32Q75BFsiORHAqNQJqujNmqW SBn90QVLpNFHTeIS+z4r+VmFCXvrhebJ9B4yq9M8D2P5LJh1lY5wtzoECPs6IH+MI2 QP5O6BUQzp8Rg== From: Jeff Layton Date: Wed, 02 Oct 2024 17:27:22 -0400 Subject: [PATCH v10 07/12] fs: add percpu counters for significant multigrain timestamp events MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20241002-mgtime-v10-7-d1c4717f5284@kernel.org> References: <20241002-mgtime-v10-0-d1c4717f5284@kernel.org> In-Reply-To: <20241002-mgtime-v10-0-d1c4717f5284@kernel.org> To: John Stultz , Thomas Gleixner , Stephen Boyd , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Randy Dunlap , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Chuck Lever , Vadim Fedorenko Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3654; i=jlayton@kernel.org; h=from:subject:message-id; bh=Z8ARvNSJ2qaGQw9gXXGsklzintCaz0parTyIMYimjOU=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBm/bq/TMaGYuw/cJFUuusrG5sD9Gz0d9qf6qw5y upmhOuFiF6JAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZv26vwAKCRAADmhBGVaC FRvxD/9evDrf3HGvYTuhxkxutkxIEi68sVhkiNZD69Mm7WZA2CzmHFpkbIzJUXlNfytAPvjdSGx Se9Non3XuQRLNglgc0lhxcfcZdu/X+u5yMiBvHkBZEf5lodGBnhBUeXjm4jg9rEign2Xcke0uen zmW17gVIHwMZ3pm48WdgDnI8LGujnHwyRtaKHMgoMO1zgnVvcxwJwwUnejPgDLsmruCTvs+3DcO Y1qi5xwXYC30GgA8xLI3gOheiXnZPH7tbEJ+CH8lRjel+ECcxNYyb4BgLgnjumPTmVu+ctbB3O/ NyFL+R7Pi0fN4SNBqZmhwLTUJrcqb7DCkLXIHsvJwkrbW3Bqnf24X7QYDnJtEJQ9zSf7lLcSU6k V+ew1hvKLd2wb+drV/Ii7HSHdlUZvaWrk8oHWdjSCKLvUAmjwdajzx9wmNWqXhGfXmTr0ecFsKA NXFHfSfVYvzOmgE53f2k3i5mgVRZyIhHJUlyjRFJKFGzUxYaTAIh5NNmXRgDtW4ppFtQH53Hxhu kp4ZqjZv2oO3ibhlxc5JK1fBHr6GVEm5y/b+JdsECtsh3oy/dqkLWdOAHXM5vNLGLzaBO7Qa7Ds CYD7TxCxZPUyWMagc0FhPLEfyvMm79Aw6QZdmp6UVnPQO6c8VRfeyGOyuivKJVQaMeSbXMaQuV2 JHDiBQHJy0omjwA== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 X-Rspamd-Queue-Id: 2BE95A0015 X-Stat-Signature: bg7eiwefiucguhi9ef7kjg8e3onk8rfz X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727904471-43905 X-HE-Meta: U2FsdGVkX1+zrzriE3AmiGev0E+IzuGnf+IDXahjbXemeR4tdAb/SCp/wrPQElveLfi3eS6u+ag95ZYvl+OOgeIe2fdy/9Dk+AqgFt9ZL2Ku+FCCvsGzeja3u1FgBC+1kRAsMZ2QtYXbsJ6t0SX3hw68DH2OBPrWOaxhMMgxA3p/c2ytf/ToJdG/ifDaa4JQ/NRSkSulU6CH2SEt9ip7yMa9SMcylrXxfNXn2UqFGNiNVwoksU6SAfQvnxhuHXBdj+XDSs+JuwpuDymMS6nWakzD9oEtvUJQogC0te/3Tt4kO+/Gw8Tpayw+7xfLg4SXzLF1vwUByY0zwsmoh2mLgjBfICk14lkeJQyucbFcgrjLwsQx5Ejd4bwk9HE52uzaadI+Zene8nwugIHocvAcgE7taYF2U7opxolMulsl/dOsjJm/Jj8Jv/maH87coFOkKL0tCNdATFm+xE0JPlD8RJ5R9l8Yt4rpOdRawv6v/ioi7uGIN83kL+oLy1qjMRCyuzKgOG30AdXu5PdzO/KgLxqTlGUDpcAFzEacWV/EWJOYrJrw/WL7ZEPtQwD96OsFHY8Qn0BmRUFzW3pnuuTcWeMW+dI5AcePiDMv3AeaI1N71A3lZrjy+dSVk/DvGW/g9ZLZcULJZ94GMDpl6UsxQZXW6Hvwe+PV5WNGMNuy5DtRwLyRRQA1g1F+lpCgMXM5phe81BsBEVz5l30mvtfy+IUmmEprf0h2Kkdw1l9PWgaCAJ5Rf3aiia8mMzWkABg1N7F4UPzM8t2wDTkAdan+PfWw14FT5l2RDn2hpQpl+TCK9pJs2wDP9qF4rxAwCZkMloDtjQnENI8TtsMjd+0Xh5FBIDnevB/ve5QYTeb9/J+K9MgZ7L3gnuX7MgK5wzdnfGnWQ/MKwcvOrWoCVc1eh+AqC/ZJImBTjkPC9fAFqzZ/1K9lE2okxCpaR6v+cAXt3MmewCKZCGgyRIfBGIV IgFbNMDI /fWs58LHAFXlabWIzLWxFnpW9gYPviX6BApithS9fH4k71lfshf96JoXl3kzWIMtPcJ0vlZHjOdbVjB621M2khTN3Bwckg0sICAepL8aY0e53ah0GSftQW0rEudpTLFRyFDo9bWf1900yoBA8K8sIRoc062Di7kYJ//YzkYkKgTPyHE36TeP1yBQA0//84PPJbrPkXS89ud6HRRBXAcafoA/JtJ8/id6rngw1GYwrnRhSRIfscSbHd1YfNZa20AWNmIhM02UAOSbAm3ZqlJC4k75JWtwpuHzGk4A+vO2Vy+4x5ZiV32ut3skmBbrqLvzHM7PlxpVs+9+FTTPE4dvCI8K9LsNijwO0eKndrLLgTb8gvFE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: New percpu counters for counting various stats around multigrain timestamp events, and a new debugfs file for displaying them when CONFIG_DEBUG_FS is enabled: - number of attempted ctime updates - number of successful i_ctime_nsec swaps - number of fine-grained timestamp fetches - number of floor value swap events Reviewed-by: Josef Bacik Reviewed-by: Darrick J. Wong Reviewed-by: Jan Kara Tested-by: Randy Dunlap # documentation bits Signed-off-by: Jeff Layton --- fs/inode.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/fs/inode.c b/fs/inode.c index f7a25c511d6b7069fa235135cf3bad0cda32815b..6d501c7308aefcbb8001d64cb46e57f1839b8a3b 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -21,6 +21,8 @@ #include #include #include +#include +#include #include #define CREATE_TRACE_POINTS #include @@ -101,6 +103,70 @@ long get_nr_dirty_inodes(void) return nr_dirty > 0 ? nr_dirty : 0; } +#ifdef CONFIG_DEBUG_FS +static DEFINE_PER_CPU(long, mg_ctime_updates); +static DEFINE_PER_CPU(long, mg_fine_stamps); +static DEFINE_PER_CPU(long, mg_ctime_swaps); + +static unsigned long get_mg_ctime_updates(void) +{ + unsigned long sum = 0; + int i; + + for_each_possible_cpu(i) + sum += data_race(per_cpu(mg_ctime_updates, i)); + return sum; +} + +static unsigned long get_mg_fine_stamps(void) +{ + unsigned long sum = 0; + int i; + + for_each_possible_cpu(i) + sum += data_race(per_cpu(mg_fine_stamps, i)); + return sum; +} + +static unsigned long get_mg_ctime_swaps(void) +{ + unsigned long sum = 0; + int i; + + for_each_possible_cpu(i) + sum += data_race(per_cpu(mg_ctime_swaps, i)); + return sum; +} + +#define mgtime_counter_inc(__var) this_cpu_inc(__var) + +static int mgts_show(struct seq_file *s, void *p) +{ + unsigned long ctime_updates = get_mg_ctime_updates(); + unsigned long ctime_swaps = get_mg_ctime_swaps(); + unsigned long fine_stamps = get_mg_fine_stamps(); + unsigned long floor_swaps = timekeeping_get_mg_floor_swaps(); + + seq_printf(s, "%lu %lu %lu %lu\n", + ctime_updates, ctime_swaps, fine_stamps, floor_swaps); + return 0; +} + +DEFINE_SHOW_ATTRIBUTE(mgts); + +static int __init mg_debugfs_init(void) +{ + debugfs_create_file("multigrain_timestamps", S_IFREG | S_IRUGO, NULL, NULL, &mgts_fops); + return 0; +} +late_initcall(mg_debugfs_init); + +#else /* ! CONFIG_DEBUG_FS */ + +#define mgtime_counter_inc(__var) do { } while (0) + +#endif /* CONFIG_DEBUG_FS */ + /* * Handle nr_inode sysctl */ @@ -2689,8 +2755,10 @@ struct timespec64 inode_set_ctime_current(struct inode *inode) if (timespec64_compare(&now, &ctime) <= 0) { ktime_get_real_ts64_mg(&now); now = timestamp_truncate(now, inode); + mgtime_counter_inc(mg_fine_stamps); } } + mgtime_counter_inc(mg_ctime_updates); /* No need to cmpxchg if it's exactly the same */ if (cns == now.tv_nsec && inode->i_ctime_sec == now.tv_sec) { @@ -2704,6 +2772,7 @@ struct timespec64 inode_set_ctime_current(struct inode *inode) /* If swap occurred, then we're (mostly) done */ inode->i_ctime_sec = now.tv_sec; trace_ctime_ns_xchg(inode, cns, now.tv_nsec, cur); + mgtime_counter_inc(mg_ctime_swaps); } else { /* * Was the change due to someone marking the old ctime QUERIED? -- 2.46.2