Re: mm/damon/reclaim.c:252:15: error: implicit declaration of function 'damon_commit_ctx'

[SeongJae Park <sj@kernel.org>]

From: sj@kernel.org


Hi Robot,

On Wed, 2 Oct 2024 02:09:06 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   e32cde8d2bd7d251a8f9b434143977ddf13dcec6
> commit: 11ddcfc257a3e8d7b13b42148ee7e783f4876da4 mm/damon/reclaim: use damon_commit_ctx()
> date:   3 months ago
> config: x86_64-randconfig-001-20231120 (https://download.01.org/0day-ci/archive/20241002/202410020227.oOh0SBIj-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241002/202410020227.oOh0SBIj-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202410020227.oOh0SBIj-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
[...]
    mm/damon/reclaim.c:247:15: error: implicit declaration of function 'damon_set_region_biggest_system_ram_default' [-Werror=implicit-function-declaration]
>      247 |         err = damon_set_region_biggest_system_ram_default(param_target,
>          |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> mm/damon/reclaim.c:252:15: error: implicit declaration of function 'damon_commit_ctx' [-Werror=implicit-function-declaration]
>      252 |         err = damon_commit_ctx(ctx, param_ctx);
>          |               ^~~~~~~~~~~~~~~~
> >> mm/damon/reclaim.c:254:9: error: implicit declaration of function 'damon_destroy_ctx'; did you mean 'mm_destroy_cid'? [-Werror=implicit-function-declaration]
>      254 |         damon_destroy_ctx(param_ctx);
>          |         ^~~~~~~~~~~~~~~~~
>          |         mm_destroy_cid
>    mm/damon/reclaim.c: In function 'damon_reclaim_turn':
>    mm/damon/reclaim.c:263:23: error: implicit declaration of function 'damon_stop' [-Werror=implicit-function-declaration]
>      263 |                 err = damon_stop(&ctx, 1);
>          |                       ^~~~~~~~~~
>    mm/damon/reclaim.c:273:15: error: implicit declaration of function 'damon_start' [-Werror=implicit-function-declaration]
>      273 |         err = damon_start(&ctx, 1, true);
>          |               ^~~~~~~~~~~
>    cc1: some warnings being treated as errors

Thank you for reporting.  I tried to reproduce the issue following the kind
reproducer, but I was unable to get the error.  Maybe something in testing
setup is wrong?  Please let me know if I'm missing something.

    $ make W=1 O=../linux.out.kbuild/ ARCH=x86_64 SHELL=/bin/bash drivers/iio/accel/ drivers/iio/chemical/ drivers/iio/dac/ drivers/input/touchscreen/ drivers/mfd/ drivers/usb/host/ mm/damon/
    [...]
      CC      mm/damon/sysfs.o
      CC      mm/damon/modules-common.o
      CC      mm/damon/reclaim.o
      CC      mm/damon/lru_sort.o
      AR      mm/damon/built-in.a
    [...]


Thanks,
SJ

[...]