From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C31F7E7716C for ; Thu, 5 Dec 2024 15:21:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 739E66B00FC; Thu, 5 Dec 2024 10:19:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B856B00C4; Thu, 5 Dec 2024 10:19:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 580406B00CA; Thu, 5 Dec 2024 10:19:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 338CA280068 for ; Tue, 1 Oct 2024 06:43:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D6858120FA3 for ; Tue, 1 Oct 2024 10:43:57 +0000 (UTC) X-FDA: 82624698114.06.55911AE Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf11.hostedemail.com (Postfix) with ESMTP id 60B384001B for ; Tue, 1 Oct 2024 10:43:55 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=pBxk9Pfm; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of gerald.schaefer@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=gerald.schaefer@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727779396; a=rsa-sha256; cv=none; b=7w95c+DQMEO5MCvwizRYbyRZaFIJk18u44RTC0N/VsUr96r2LjXnrCeFdXUfup+9I93Ap2 RIMAF9mdwXbG7X0RO30Y8KV7np7H4xcx/PdLLAvpdosTb8shxjCEYzPDThcjxXM/JVbBjd 0vg88iVXSVs9vZy1loFbNkFdgJJRFVM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=pBxk9Pfm; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of gerald.schaefer@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=gerald.schaefer@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727779396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EbBiI8fSH5VnllJ71ly5Ye4ZTPDlUiVslkZDSkOv6TM=; b=GiLq5s4fQpQffiKyrkKL2xD6BJ3IoKqi7H2mQ/TbDV+sVJF79IPygpd5KJRCji7AQmnkiB Mh1QBnL4EKg1oj8yKX+vacIw9ubq6K136UTggY6vnzcpZDJ4/GXiFWpeJGCWeRa/mYbOqO +eI+s9odeqe/rDbrElh9geDWLnBWtH4= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4918rlWA024393; Tue, 1 Oct 2024 10:43:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :content-type:content-transfer-encoding:mime-version; s=pp1; bh= EbBiI8fSH5VnllJ71ly5Ye4ZTPDlUiVslkZDSkOv6TM=; b=pBxk9Pfm6EsDfF8Q iqUeM1FnmtgX53pJ0O39C77AAcD1MIdHs8EzC5/ri4wCzexHaBfbeu3XYa1MNuhr eJrsmHuxPqK6cm0vGct98JM4U0+BUpFDBIcM75UI2ScI5N02e5xkS/ZCRMd7H282 0Azl1ZgHYpCgJ3MZcAcj0rOj98AnwTvyYi5mze3SorxyYhOkaYp2FtXLOXNJcI52 vEg06YOiEqDQ16vL/o7a57SNphNSGtYUIFyzUt0oHvIjsnMTnIidLPO3Lj1/hyEz LsPSeSPcRqZNO/wijZXbh9gF2+zp3bNZDbNFs7t3r9v9lstbldRgfcOJYDlRXbAa 2FQ1xA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 420ckngyg5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Oct 2024 10:43:19 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 491Adrbv020483; Tue, 1 Oct 2024 10:43:18 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 420ckngyfy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Oct 2024 10:43:18 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 491AViee002356; Tue, 1 Oct 2024 10:43:17 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 41xxu13f3a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Oct 2024 10:43:17 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 491AhD4A18284834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 1 Oct 2024 10:43:13 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6B84420049; Tue, 1 Oct 2024 10:43:13 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8521C20040; Tue, 1 Oct 2024 10:43:11 +0000 (GMT) Received: from thinkpad-T15 (unknown [9.171.59.94]) by smtpav06.fra02v.mail.ibm.com (Postfix) with SMTP; Tue, 1 Oct 2024 10:43:11 +0000 (GMT) Date: Tue, 1 Oct 2024 12:43:09 +0200 From: Gerald Schaefer To: Dan Williams Cc: Alistair Popple , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 05/12] mm/memory: Add dax_insert_pfn Message-ID: <20241001124309.782004b8@thinkpad-T15> In-Reply-To: <66ef75e59c7ea_109b5294d1@dwillia2-mobl3.amr.corp.intel.com.notmuch> References: <110d5b177d793ab17ea5d1210606cb7dd0f82493.1725941415.git-series.apopple@nvidia.com> <66ef75e59c7ea_109b5294d1@dwillia2-mobl3.amr.corp.intel.com.notmuch> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Content-Type: text/plain; charset=US-ASCII X-TM-AS-GCONF: 00 X-Proofpoint-GUID: mLp8W3ZTWJaathMCFPKloMnlrxlln_bF X-Proofpoint-ORIG-GUID: 5FfpjjtfUKsGqxfrBWkGoY0YounV3Quc Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-01_07,2024-09-30_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=928 mlxscore=0 priorityscore=1501 clxscore=1011 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2410010066 X-Rspam-User: X-Rspamd-Queue-Id: 60B384001B X-Rspamd-Server: rspam01 X-Stat-Signature: exnnn3quxc38f657hjnxzko5mujxz5gk X-HE-Tag: 1727779435-414318 X-HE-Meta: U2FsdGVkX19h0JUpOHC6MKXrpPAOx8RIHUXnmnI8LW3nogcb/u8oKnjo6Frx2/i40YFR/EKluP/OnKcHZMwJJPDkj1cCXh2lxcR7j49D88vZCz9Z7InyJX38bcZhI01/82wKdYRWVlyPe+MvnpOq7D98uo7mzAvYhokdEQpQmQy2Fo5Ph3uEQIpV9b+dAp+S572NwflFOFAtYuTbhXB94xvByB/imqWQt9egPYoeWsPselUDGi7aKYwgl8cKgv05YR+Rsf3AcbsyNjFVJheh4JHduPOse8Ayqr7ebigGA4avX8xwUhRF6v0TiWMdAHPrf2Y8BdGlznKRSXoXwKJzf1vJ61t2RR/pcStawZNJLosc/6+iUfpUoTtfzruD2qey6n4u37zVcDhhxhB6I3TfFz7xRw2HOrzKiT5xR5rBGHjiIf1auefxrZtlA7bPiMNLJzN9ZxS/0C1L0/fSPpkM5FPAX229UOz0qjx9U2rrYKBrYvDhKXJiM1W2Dd2aSRCEeQVd+kjZhcgdsbWtUtYvxLzoDpjI5zRHJI32+Bbhg7FHPZBIotca+rrUjQlwk1i8Zzpjvoz74owexcAjIIDqqqOGAQ0c5FyIdH4oZ4f2gkqwjvcNmYQXnpR9ZELVHiKsRqIMi9wqzyG//m30tDLbio/nD6bC+M36UOIxBg0pugZQLLSvEqraRz0oce/NBjO9xBwRlS/rxiAOqZBI7zaO5brF93j4WAzInSD4PzKJN8FDrmxMxgeHmGTnIF4UT7GdU98ncjFNa2kaHSigNe36GldxUuqgygG8Xt9sGG6ttNgVFfqfSlvl+SGyq3Mi+6kdrJL0ZZXnfcBY2PfbYSgwEM3pWg1oEl0fq9lUlVsIecJgDRWYmoUjyIpaJEzmSHgNHJQucNd4qNyAqfDpPxZHI33XBMcKnO6sTrDE1EbhICnW1qujLqQw2VtLEP6mZJZDKO0n5m8OvtKqntutdM/ 4NmkhcYb NKSfIn18h7uQF01Z1LqEmVQnyRFB13rXSifO/pXSTcbfG+XSMpJD/ZMdwEO7roy337cEJPWJFKErOTe3wMe8QS95MY/qU2hp5fsM1KAqKGOZxKbyl5DLL1XiqLXuFJ1MegM7ZZ5x5eebKlaciX25D9A1kbxUMRHHJj0ZI1DlsFDCWzOrz5/9ExPnoHSReJTXOQ5kaLNFhQWSHwJnca5M4myrF0/2DMEgT/+1b00A41IS5crCiSgHw7WvaoHGNWDCMHYAk6mtj/v2cPw2oCzC2qh+x76iVJW+zENP7RONAgjyU7FIFMgOb5VXvEBrz5R7p05m0XQCG8fC5WHl0Qo/5P7/Zzjv0KkE1DSZ06ivRlB6cMXmz6t6g3KLBxtcrWs3sn2YAtwmzmkOqKnoUj4pHlVGN/4RCp6g+iyog4MKIKnGnzv37Vfrfz+fvjGIy4zgVgS3M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 22 Sep 2024 03:41:57 +0200 Dan Williams wrote: > [ add s390 folks to comment on CONFIG_FS_DAX_LIMITED ] [...] > > @@ -2516,6 +2545,44 @@ static vm_fault_t __vm_insert_mixed(struct vm_area_struct *vma, > > return VM_FAULT_NOPAGE; > > } > > > > +vm_fault_t dax_insert_pfn(struct vm_fault *vmf, pfn_t pfn_t, bool write) > > +{ > > + struct vm_area_struct *vma = vmf->vma; > > + pgprot_t pgprot = vma->vm_page_prot; > > + unsigned long pfn = pfn_t_to_pfn(pfn_t); > > + struct page *page = pfn_to_page(pfn); > > The problem here is that we stubbornly have __dcssblk_direct_access() to > worry about. That is the only dax driver that does not return > pfn_valid() pfns. > > In fact, it looks like __dcssblk_direct_access() is the only thing > standing in the way of the removal of pfn_t. > > It turns out it has been 3 years since the last time the question of > bringing s390 fully into the ZONE_DEVICE regime was raised: > > https://lore.kernel.org/all/20210820210318.187742e8@thinkpad/ > > Given that this series removes PTE_DEVMAP which was a stumbling block, > would it be feasible to remove CONFIG_FS_DAX_LIMITED for a few kernel > cycles until someone from the s390 side can circle back to add full > ZONE_DEVICE support? Yes, see also my reply to your "dcssblk: Mark DAX broken" patch. Thanks Alistair for your effort, making ZONE_DEVICE usable w/o extra PTE bit!