From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA461CEB2CD for ; Tue, 1 Oct 2024 00:22:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59F41280041; Mon, 30 Sep 2024 20:22:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54E58280036; Mon, 30 Sep 2024 20:22:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43D2F280041; Mon, 30 Sep 2024 20:22:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 24BD3280036 for ; Mon, 30 Sep 2024 20:22:14 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BE5D8160D0C for ; Tue, 1 Oct 2024 00:22:13 +0000 (UTC) X-FDA: 82623131346.28.0C5B86D Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf06.hostedemail.com (Postfix) with ESMTP id E2B04180004 for ; Tue, 1 Oct 2024 00:22:10 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=HiStneaZ; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727742067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vmEMUmiLlB6m/T/P5xBRLncvNWoi4hp4LZTs+dQITMo=; b=Kjg5WBr7KTZunqJkaFQcIihuqUi/Rw53vF0dsxclS9CDSiek7b6dHcvBcKKXVH0P1yYfQf baSpa7nITjhPlesCoQ5EUrz4HdnqMc4iSa0vFTGJCfrlMuNz2b1gJEJcXs2hK3svmjbMOr tJWmeX0egdEPIGVKu39fhHvfgbK65vM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=HiStneaZ; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727742067; a=rsa-sha256; cv=none; b=Jwx2mQpd/AuBEC3K9ti0pacFF7GRNXTzMJQ+LqW+sX6ZPkfhjae8CNcRUSgd695RSm4Iqx +RbHTmW0yVkowbz4k+cbfn00zuBv0rLEM9ygZyxcPmLy1eMWLivS0tfk1Z8Ph2m2bhwcjb CWYNHhz3nGQT5PNvuY4RllPtTedAsTE= Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7a9ac2d50ffso419497285a.1 for ; Mon, 30 Sep 2024 17:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1727742130; x=1728346930; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vmEMUmiLlB6m/T/P5xBRLncvNWoi4hp4LZTs+dQITMo=; b=HiStneaZWYll3eMIbVaqPFVgoi+4/fDNDf6Cuhz6ZRs29J4d5NNNB6+UoL3XLgvkKY rPC0C93odJ1H+yyB5zHDjYmwaH8Ju46teUp37efFO1oRg0gVBsDRbCoLCAVLjpqkpKo8 PoQf9KHCZkTG8Ni5Jm6cQCPQ/Bz32Ttzvf9M602SVp+HkaG9u1BfKDbytNCogWqj9JYQ ETf4iVXPFbSYzOWDfGCrqdiPPbYDHFboUXqnb9FKW9dG6wdnztNwlk0aQF62KpKhQKF4 GwXsvS+UpzVA+w1mPLq+Wh0StqbAI4XqRldUcpI44AximCr5pGAciN9D5l4/9K0cLmiq +n7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727742130; x=1728346930; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vmEMUmiLlB6m/T/P5xBRLncvNWoi4hp4LZTs+dQITMo=; b=YW0gWlsjF7IKNX5euexGKo5nbDswe75/CoqILp1uLuWLAQjdKbDWvDU5XpEtIxwMCz VsGU5x1cA0E82jvCb4IVYq9K//FbkXD7V5KUVzzvy20Fzskuwa2wiJqeZOgagOxH1oHW QH+uxiX2kCQHE9MZD4v/xcOy5ZdyqXPHxR/2vcIgCAOErqXp3naEcgLarcsJhZyFkcVh /ncHv5Ci50Nrepi69z2klLDA48yls06g1FTXSVDz8rPv+Q2UYmHljsMTpVU3hBXY+LEa CvJodMfmwWPSLcF3m/OpVSqG5GWVJTkPMN7xRi+gHAtvqQIV+QrSJizZaiFLjf9eBH7g c59A== X-Forwarded-Encrypted: i=1; AJvYcCUQNyl+fds2i/49qiI1POFMrNREDL1+/EcjWYm14Cyn5+5LR2Mdv9lns77aE5Jy4DcrAD4r22RD0Q==@kvack.org X-Gm-Message-State: AOJu0YxgVW7hTGsxACVgIGg2zkpIF0daDNlsGRiaBT9L8t1CwUCaqLqQ x1YaGUVmVbL8oujItR43wJ153LlBKXVlN9JizrpILEV2k6xBUs82UdHk8DhlWP4= X-Google-Smtp-Source: AGHT+IH00sGjApfw8Q08fLdU6Khjgn27dLqCwr8RPVTJIvXjW9eQUAC/pBFTI7E7vu7z7LywpcOfWA== X-Received: by 2002:a05:620a:25d0:b0:7a9:c0f3:6425 with SMTP id af79cd13be357-7ae5b7f92acmr294180285a.3.1727742129803; Mon, 30 Sep 2024 17:22:09 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:97cf:7b55:44af:acd6]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae377d8699sm455524285a.40.2024.09.30.17.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 17:22:08 -0700 (PDT) Date: Mon, 30 Sep 2024 20:22:07 -0400 From: Johannes Weiner To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, willy@infradead.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v9 4/7] mm: Change count_objcg_event() to count_objcg_events() for batch event updates. Message-ID: <20241001002207.GA1349@cmpxchg.org> References: <20240930221221.6981-1-kanchana.p.sridhar@intel.com> <20240930221221.6981-5-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240930221221.6981-5-kanchana.p.sridhar@intel.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: E2B04180004 X-Stat-Signature: 59uj1zaogipi15ht3ad7qprdaq3ahxfm X-HE-Tag: 1727742130-523843 X-HE-Meta: U2FsdGVkX1+pxBtkxY6lb+2QPuCXXpGLKY+diP+H3Fos3UWx8KP+SkUi3WWDmTMOe0sjMEVOcVYFlj/oEhv/nNeg9qlfncbStjDUfBVGsWhzhKVab+/9gCI+YbFZ0lWBpzTB6uX7tXeQgwX3WbcG+xq0CAOLBQ56QoPLoVTMzzuSthFp9ep+vo8BDxjSSuRM4q+WV+LJ26btWEOtoqPbD+18e342UiKyEBXBGPPPbYXDaPqEfTC5AjFj6Lw95u5Ngsdru+KJ38ST6Ih+piuj+P1gO5iaQ55S1/GWqn8Q43dNYFanEbGUDm4VMHOG6nfggN9TQVY1SxMY57ctiRq/16vEYW6uqtV+piN/Li4gnSTIbagB4ntme0sOuy2f5G7ZapPdYFCbSLISxTmtxeNkhahOdezih/Ev4/6S7eyDDIapYQWp05vQaESOhtGPHIWpn9Q3Qw9VF1RWn+HGEdz+mgwebBc6gK34Vz9ResJzt4pn+wyim2B+aN4FIilTv/j/4JwMtNJaKRkuMwHVJsQtATcFn/98sa9Fz30RshwA29JHnIBx7FjOJSEG/ku6NRbA1AuVRwbrwqEi1Uj1SNKaL4DA/svPhAxL8XtBJDxNOS3KeiIWHqUwagYlHxskvoHlx+Fpx9uTaYSg+Hp+F7zZBo1wA7IhLthtXzYF2ZUIzE6Y4vrLl553mvmOL6vrfcNeSMQvIjPlP0YdooYKuBYZnUv3qOXrmZ8px3sLdMeT8UUPM4CWePbYaLwO9tY+fReUZQ4Jc3KzV8Ud+uSZ0pm1x+8HiKXiCxuwekuaCdoS6EZKl8UieAghgQHM7GrGgpuuQQQsnozXm/C/3+O8oUdnNfTjdsFQCS2vYIedKNSXlAKcHGHf8cagjEijvsRn8L6OUV9JYJZ4cxG6gPsuGYGEFBqVRqhYZrIfTvplzuTXkxHlyHe8u+AUSCwbRMKe9N9SMkBbvg7Y1QVAq7omFPN vIwZsreQ qSaMUyd2kuDGUgx4kR+tAFsPqOt8ejscyS1Edg7i9he2ZjjMM0Aj/k0ypg3quvVdzv00jdLQitXnsuBTM5ySddHWUKkrUZOGvNMv3hkU0UE4MZaUObxXeEUUzseB9wgxcke63YQPrFT3/XbZKWP4qFBRFD09cs4+T1ZYDkkzTPcwMQo/H4XpJB4b6eJV32JlnDcdplcQmqzd3U6zjn2fFCFKlgfSO8o9+luE90jrm0yIwFWq0Kt/xp+SXFpEpOvKHlguIEkqHqAlytni20rQEE6vc2+RbVMueMuy/Jc0OV2J5MepBKRVjQMt5SFTAQ1KrEPa1DfWdn7JMBCz2Y0TUgwvSN7A0ho/HXLwrNqfYVNHm4TLxOFxRdBUQOcUiTLlFF0TsVb1Mzt5Avkt3XdGWBluyaLk07dr4ZQ4tUspizpPcKpuAN0PJzE88Yk8cdS93gsFoSSNgBvWdOiPjlgiVlFkl6m0jrLmNrqhzyFS1sImIcPlX/FeIfIMVK2wgnrnmV6O+hzQ3PTb3zeSlFzLq4IAv6XOoLFvWuWaxn2zlRpFULvg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000281, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 30, 2024 at 03:12:18PM -0700, Kanchana P Sridhar wrote: > With the introduction of zswap_store() swapping out large folios, > we need to efficiently update the objcg's memcg events once per > successfully stored folio. For instance, the 'ZSWPOUT' event needs > to be incremented by folio_nr_pages(). > > To facilitate this, the existing count_objcg_event() API is modified > to be count_objcg_events() that additionally accepts a count parameter. > The only existing calls to count_objcg_event() are in zswap.c - these > have been modified to call count_objcg_events() with a count of 1. > > Signed-off-by: Kanchana P Sridhar Acked-by: Johannes Weiner