From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D503CF649D for ; Mon, 30 Sep 2024 10:05:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 298186B0279; Mon, 30 Sep 2024 06:05:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 247F46B027A; Mon, 30 Sep 2024 06:05:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10FBE6B027B; Mon, 30 Sep 2024 06:05:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DBABB6B0279 for ; Mon, 30 Sep 2024 06:05:26 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 65763A1CFC for ; Mon, 30 Sep 2024 10:05:26 +0000 (UTC) X-FDA: 82620972252.09.694D6FD Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf14.hostedemail.com (Postfix) with ESMTP id 90B60100015 for ; Mon, 30 Sep 2024 10:05:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=breno.debian@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727690622; a=rsa-sha256; cv=none; b=rS3SmDl3wFReTvKbUsunXjL47ugFCUxYoOBlb6y4Ui7Cn+YGb7hdkCgK40+ZBgTwBfrngi yMjMvtgvs28v+8lzySJcPMmB++L7SSPvulgFiUWu+WvtXXFtnVR/xBVPHSY7kPcBBfOVz+ G5KPhns0McDbGr+bdPHOMBlYLlEbjr4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=breno.debian@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727690622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JBieAD9/yGWjzkACpfrN87DzHeRoFJFlEgT7fzyXuhc=; b=g0hbVF1wfX2MdAA5Pf7ebV2bed7qHBFowkDEGDVroVf+JwIGLMg6L8fML9qKYLcA3rWAtJ 5atjSMGgsQilk4IBUciBs7yR9MwJKeYxCnbpVNlLG1k40N/ttqv8S1OpIOXsFdlHI95YYC Cy+s9FT3Sn3aBUopyilbR2DohG5djO8= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a8d6ac24a3bso771508966b.1 for ; Mon, 30 Sep 2024 03:05:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727690723; x=1728295523; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JBieAD9/yGWjzkACpfrN87DzHeRoFJFlEgT7fzyXuhc=; b=gNMz+xtxbnn4dlHKZUDHSX7B71RlCnHiAhQa7E/oFHRhMuVkU5GrFNuHbESDjHjIbs +IVs/ak3BtVqDXddZOYFzi96j1CchJycLDo+reIiNK7gVCw6QnObJwvcAK8wsWBCBZn1 8HtZW3IEFsrBbeXsgJH3WnjlwCWEdLaelReR9gwgdFVQr5gkMwPcxEbWlBhQYNgm5BiM 30fBD7qZWn6pW/O9QHp39efzd65ZOlGudduWvK8fFOtwT3ozYv4OT1m6/UXXUorls/PV q9sKdDFkl3qdbP4hE6/9PBpbryzrrMxMxrjRj760Fkqlynih7hF4fTWHEChU5GCJu7gS 7CVw== X-Forwarded-Encrypted: i=1; AJvYcCVkBp3+Hk+iYSFq5ue009FS1Eji+r6P74QcWyJOI8iZsfFZq878L10ToSlhfuyHUC7a0u8eB28kGg==@kvack.org X-Gm-Message-State: AOJu0Yw+VTRiZXgQja7JzoCiE9+gZo1rTwbrptmb15WfppjZnI3Bkf4c Cp2NFfJ2a9QmXfIxpCR2UmN9hKiVEiSFqQiKCzYNkvMyo17pBAfm X-Google-Smtp-Source: AGHT+IF9ytZyajrXNa9tvYoariFi9zOWXuAqF6rDhp0J/b/2+2uR/tfbQA2NKEuaEIu79zrfEGCgfQ== X-Received: by 2002:a17:906:dc8f:b0:a90:c4a0:9b17 with SMTP id a640c23a62f3a-a93b15d456bmr1707784466b.9.1727690722713; Mon, 30 Sep 2024 03:05:22 -0700 (PDT) Received: from gmail.com (fwdproxy-lla-005.fbsv.net. [2a03:2880:30ff:5::face:b00c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c297bcccsm514568266b.173.2024.09.30.03.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 03:05:22 -0700 (PDT) Date: Mon, 30 Sep 2024 03:05:20 -0700 From: Breno Leitao To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Andrew Morton , Shuah Khan , Mario Casquero Subject: Re: [PATCH v1 2/2] selftests/mm: hugetlb_fault_after_madv: improve test output Message-ID: <20240930-loud-brave-cassowary-0aecfc@leitao> References: <20240926152044.2205129-1-david@redhat.com> <20240926152044.2205129-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240926152044.2205129-3-david@redhat.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 90B60100015 X-Stat-Signature: migzz66mjg6fanfe1bmws9kt6dtudty3 X-Rspam-User: X-HE-Tag: 1727690724-239114 X-HE-Meta: U2FsdGVkX19sqtiWy+n/JSE8sRzo3zO+QBKwzsfQKRrStNB5l03XFomT9Hc6Z3Sq9ovjoBjHlFNSTtWrm70QLkxmOyfG6/n5Cki6o1c8Xd0lvlmqmO+Q8ngLo262I3d9mIF5GtJrH14F+yNDyeKPl6nykz8WEusfz34JEp5px9D0EcYTY/YUxxEm0ctJuG1DlSsphpp0Y9OfFLlQyi9neoEi9LlKk7bVOpbAN1gvBQic/O6m7q58Tgx9eArPH4y0rLOplFWh/e+P3vtwSe+D4KpCsKRdAhlbmDncGzE0/YdsAjO7GeO1GajIYcaJgjyAcAbCz+qWW+m3OFv7UxJbS28zluQnEhYjyJvLVVciMV4ZOnhwe9KPx9EoZeq8ezeHVnjEJVZPN8HjORqD8UeTeuh7u2ff5xFF+pf5CfUvTGguXUch7FiO1JrxixlVl+BJC2ggS4J0YQZXn9XAuKoj4LKaaJOdpLhlkr+2CALM/Jd5FXS9O79/zrafCp/cpjcOqbW1YWNADrgh/+OqoqOX0E/Q4uAuZJ2hz7/ZTV7nrVd0WgJoiwRYg59S8WTDwzYp32BsOS8qeeZ5ndpuRdaZqkoHW9dC7mTc7O2Szdw63rVk+x782wNm/8fId36/thVm4C8ToaioQqBf12bAOG19i//uKHVofuYcQTLGhRNvzLuk4F/AxwDBLwJ9mEoRwSpPveLPdHiFNv2yUtcK03uDFcp9K1IrvroPiyq/giH0LKxRbLilBc+gM9TuyjRqLZDgtKfkrAB3bXGxPEdrK6v6rMzDlcQpJ2J1ctZSmfHrQ1KCryEqVN5kS27d4zxj2nBR6dz5vtOxB5JCoU9rBl/SRgEormLkVYxD4L+OacYeguT3e8YaRa60yg+4rG9ylxCsC5U0s/+C+2IRAJVmpA/+QyYInQ7IUzpa/+FlYk+Pwm2srTHampTeQfOq6L1LMhVNec5ZtIdbSNKicx/3eGI cUty5rKD 3dI4kEmAd9iLR2augq0/CDvdAZcqIYw630LPcU/MJuJLHRgSggG99458/tu+Nh6T45SxcpPDwWep6hZZOYvrqWbobuZfrGu4TRyk2G6MKo+2SIo4PtlFkOZ9tpt/eJOUoNzDK0yUgX9+zaa1wWEYrYyogkO5+LW8B7JNJGnJBm/+T0skuDywcg0mMfumVICLnk+p7hk7wSqy/tbNRA3h2H1/yFzS4/9fy5TTb2VEbyYWiwVjLy2QIuoLTDZ/NOtjPJXSvP1B6WPFW1arsT2FPbUCurd9lvyFFVM09jjDhCWMjipBNk53ATm8CgTgMf1msIBZBGjbRcNzpFNTDezfln6pnGJFu/fg5qdm8zuZMRXEc5RTJGQCMDHUgfOd1/jIrOU/V4XwR1TuWCRzNmUuohso9n2WejDakpSsX5a/m+z6GbLtFChAZJiu9POr9bZcT6YRSOioqfhP7qcAd43SLu+rGhuQiNt8Y51xE87HQ3wIDXs8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 26, 2024 at 05:20:44PM +0200, David Hildenbrand wrote: > Let's improve the test output. For example, print the proper test > result. Install a SIGBUS handler to catch any SIGBUS instead of > crashing the test on failure. That is way better now. Thanks for improving it. > With unsuitable hugetlb page count: > $ ./hugetlb_fault_after_madv > TAP version 13 > 1..1 > # [INFO] detected default hugetlb page size: 2048 KiB > ok 2 # SKIP This test needs one and only one page to execute. Got 0 > # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0 > > On a failure: > $ ./hugetlb_fault_after_madv > TAP version 13 > 1..1 > not ok 1 SIGBUS behavior > Bail out! 1 out of 1 tests failed > > On success: > $ ./hugetlb_fault_after_madv > TAP version 13 > 1..1 > # [INFO] detected default hugetlb page size: 2048 KiB > ok 1 SIGBUS behavior > # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > > Signed-off-by: David Hildenbrand Reviewed-by: Breno Leitao