From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2989CF649D for ; Mon, 30 Sep 2024 10:01:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D9C76B00EE; Mon, 30 Sep 2024 06:01:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 662316B00EF; Mon, 30 Sep 2024 06:01:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DBA580027; Mon, 30 Sep 2024 06:01:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2953A6B00EE for ; Mon, 30 Sep 2024 06:01:21 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C65CF141CF2 for ; Mon, 30 Sep 2024 10:01:20 +0000 (UTC) X-FDA: 82620961920.21.929C0C1 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf23.hostedemail.com (Postfix) with ESMTP id D4B1A14001D for ; Mon, 30 Sep 2024 10:01:18 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=breno.debian@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727690376; a=rsa-sha256; cv=none; b=Rfuhsalq/AG2vMKU9UtEO9rK98ema9L1Eahd7os9MJzijHzAQavhf4LUNirDfJ0SvvXZHH V25rR5W/UVgLLX3A+3gPy4uF18za48D9cYvjEwvPSYzHknJ5FlPULGzOsraFoOsdcfYbJm 2E3ju0CQXoGbQzYUkyN8begrVruWwxo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=breno.debian@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727690376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dz1ZPwD+OFOrMlNTUkXUde4zQolmtMFgXnEyYHIosvo=; b=7zBnds1mipKhDfEqM2/bhRToR2qhxEBoHLJyQWICQL+Aj02tV5UBDaJ/pzxyRyTS5U3WaW MBV+5/X3mZAWaytEeqgIwFYt1JQRWt12pYzYSBfYqfcc1QSpN+linpG7sjr0QM1+COB4LH 6pI+dN6FRmM/3xNmwRwUogtWuc1U03Y= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a83562f9be9so468827666b.0 for ; Mon, 30 Sep 2024 03:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727690477; x=1728295277; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dz1ZPwD+OFOrMlNTUkXUde4zQolmtMFgXnEyYHIosvo=; b=a0qjiitGw+iFuc7HTwslkmGx1bP+kdRgp+QdmU8hk4+yU2RHA/v4O9rVlRb14JOtAs YEPGogsDb8dG8/dxPYPTChBGQxwGmT4jjPFEhiZlAHnS4izZ1zPRUyA53oJYccMJaU7K gTupsI6ZOM0QS2veLX/2Ajo7/eHwafIEE2Da5Udex5L1aaq19271roopfu7M2+MIN2lk 7WrGVvzSMjb6XKo6zOEcvcVOrLL8co7BBjg5dAL44+wOwPPL2DkZqRFP9c4PtztyWc8b XFkj7V49TPzbtPu9ifDaJTz7vvO6oHPLaPjME3ietgOvLVqedK6Lvu2cJ+hVk6jwjZb2 6DDA== X-Forwarded-Encrypted: i=1; AJvYcCXEc9CnW1UvJl11N974ngrsSJ1WYsQrQ9Ruxrfzs0gNwiLpvlr1KC1tFN/mnimEXiaeEMdytJF3Jg==@kvack.org X-Gm-Message-State: AOJu0YzQa+jIZpkLcUi/25bZwIwxR8b+lDwHY9yLP1QfKZ6B9Ml8pKk8 A7nBEmnCsctkfo85oJR6b1KPXUVDV2q5DnxcTX8DVsNZ777QCaAd X-Google-Smtp-Source: AGHT+IH7sUn//ezn3oq6CKzmNFo6XW+V2Xva71KoBqYZHEiIz4n/WorNlpvjGnLoDscqtA2AaiLpwA== X-Received: by 2002:a17:907:7e85:b0:a77:f2c5:84b3 with SMTP id a640c23a62f3a-a93c491f380mr1022495166b.22.1727690477266; Mon, 30 Sep 2024 03:01:17 -0700 (PDT) Received: from gmail.com (fwdproxy-lla-007.fbsv.net. [2a03:2880:30ff:7::face:b00c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c297bb8fsm514708166b.176.2024.09.30.03.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 03:01:16 -0700 (PDT) Date: Mon, 30 Sep 2024 03:01:14 -0700 From: Breno Leitao To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Andrew Morton , Shuah Khan , Mario Casquero Subject: Re: [PATCH v1 1/2] selftests/mm: hugetlb_fault_after_madv: use default hguetlb page size Message-ID: <20240930-burrowing-quokka-of-serendipity-f35eb4@leitao> References: <20240926152044.2205129-1-david@redhat.com> <20240926152044.2205129-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240926152044.2205129-2-david@redhat.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D4B1A14001D X-Stat-Signature: c4cc8djxjjuuba6ipxs3jgofs6akq3yx X-Rspam-User: X-HE-Tag: 1727690478-561758 X-HE-Meta: U2FsdGVkX18eYKXWKGeWt6wGrsH7R/IsfxnqwD7koXBuXgo/fA8DzVBVWHzMYe2W6KNFQQVDdANa4aIRK0huj3UqHFBEJyZ5fVX6lsTrf2I7Zko0Uayc08h71q40suKw1GXhEImrBDU4N0q2STRErw6NKgSYDFf37/tI3fVo5ImM/W7pr7V1YtS89vd9lpFhDCmhxDt9pWzvGR0wWvsMClW7IlwSFHVtZhjIS9zkVpSn7DOyH0Gs2Pa6JOCytjexLkkfqJvN3P+KNI8tDdYQVZrdDLMFC+r5gy3cPLV126vrw36fJjOw2nAZiZuroJU6woL6NbxovW8bjhb+ATVQ8ZmAKsNA/Vxr0wzmCPgrBsutRTagWfwTuQFqFW0O48ReM3s/9YlEHuqNqb8FlzAb90PD/T4DI4LpuwZycVhqG9mJ9k9gA+5yh59JemG0J74khq+Q+CzmeWH1e5EFxW8OVZ7g3NjkhTgQ+A9Tb8RSTYPylOnexdicU8rsL93CuxITgthIFjITCqII/8mZRxbAAXmBCGa41nJzcx50GrCuBwpQszpPKch21znel2fctOyxlF3UEJopEyTJV3kWrl0lyOuWapGaIsMRL6qQE4/Kay/5FJuaieouRehLJSf2Y6Uy0ZaiRXsqsoJhpcqngnFro5S7Hgk4i4LxTi/q2eHrlB+nNW1QgSP2wZLhALOOcCDoq8PEjrzo7a7j6asrR+SDFHJvu3Y99zEyviwtevAcEwD4KlTOiveJNY8pXG7dBF7LyCeCdI54BkrabMNYEQQM27NJzKIC47DeHvppgfpwJ19vmD2v4N/xkeI8DFLrckPtmY2PmFXakuswCtydeWtp0T8B4ImNGU94/9CkpVVvr9yqQkwj+Y+KGIMnTIOQHMUYkh9VWfYUQWwQ/NabQxIoiegD3/CX4c3RwEN6IljR7i4JQKbkaL5qXt6bygelEYpcACy9o8Q/fAS9eBkuFjA YhGs2D6h RS3Qnq9kLcipptSG0pjuTeGXaMEZR7mZ1QvttuJ4XmDLD4EQAV1XUoGjtkyxoVZUVOOEWOpM4Is0Ymy7fJZARMuh+Vs5tFQbjqU4BcQagJ87xSKa6bC4/r0KmFyxugZbTo1b/KxllSNTUA+Q2QhHDh0DjustHUpK9LAYPd6Wl0s9w2gl8AlMY7GFoqEJ7yZ5xF6h3/s72NBK1o9L4OhvweKBHoVYHaK4E8og5palV8HtEBNEdMlQaz/VF6RYM2CoiSHf/fcaLjrdrXiin/viljavPHxiPVn5WEtrQ0PDdhclyN+CwDpz2i05a+LcQJ6/62GFzFj+zvRmPMlvW0c8/AkXQ3Y5qG0az/I+iiRqESKYRZeWM0QA9yMQIn+rTx40DIuPJpRmftr42jSKGFEa1eBYcoiHnwIm6091z+eBHPFhMwuoq/rCz2UkGq1HUHPSeiM/fi6JqSXqo5Lr4hDPv7MerYGPwDe3Hyzvl2duOrtoWfq8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 26, 2024 at 05:20:43PM +0200, David Hildenbrand wrote: > We currently assume that the hugetlb page size is 2 MiB, which is > why we mmap() a 2 MiB range. > > Is the default hugetlb size is larger, mmap() will fail because the > range is not suitable. If the default hugetlb size is smaller (e.g., > s390x), mmap() will fail because we would need more than one hugetlb > page, but just asserted that we have exactly one. > > So let's simply use the default hugetlb page size instead of hard-coded > 2 MiB, so the test isn't unconditionally skipped on architectures like > s390x. > > Before this patch on s390x: > $ ./hugetlb_fault_after_madv > 1..0 # SKIP Failed to allocated huge page > > With this change on s390x: > $ ./hugetlb_fault_after_madv > > While at it, make "huge_ptr" static. > > Reported-by: Mario Casquero > Signed-off-by: David Hildenbrand Reviewed-by: Breno Leitao