From: Gianfranco Trad <gianf.trad@gmail.com>
To: willy@infradead.org, akpm@linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
Gianfranco Trad <gianf.trad@gmail.com>,
syzbot+4089e577072948ac5531@syzkaller.appspotmail.com
Subject: [PATCH v1] Fix NULL pointer dereference in read_cache_folio
Date: Mon, 30 Sep 2024 01:05:50 +0200 [thread overview]
Message-ID: <20240929230548.370027-3-gianf.trad@gmail.com> (raw)
Add check on filler to prevent NULL pointer dereference condition in
read_cache_folio[1].
[1] https://syzkaller.appspot.com/bug?extid=4089e577072948ac5531
Reported-by: syzbot+4089e577072948ac5531@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=4089e577072948ac5531
Tested-by: syzbot+4089e577072948ac5531@syzkaller.appspotmail.com
Signed-off-by: Gianfranco Trad <gianf.trad@gmail.com>
---
mm/filemap.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 4f3753f0a158..960f389e2d3b 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2360,7 +2360,10 @@ static int filemap_read_folio(struct file *file, filler_t filler,
/* Start the actual read. The read will unlock the page. */
if (unlikely(workingset))
psi_memstall_enter(&pflags);
- error = filler(file, folio);
+ if (filler)
+ error = filler(file, folio);
+ else
+ return -EIO;
if (unlikely(workingset))
psi_memstall_leave(&pflags);
if (error)
--
2.43.0
next reply other threads:[~2024-09-29 23:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 23:05 Gianfranco Trad [this message]
2024-09-30 9:02 ` [PATCH v2] " Gianfranco Trad
2024-09-30 17:02 ` Andrew Morton
2024-09-30 18:14 ` Matthew Wilcox
2024-10-04 12:07 ` Gianfranco Trad
2024-10-15 11:57 ` [PATCH v2] mm: fix null " Gianfranco Trad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240929230548.370027-3-gianf.trad@gmail.com \
--to=gianf.trad@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+4089e577072948ac5531@syzkaller.appspotmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox