From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D1ACF6497 for ; Sun, 29 Sep 2024 18:55:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EAFC6B0170; Sun, 29 Sep 2024 14:55:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 574AE6B0171; Sun, 29 Sep 2024 14:55:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EE766B0172; Sun, 29 Sep 2024 14:55:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 187B36B0170 for ; Sun, 29 Sep 2024 14:55:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 588001202C2 for ; Sun, 29 Sep 2024 18:55:09 +0000 (UTC) X-FDA: 82618678338.30.124CEE1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id A210240007 for ; Sun, 29 Sep 2024 18:55:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fr9kzvy9; spf=pass (imf04.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727635982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bGJCXemhC9dAtd5JgEfyPJDtjJnxzGiGPrBvY6sj9XI=; b=Xi1nPS0P3wxmG5waeFIwpfdzd5zuve8x4bqzDI9ObbACPdgPZFCD6Zs4nMI5EvlIe9gyLe r8xQu9jDW/ZFhXqre3RJi0qNi3H4SZ+dHo3T9uS6SgyKHQVGZgeAXr2NbFtLX4TW/luVBl 9W5DaZ+ivd0vNVNpXQ9Pdu3xu719460= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727635982; a=rsa-sha256; cv=none; b=3Ifa3IPagjVNJSQGoi8A1Yff1sy66lPIe5FpF2nc/rlH37THVnnQoVtL4gY3JbZNGxwzxP Ffaly6H+uURzB0xp56sTRuyGVsSPepeH+Kijh0BeAWxByglL+in0j5w7S50mNp59nWJWTX YnJ157GjqoMnjqdbpeeoW0YGsktRIm4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fr9kzvy9; spf=pass (imf04.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 935CD5C0709; Sun, 29 Sep 2024 18:55:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75091C4CEC7; Sun, 29 Sep 2024 18:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727636106; bh=jAulFupwHSoaUi/6sQaBbxwLwD4EQjNV6hWdaK3VMeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fr9kzvy9ZvXrAyv2UllxHifNu6IjR55if6yiVZdFsqEDWM8KeUI0i2OOazz1sJWgv C7FEhIX+Kv8rKL4HR2qbLhRniIw90m53J/xKlPjSUHTvLxQzmeHsOQfGpPe7zNPydx igiQKwOCunehcDRZ98DPEJvFwnQX6F+64GRE+zGIQbZUCsERuI8uzf7wQWQyYH/LgQ IYBhLr3Up0Y5MYZrivJNKR+oquf3PaSy3JHujxIAywf0gC6wdBK0Vp5oFNxKDhmmaA kX0Ijo0JsbL2WuHZ8K+T60FaR2mcFykzg5maIOHz5Do5MOUwczMMHqH9pe8OEFonhF Rq5ezJWx1L3ug== Date: Sun, 29 Sep 2024 21:55:01 +0300 From: Leon Romanovsky To: Eduard Zingerman , David Howells Cc: Christian Brauner , Manu Bretelle , asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading Message-ID: <20240929185501.GA218692@unreal> References: <20240925103118.GE967758@unreal> <20240923183432.1876750-1-chantr4@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <1279816.1727220013@warthog.procyon.org.uk> <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> <2808175.1727601153@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Stat-Signature: ahkz84p55ofuphkzp5eb6466wa4ge8j3 X-Rspamd-Queue-Id: A210240007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727636107-128200 X-HE-Meta: U2FsdGVkX18fEPaG23LKTmRCYMz9HXEsDvXHO/siAzWPLqnrRWh1L9OLkySY0WgMJO9mRDARAy4MKZ4I82TxM8N+JxHdcutYiXzZGE7yMVam2+SBcvJCWZLMJoYBGYEbCEQ4rQEdH/0gjcFM+Fn6xY+UENWXkDltvSleoCsW5TEmTcbt1/Bws10aBOcuE5GFoM225WvyYuRTnPABRcuM5YjXO9tQ3ndS6mih2El1KJWQQKKbXuTnlwl1JuszdFlvqOTTRGlY+H3C7PtcPLoMwDwHApDWqviTtxo5jefyEkDhz1itVNyBqxSkjfXVcajpIMUvWmm76i4nFmOuOZr+kadQbfHnssoDVWSbOYdHgueJMt2s0AK+0WuD5H7FNrGle4jrwZLFBMPgRfn/IQ/eYsZJlsKylIK8RTrD6I3QULVPg7xIocs+6hPU7pJ8lkVql3LutEvO2uWv7lu7BDI708yHXZkVYWd5Bl49OzhwhXAtNTJqgK3CsuubgDHcBUJW4u/Xc0XIBCOL1nMuxCBp6C8GKp0kiDvCnl4xgFuiU7U/INP1nMgA5gDZRKyL/6IP5vZAQuiMoZ5etIINeNrirdpBwnaKlatgAjwStsQlaf27StQ3RpO+KiGKSgxHhRzFfnDsfIu4CaIvYZTIy9CrWGrWk2QUDor+vhZYe4pvR7yyiq60tFSwCA60I9qIxchtVmrx2SHWVLQ3RW60d9o6SjLL4jXe+tpJX107F9F4zuZcTGQ6MW6ktmzhgWJnTW5+JWHBLhb9oJ8ZYxy0Dstc+nbeh5va/ppvx3NzbY+k0sZkzQVWKrksWPMhBo+B5UwyBdkgrr7HIDGxcSeUX6qO3CAy6rEnYe+O+1YNLyPEvVAWEJbHg0+hdD3GCzbmC9VyFlXYXQoq1ctUHzZOwY5eNdgxgC09LlUbI5/F5/Ed/f6k6f8a8xRdZwYo4yeJ0ShXp4HcrXoXEquw8RXPek2 XrRYbaXA HM4955Vp7d3S3iVZaf2pC645KOAm7YDy6VccZve41nG4V/7RWftkVjTDZ3gr5kB+FES5+hesw+DZlra0P+5h8ez06S4ITNUnPWVY3nBtOK083rpctVsIaKVvrgY1GlhFnWngaozSa6glmFloyb+4neDI1zJTYcxcB7jM5ZK5qaL+TPQsWwXPGkMIjy3FQ0pcJWS25I+dGG3XgFDd9iWGnOARjtkdw9rX484IPPfsBPYeV49pwl0lzeXCC6oX4NTLqE1ko7e5S5/J8SFKSKESlwPlBvgffm/JMWLfAzBy7zmQaZqNOXZns3Wsc+K3looj4ZGQvVh1IQtmba5c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 29, 2024 at 02:37:44AM -0700, Eduard Zingerman wrote: > On Sun, 2024-09-29 at 10:12 +0100, David Howells wrote: > > Can you try the attached? I've also put it on my branch here: > >=20 > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/l= og/?h=3Dnetfs-fixes >=20 > Used your branch: > fc22830c5a07 ("9p: Don't revert the I/O iterator after reading") >=20 > dmesg is here: > https://gist.github.com/eddyz87/4cd50c2cf01323641999dc386e2d41eb >=20 > Still see null-ptr-deref. I tried it too and I can confirm that the issue is still there. Thanks >=20 > [...] >=20